From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 800E0C433FE for ; Fri, 14 Jan 2022 18:56:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243565AbiANS4K (ORCPT ); Fri, 14 Jan 2022 13:56:10 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:49327 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243468AbiANS4J (ORCPT ); Fri, 14 Jan 2022 13:56:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642186568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=51ImlDEadEsctg6nVH5bEBazgwQXCgp/FsQbc0BxjHM=; b=TXwiIDFvsUZmxqS8YtaR4O58vY1s2m195rtKKzGxQlhx24rOPJfzJ1YNR9HaXniRkUVhf9 I2Ltlc/h5N7heS/dJckyfTbHGpw1R+6ytyHStToqyhTGp0Y3cVAzN07fo7YYl50DwBh95D wAzYixajvbSl84CMYs67o5cMsGm9XCA= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-629-yFfeuK3WMoWMC7lptXuPNQ-1; Fri, 14 Jan 2022 13:56:07 -0500 X-MC-Unique: yFfeuK3WMoWMC7lptXuPNQ-1 Received: by mail-ed1-f71.google.com with SMTP id z8-20020a056402274800b003f8580bfb99so8916603edd.11 for ; Fri, 14 Jan 2022 10:56:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=51ImlDEadEsctg6nVH5bEBazgwQXCgp/FsQbc0BxjHM=; b=BKLx72D2hPR99OCae4KWQQJNBehEVw6GaIIM3Ns4apEVIHOeHUh/WmTCKhdbRwTCc7 1Ju26fzxF6DCXrl3htnEFruK65rIHa9XBpXf/AD2a/uF6ghmzolsfpll5wBcNapd3Odu X9Qr+rQDx7D26HsV+stDNESzAITFg92wnDap/KR3fDuEAOIUo66ZvPGFPE2La0YQNU1V SMGW2XGEG+xvrUiwUFba01msskNDgDCo54w+jyjhpOqIWriTY8i68Alh7Bm4Qdoz7RtP GQXYajW0z8jUg7FW4Ihx+Gv70LcP92bFXoH79qwOBXjZLsL6u0/0h96RYZLlcHGIFBkq PCeg== X-Gm-Message-State: AOAM533LAc6/pEHeAYWZ2xxBZwxFV8M5s3qKm4tal66cfgwoegz+hd5O hToeKrkeOTbGAxFtoWzLJ+9lE/ryDFXQKzj4/lf8SP17l8rWshiC/PBNm9cOZKM7xmg/dt0EFQH gXyyo+9UtdPPZauHgDQnHzg== X-Received: by 2002:a05:6402:217:: with SMTP id t23mr7399934edv.283.1642186566036; Fri, 14 Jan 2022 10:56:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJyAnjfubbtpBrUe4OTbYQbUw+9LhVVYNB3cYNRwnppOgGUs9iR9DDM+srSbwA1kCbdnuGSAoA== X-Received: by 2002:a05:6402:217:: with SMTP id t23mr7399910edv.283.1642186565843; Fri, 14 Jan 2022 10:56:05 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id hd16sm2000023ejc.62.2022.01.14.10.56.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jan 2022 10:56:05 -0800 (PST) Message-ID: <55cb8127-65e2-4d56-5127-2722c5bfe11f@redhat.com> Date: Fri, 14 Jan 2022 19:56:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 5/5] ACPI / scan: Create platform device for CLSA0100 Content-Language: en-US To: "Rafael J. Wysocki" , Takashi Iwai Cc: Lucas Tanure , Len Brown , Mark Gross , Jaroslav Kysela , Takashi Iwai , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , ACPI Devel Maling List , patches@opensource.cirrus.com, Platform Driver , Linux Kernel Mailing List References: <20220113170728.1953559-1-tanureal@opensource.cirrus.com> <20220113170728.1953559-5-tanureal@opensource.cirrus.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-acpi@vger.kernel.org Hi, On 1/14/22 18:51, Rafael J. Wysocki wrote: > On Fri, Jan 14, 2022 at 5:19 PM Takashi Iwai wrote: >> >> On Thu, 13 Jan 2022 18:07:28 +0100, >> Lucas Tanure wrote: >>> >>> The ACPI device with CLSA0100 is a sound card with >>> multiple instances of CS35L41 connected by I2C to >>> the main CPU. >>> >>> We add an ID to the i2c_multi_instantiate_idsi list >>> to enumerate all I2C slaves correctly. >>> >>> Signed-off-by: Lucas Tanure >> >> I think it's better to merge this from sound git tree together with >> others in the patch set, presumably for rc1. >> >> It'd be great if ACPI people can take a review and give an ack/nack. > > Hans, what do you think? This patch (5/5) applies on top of: https://lore.kernel.org/linux-acpi/20211210154050.3713-1-sbinding@opensource.cirrus.com/ Which still needs some work and which really should be merged through the ACPI tree. IMHO it would be best to simply drop this (5/5) from this series and move it to the v3 of the series which I've linked to above. 1-4 can be merged through the alsa tree independently of 5/5 AFAIK. Regards, Hans > >>> --- >>> drivers/acpi/scan.c | 2 ++ >>> drivers/platform/x86/i2c-multi-instantiate.c | 8 ++++++++ >>> 2 files changed, 10 insertions(+) >>> >>> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c >>> index c215bc8723d0..2a68031d953e 100644 >>> --- a/drivers/acpi/scan.c >>> +++ b/drivers/acpi/scan.c >>> @@ -1753,6 +1753,8 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device) >>> */ >>> {"BCM4752", }, >>> {"LNV4752", }, >>> + /* Non-conforming _HID for Cirrus Logic already released */ >>> + {"CLSA0100", }, >>> {} >>> }; >>> >>> diff --git a/drivers/platform/x86/i2c-multi-instantiate.c b/drivers/platform/x86/i2c-multi-instantiate.c >>> index 4956a1df5b90..a51a74933fa9 100644 >>> --- a/drivers/platform/x86/i2c-multi-instantiate.c >>> +++ b/drivers/platform/x86/i2c-multi-instantiate.c >>> @@ -147,6 +147,12 @@ static const struct i2c_inst_data int3515_data[] = { >>> {} >>> }; >>> >>> +static const struct i2c_inst_data cs35l41_hda[] = { >>> + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, >>> + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, >>> + {} >>> +}; >>> + >>> /* >>> * Note new device-ids must also be added to i2c_multi_instantiate_ids in >>> * drivers/acpi/scan.c: acpi_device_enumeration_by_parent(). >>> @@ -155,6 +161,8 @@ static const struct acpi_device_id i2c_multi_inst_acpi_ids[] = { >>> { "BSG1160", (unsigned long)bsg1160_data }, >>> { "BSG2150", (unsigned long)bsg2150_data }, >>> { "INT3515", (unsigned long)int3515_data }, >>> + /* Non-conforming _HID for Cirrus Logic already released */ >>> + { "CLSA0100", (unsigned long)cs35l41_hda }, >>> { } >>> }; >>> MODULE_DEVICE_TABLE(acpi, i2c_multi_inst_acpi_ids); >>> -- >>> 2.34.1 >>> > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDA9AC433EF for ; Fri, 14 Jan 2022 18:57:11 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6420C1AF9; Fri, 14 Jan 2022 19:56:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6420C1AF9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1642186629; bh=tVxcndZpucXY/fxonjNTC9QP5PFOxTC9VPwEcDHNBLY=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=CLREesLYVTUNHcFkwDTYlRuWNhnMfSpyTfTLnlCE1/TpYdOqiMVgMUu9QtNndiXFn JqAxay8mVW6olxsFv79LCCJi5QicMjUWoPFeuY8Yfe+JkWWQ0Eh+VSZ026aLNFIZbB vDXCRBtyASaljdGKAzOX+K2ijPTjM3w+EtPoaPnM= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id F4098F80054; Fri, 14 Jan 2022 19:56:18 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 03CD0F8030F; Fri, 14 Jan 2022 19:56:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 00596F800CE for ; Fri, 14 Jan 2022 19:56:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 00596F800CE Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="TXwiIDFv" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1642186568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=51ImlDEadEsctg6nVH5bEBazgwQXCgp/FsQbc0BxjHM=; b=TXwiIDFvsUZmxqS8YtaR4O58vY1s2m195rtKKzGxQlhx24rOPJfzJ1YNR9HaXniRkUVhf9 I2Ltlc/h5N7heS/dJckyfTbHGpw1R+6ytyHStToqyhTGp0Y3cVAzN07fo7YYl50DwBh95D wAzYixajvbSl84CMYs67o5cMsGm9XCA= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-629-wN2IIqbqMICLhh3YrLKCiQ-1; Fri, 14 Jan 2022 13:56:07 -0500 X-MC-Unique: wN2IIqbqMICLhh3YrLKCiQ-1 Received: by mail-ed1-f69.google.com with SMTP id y18-20020a056402271200b003fa16a5debcso8895842edd.14 for ; Fri, 14 Jan 2022 10:56:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=51ImlDEadEsctg6nVH5bEBazgwQXCgp/FsQbc0BxjHM=; b=a+gRUCF4MxDCPDVd1Do1ULkDh49yQkVqZbA7+XL3emmgINYzcsiWoSuHsN2tu5ypF1 07ACpB2YYs2+gyb82HoSiWYRCHURRB4zDbwE6MFgQi5yRK/EoA5Ld7R8Ke3Ww6uufycK CLBZlrUFkF1V/3sG404Xl0AvRSww8P+kneEoKbImLsN46+zwtGnpkAa3mEUHmSKAyS/v +9/xa5LunBOvUS0emey9QqboQxX1FjXJHvOg7pjXDxb+NrDwI5MGeeI7LLYDv+OyAIXF cJyWcMbljm5A05NTu+xZGWUFT3i9ICf1qJaujYcMvKz7y3RvuW9FAd3dJHBhUFa0loFE ++og== X-Gm-Message-State: AOAM532bohD2BtAQy6XUNHtwl7EK2H4DGCzbK2jFxdefFpNMv4pOPP0z GwZoeDXfYD4Lq0g7gR3brJAHmL4LtNBH3cbF6+9/90vCw4N6ATmlS5P25/VNvil7Yw2Oviw+I1Y NurtTpn5QLB/bp0oO1hp0vcc= X-Received: by 2002:a05:6402:217:: with SMTP id t23mr7399931edv.283.1642186566035; Fri, 14 Jan 2022 10:56:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJyAnjfubbtpBrUe4OTbYQbUw+9LhVVYNB3cYNRwnppOgGUs9iR9DDM+srSbwA1kCbdnuGSAoA== X-Received: by 2002:a05:6402:217:: with SMTP id t23mr7399910edv.283.1642186565843; Fri, 14 Jan 2022 10:56:05 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1? (2001-1c00-0c1e-bf00-1db8-22d3-1bc9-8ca1.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1db8:22d3:1bc9:8ca1]) by smtp.gmail.com with ESMTPSA id hd16sm2000023ejc.62.2022.01.14.10.56.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jan 2022 10:56:05 -0800 (PST) Message-ID: <55cb8127-65e2-4d56-5127-2722c5bfe11f@redhat.com> Date: Fri, 14 Jan 2022 19:56:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.3.0 Subject: Re: [PATCH 5/5] ACPI / scan: Create platform device for CLSA0100 To: "Rafael J. Wysocki" , Takashi Iwai References: <20220113170728.1953559-1-tanureal@opensource.cirrus.com> <20220113170728.1953559-5-tanureal@opensource.cirrus.com> From: Hans de Goede In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Lucas Tanure , patches@opensource.cirrus.com, Takashi Iwai , Mark Gross , ACPI Devel Maling List , Platform Driver , Linux Kernel Mailing List , Len Brown X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi, On 1/14/22 18:51, Rafael J. Wysocki wrote: > On Fri, Jan 14, 2022 at 5:19 PM Takashi Iwai wrote: >> >> On Thu, 13 Jan 2022 18:07:28 +0100, >> Lucas Tanure wrote: >>> >>> The ACPI device with CLSA0100 is a sound card with >>> multiple instances of CS35L41 connected by I2C to >>> the main CPU. >>> >>> We add an ID to the i2c_multi_instantiate_idsi list >>> to enumerate all I2C slaves correctly. >>> >>> Signed-off-by: Lucas Tanure >> >> I think it's better to merge this from sound git tree together with >> others in the patch set, presumably for rc1. >> >> It'd be great if ACPI people can take a review and give an ack/nack. > > Hans, what do you think? This patch (5/5) applies on top of: https://lore.kernel.org/linux-acpi/20211210154050.3713-1-sbinding@opensource.cirrus.com/ Which still needs some work and which really should be merged through the ACPI tree. IMHO it would be best to simply drop this (5/5) from this series and move it to the v3 of the series which I've linked to above. 1-4 can be merged through the alsa tree independently of 5/5 AFAIK. Regards, Hans > >>> --- >>> drivers/acpi/scan.c | 2 ++ >>> drivers/platform/x86/i2c-multi-instantiate.c | 8 ++++++++ >>> 2 files changed, 10 insertions(+) >>> >>> diff --git a/drivers/acpi/scan.c b/drivers/acpi/scan.c >>> index c215bc8723d0..2a68031d953e 100644 >>> --- a/drivers/acpi/scan.c >>> +++ b/drivers/acpi/scan.c >>> @@ -1753,6 +1753,8 @@ static bool acpi_device_enumeration_by_parent(struct acpi_device *device) >>> */ >>> {"BCM4752", }, >>> {"LNV4752", }, >>> + /* Non-conforming _HID for Cirrus Logic already released */ >>> + {"CLSA0100", }, >>> {} >>> }; >>> >>> diff --git a/drivers/platform/x86/i2c-multi-instantiate.c b/drivers/platform/x86/i2c-multi-instantiate.c >>> index 4956a1df5b90..a51a74933fa9 100644 >>> --- a/drivers/platform/x86/i2c-multi-instantiate.c >>> +++ b/drivers/platform/x86/i2c-multi-instantiate.c >>> @@ -147,6 +147,12 @@ static const struct i2c_inst_data int3515_data[] = { >>> {} >>> }; >>> >>> +static const struct i2c_inst_data cs35l41_hda[] = { >>> + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, >>> + { "cs35l41-hda", IRQ_RESOURCE_GPIO, 0 }, >>> + {} >>> +}; >>> + >>> /* >>> * Note new device-ids must also be added to i2c_multi_instantiate_ids in >>> * drivers/acpi/scan.c: acpi_device_enumeration_by_parent(). >>> @@ -155,6 +161,8 @@ static const struct acpi_device_id i2c_multi_inst_acpi_ids[] = { >>> { "BSG1160", (unsigned long)bsg1160_data }, >>> { "BSG2150", (unsigned long)bsg2150_data }, >>> { "INT3515", (unsigned long)int3515_data }, >>> + /* Non-conforming _HID for Cirrus Logic already released */ >>> + { "CLSA0100", (unsigned long)cs35l41_hda }, >>> { } >>> }; >>> MODULE_DEVICE_TABLE(acpi, i2c_multi_inst_acpi_ids); >>> -- >>> 2.34.1 >>> >