From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B1EAC43460 for ; Mon, 17 May 2021 08:46:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2E485610C9 for ; Mon, 17 May 2021 08:46:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235709AbhEQIsJ (ORCPT ); Mon, 17 May 2021 04:48:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47490 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230312AbhEQIsI (ORCPT ); Mon, 17 May 2021 04:48:08 -0400 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 799CEC061573 for ; Mon, 17 May 2021 01:46:52 -0700 (PDT) Received: by mail-wr1-x42a.google.com with SMTP id x8so5457431wrq.9 for ; Mon, 17 May 2021 01:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=IgAtpP4C42Jpn6aKz2gV4v3gKQwjgJ+HgC0dgeMRD1c=; b=uajCC0Ebo8Blxm2wh0QYcJBamX4RuhCCoVg3VCJfHbv6I7qBmqI+JXSonkCbtmV3Kl PZq3/Z1FpmhMWvAGIYOpsNrPsWhyGamfFOLWi8cP/HKGpo/ffQu5mgvFlUAMLpzSA2GB OSPsdWHL8ki9fzR2vya7EkNFMJMKVLyI5y6nVeHgFiO2Vwr6m6z2Wpr5SVt3Suw/aYdb 8IJz6KE5W4l+Ie7IjE2F4N1epS9YGpMSq0itwOcpSbAHlBZCzGNf8nplG8XR8joHkm7k FoI8ELJ/mb2YSsRNmqG6FkBG5IvtGSPmKN8b2OGHQJnTvuIfliE4ZbC5QxG5hhEoJpsz Lv0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=IgAtpP4C42Jpn6aKz2gV4v3gKQwjgJ+HgC0dgeMRD1c=; b=Qv8d2iZLUAw9Iqja9dWUrl8ttD8s/+Zw+c9PWQwngi5zBTrTHZjSOFZijQ/5faDeeI 9qqUX2Dv65sk69AtZ9grEZD/0wOlkPHAe5ORRb6rOXxdR2FL7rFvG2ldJ2FSw6V8Z+cM Q+gLSpM/OVJefUHFczXuTwevjCaCaXGY32vstXkMOvUeLeowj+eLi7DQ3gC1CWis1pE/ qb0jd4MTajinQVI/HO66sJOECtrQXiIKXWW7d8ylWo0g/qZxg4rVY+ZkOErNsblwSBhn cPhr9r4qeFfs3UR0gKHKGRjneCPHBy3nioyGcLGUkjqMhiUM9gb3TrFKnXNMtQCHebqV 3rBQ== X-Gm-Message-State: AOAM530Tp23JE0TCGa44DIhADdJbZdqAfEgMswjZ+nfiQhK5Cgoi6ySS I9Q5hewpBRzsD+FJsTdDxvNGYA== X-Google-Smtp-Source: ABdhPJxbQWH0NruvXyA4qYlWgdE4BXN8N0wrN1exubtTlt6z0Q3rO9xWKVEb/vBUmkb+GYTX9W2Q5w== X-Received: by 2002:a5d:6d85:: with SMTP id l5mr71256571wrs.22.1621241211237; Mon, 17 May 2021 01:46:51 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id r5sm15847622wmh.23.2021.05.17.01.46.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 May 2021 01:46:50 -0700 (PDT) Subject: Re: [PATCH 5.10 160/530] arm64: dts: qcom: db845c: fix correct powerdown pin for WSA881x To: Pavel Machek , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bjorn Andersson , Sasha Levin , bgolaszewski@baylibre.com, linus.walleij@linaro.org References: <20210512144819.664462530@linuxfoundation.org> <20210512144825.099918971@linuxfoundation.org> <20210515081814.GA30461@amd> From: Srinivas Kandagatla Message-ID: <55d58470-f606-8c75-1f00-a2eb09314081@linaro.org> Date: Mon, 17 May 2021 09:46:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20210515081814.GA30461@amd> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org + Adding Linus W and Bartosz to CC. On 15/05/2021 09:18, Pavel Machek wrote: > Hi! > >> From: Srinivas Kandagatla >> >> [ Upstream commit c561740e7cfefaf3003a256f3a0cd9f8a069137c ] >> >> WSA881x powerdown pin is connected to GPIO1 not gpio2, so correct this. >> This was working so far due to a shift bug in gpio driver, however >> once that is fixed this will stop working, so fix this! > > I don't see the correspoing update to the driver this talks about. > > Do we have corresponding driver in 5.10 and was it fixed to match? This corresponding gpio driver patch was submitted along with the original fix, however it looks like it was not picked up yet. https://www.spinics.net/lists/linux-gpio/msg59264.html Bartosz/Linus W, Do you want me to resend this? --srini > > Best regards, > Pavel > >> +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts >> @@ -1015,7 +1015,7 @@ >> left_spkr: wsa8810-left{ >> compatible = "sdw10217201000"; >> reg = <0 1>; >> - powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>; >> + powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>; >> #thermal-sensor-cells = <0>; >> sound-name-prefix = "SpkrLeft"; >> #sound-dai-cells = <0>; >> @@ -1023,7 +1023,7 @@ >> >> right_spkr: wsa8810-right{ >> compatible = "sdw10217201000"; >> - powerdown-gpios = <&wcdgpio 2 GPIO_ACTIVE_HIGH>; >> + powerdown-gpios = <&wcdgpio 1 GPIO_ACTIVE_HIGH>; >> reg = <0 2>; >> #thermal-sensor-cells = <0>; >> sound-name-prefix = "SpkrRight"; >