From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751576AbdJRQnn (ORCPT ); Wed, 18 Oct 2017 12:43:43 -0400 Received: from mout.web.de ([212.227.17.12]:60135 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbdJRQnl (ORCPT ); Wed, 18 Oct 2017 12:43:41 -0400 Subject: Re: char/tpm: Improve a size determination in nine functions To: Jarkko Sakkinen , linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Mimi Zohar , Julia Lawall , Alexander Steffen , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , =?UTF-8?Q?Peter_H=c3=bcwe?= , Stefan Berger References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <83a166af-aecc-649d-dfe3-a72245345209@users.sourceforge.net> <1508238182.16112.475.camel@linux.intel.com> <1508244757.4234.60.camel@linux.vnet.ibm.com> <1508253453.4234.81.camel@linux.vnet.ibm.com> <9689f036-ba9f-d23b-cf89-c289bc308771@users.sourceforge.net> <20171018145735.lpzwakatsty7emlw@linux.intel.com> <351cf78a-14f6-c6e7-2902-048e7dc57a14@users.sourceforge.net> <20171018155946.e7ga7jyex6eia252@linux.intel.com> From: SF Markus Elfring Message-ID: <55d76224-3019-6614-70ce-ba260bbcd54f@users.sourceforge.net> Date: Wed, 18 Oct 2017 18:43:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171018155946.e7ga7jyex6eia252@linux.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:3P2cwlZ1LOSbskIrxrQPYeSaK/VlHSWkrVHXo2Sjjw8QBjT3n49 L1epvXc5+xLowBIuu27MGAyAJKaxYyHIar8G6GAeUVYTG0FbcW285NJ4Rmgi54ObuS3RniI FgAUGzwRGdjTUMG97ZWLBV+ox8mH9b4/4SqYe2uh+/1yNtELHK2gLjqs6f5xuCS/VVWrbUQ GgSB1nws2WwwzshzI/Fcg== X-UI-Out-Filterresults: notjunk:1;V01:K0:QZW1VVhmZpc=:8ldWaBFTfZI/6uxUSWPVUi Ovwt0L780mw9Jh2lkTopuS2A5ZcEZnxFfhV6kaG3MlAoi9GI4p3L0+imjv76AH8acVO2rNYsM t3f6yVWItcQw18cjPvI9jr/o/7JOu61bv4emInubvJkABm0Lhu3N9aNHvyqmbuywMsxlE0mqo zBdYP/IOyruA6Z8EL2wOEhcpmARxoJSkRQEQ0boB2UV6gWQhmhV+hXDFr5lStx3YHNRfppFE2 JE+E3urXaWiBFdmfKBSNc2JrhoOtnmQ/eV58PCIjrZI00R9DOqsGnTve8//Ac7rUxR3PHN1kl EoBNpF2ElyTxzHpbKMlPzHkMKK2ND73Fxdt17ll12gL2dGyrfm29JaZZ5/1ZTU/LsO5vvQwpo EXSOGs9WRcdENU0Fi4QzNLOfjX3NYJVnlJoisOcWLywruMSIjlnHvyVM79WgjkgoUUBzR6JVY yNvn5LMKzuFubgSKK3owPfGL7P/PwdV8MwmHK0b5ZF99Rw+eelBBU4O9mFbyCH3gtb0Put5Rz cGJHVHIMeq7tHoaPb4Pi3h1TCwP154BiXg8Y7mAtlcQAYbDPvb4yCUJurO3fUJyDNxgbzUmQ+ U+fNhNi4RLeT/xsjJ2IfKvr8kHpkvj6xmv3E8I6yj9na6zqICjs1u9t+VTWk0n9UzTKnMW3vz jKC10yJZH1UA0WNFrnFfA6ixevJhsBo1pI0qEr820zOC9Jnitkc/Xo8A8ghxM2EBVLX/ofMu2 dzOWEJFUwJlzc5EXaKFDCMrxEEL1H06LwBP+38pnCqTArMgKZD7ONvSqWPeE/BT/iVFWmmaYc /IQMc+1+Xe4FGFtkxacFF7ipebwU/t1RftkFTlJiGKCZiuQ6TI= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Commit message should just describe in plain text what you are doing Did other contributors find the wording “Replace …” > and why. and “… a bit safer according to the Linux coding style convention.” sufficient often enough already? Which description would you find more appropriate for this change pattern? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Wed, 18 Oct 2017 16:43:10 +0000 Subject: Re: char/tpm: Improve a size determination in nine functions Message-Id: <55d76224-3019-6614-70ce-ba260bbcd54f@users.sourceforge.net> List-Id: References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <83a166af-aecc-649d-dfe3-a72245345209@users.sourceforge.net> <1508238182.16112.475.camel@linux.intel.com> <1508244757.4234.60.camel@linux.vnet.ibm.com> <1508253453.4234.81.camel@linux.vnet.ibm.com> <9689f036-ba9f-d23b-cf89-c289bc308771@users.sourceforge.net> <20171018145735.lpzwakatsty7emlw@linux.intel.com> <351cf78a-14f6-c6e7-2902-048e7dc57a14@users.sourceforge.net> <20171018155946.e7ga7jyex6eia252@linux.intel.com> In-Reply-To: <20171018155946.e7ga7jyex6eia252@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: Jarkko Sakkinen , linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Mimi Zohar , Julia Lawall , Alexander Steffen , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , =?UTF-8?Q?Peter_H=c3=bcwe?= , Stefan Berger > Commit message should just describe in plain text what you are doing Did other contributors find the wording “Replace …” > and why. and “… a bit safer according to the Linux coding style convention.” sufficient often enough already? Which description would you find more appropriate for this change pattern? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.web.de ([212.227.17.12]:60135 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750926AbdJRQnl (ORCPT ); Wed, 18 Oct 2017 12:43:41 -0400 Subject: Re: char/tpm: Improve a size determination in nine functions To: Jarkko Sakkinen , linux-integrity@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Cc: Mimi Zohar , Julia Lawall , Alexander Steffen , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Andy Shevchenko , Benjamin Herrenschmidt , Corentin Labbe , Jason Gunthorpe , Jerry Snitselaar , Kenneth Goldman , Michael Ellerman , Nayna Jain , Paul Mackerras , =?UTF-8?Q?Peter_H=c3=bcwe?= , Stefan Berger References: <1d3516a2-a8e6-9e95-d438-f115fac84c7f@users.sourceforge.net> <83a166af-aecc-649d-dfe3-a72245345209@users.sourceforge.net> <1508238182.16112.475.camel@linux.intel.com> <1508244757.4234.60.camel@linux.vnet.ibm.com> <1508253453.4234.81.camel@linux.vnet.ibm.com> <9689f036-ba9f-d23b-cf89-c289bc308771@users.sourceforge.net> <20171018145735.lpzwakatsty7emlw@linux.intel.com> <351cf78a-14f6-c6e7-2902-048e7dc57a14@users.sourceforge.net> <20171018155946.e7ga7jyex6eia252@linux.intel.com> From: SF Markus Elfring Message-ID: <55d76224-3019-6614-70ce-ba260bbcd54f@users.sourceforge.net> Date: Wed, 18 Oct 2017 18:43:10 +0200 MIME-Version: 1.0 In-Reply-To: <20171018155946.e7ga7jyex6eia252@linux.intel.com> Content-Type: text/plain; charset=utf-8 Sender: linux-integrity-owner@vger.kernel.org List-ID: > Commit message should just describe in plain text what you are doing Did other contributors find the wording "Replace ..." > and why. and "... a bit safer according to the Linux coding style convention." sufficient often enough already? Which description would you find more appropriate for this change pattern? Regards, Markus