* [PATCH] EFI: don't mistakenly delete a file we never installed
@ 2022-04-25 10:47 Jan Beulich
2022-04-26 12:10 ` Bertrand Marquis
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2022-04-25 10:47 UTC (permalink / raw)
To: xen-devel
Cc: Andrew Cooper, George Dunlap, Julien Grall, Stefano Stabellini, Wei Liu
Just like for "install", make dealing with xen.efi on the EFI partition
dependent upon mount point and vendor directory being known.
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -515,7 +515,9 @@ _uninstall:
rm -f $(D)$(DEBUG_DIR)/$(T)-$(XEN_FULLVERSION).efi.map
rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).efi
rm -f $(D)$(EFI_DIR)/$(T).efi
- rm -f $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi
+ if [ -n '$(EFI_MOUNTPOINT)' -a -n '$(EFI_VENDOR)' ]; then \
+ rm -f $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi; \
+ fi
.PHONY: _debug
_debug:
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] EFI: don't mistakenly delete a file we never installed
2022-04-25 10:47 [PATCH] EFI: don't mistakenly delete a file we never installed Jan Beulich
@ 2022-04-26 12:10 ` Bertrand Marquis
0 siblings, 0 replies; 2+ messages in thread
From: Bertrand Marquis @ 2022-04-26 12:10 UTC (permalink / raw)
To: Jan Beulich
Cc: xen-devel, Andrew Cooper, George Dunlap, Julien Grall,
Stefano Stabellini, Wei Liu
Hi Jan,
> On 25 Apr 2022, at 11:47, Jan Beulich <jbeulich@suse.com> wrote:
>
> Just like for "install", make dealing with xen.efi on the EFI partition
> dependent upon mount point and vendor directory being known.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Bertrand Marquis <bertrand.marquis@arm.com>
Cheers
Bertrand
>
> --- a/xen/Makefile
> +++ b/xen/Makefile
> @@ -515,7 +515,9 @@ _uninstall:
> rm -f $(D)$(DEBUG_DIR)/$(T)-$(XEN_FULLVERSION).efi.map
> rm -f $(D)$(EFI_DIR)/$(T)-$(XEN_VERSION).efi
> rm -f $(D)$(EFI_DIR)/$(T).efi
> - rm -f $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi
> + if [ -n '$(EFI_MOUNTPOINT)' -a -n '$(EFI_VENDOR)' ]; then \
> + rm -f $(D)$(EFI_MOUNTPOINT)/efi/$(EFI_VENDOR)/$(T)-$(XEN_FULLVERSION).efi; \
> + fi
>
> .PHONY: _debug
> _debug:
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-26 12:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-25 10:47 [PATCH] EFI: don't mistakenly delete a file we never installed Jan Beulich
2022-04-26 12:10 ` Bertrand Marquis
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.