From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH] ARM: dts: at91: replace gpio-key,wakeup with wakeup-source for sam9260ek Date: Mon, 14 Nov 2016 16:45:51 +0100 Message-ID: <55e95acc-d30f-432e-90d6-f96bad69ac3d@atmel.com> References: <1479138250-17780-2-git-send-email-sudeep.holla@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <1479138250-17780-2-git-send-email-sudeep.holla-5wv7dgnIgG8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sudeep Holla , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Alexandre Belloni , Jean-Christophe Plagniol-Villard List-Id: devicetree@vger.kernel.org Le 14/11/2016 à 16:44, Sudeep Holla a écrit : > Though the keyboard driver for GPIO buttons(gpio-keys) will continue to > check for/support the legacy "gpio-key,wakeup" boolean property to > enable gpio buttons as wakeup source, "wakeup-source" is the new > standard binding. > > This patch replaces the legacy "gpio-key,wakeup" with the unified > "wakeup-source" property in order to avoid any further copy-paste > duplication. > > Cc: Nicolas Ferre Acked-by: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Jean-Christophe Plagniol-Villard > Signed-off-by: Sudeep Holla > --- > arch/arm/boot/dts/at91sam9260ek.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Hi, > > Inspite of getting rid of most of the legacy property almost a year ago, > addition of new platforms have brought this back and over time it's > now found again in few places. Just get rid of them *again* > > Regards, > Sudeep Sorry for this Sudeep and thanks for the patch. Best regards, > diff --git a/arch/arm/boot/dts/at91sam9260ek.dts b/arch/arm/boot/dts/at91sam9260ek.dts > index 2c87f58448e7..b2578feceb08 100644 > --- a/arch/arm/boot/dts/at91sam9260ek.dts > +++ b/arch/arm/boot/dts/at91sam9260ek.dts > @@ -174,14 +174,14 @@ > label = "Button 3"; > gpios = <&pioA 30 GPIO_ACTIVE_LOW>; > linux,code = <0x103>; > - gpio-key,wakeup; > + wakeup-source; > }; > > btn4 { > label = "Button 4"; > gpios = <&pioA 31 GPIO_ACTIVE_LOW>; > linux,code = <0x104>; > - gpio-key,wakeup; > + wakeup-source; > }; > }; > > -- > 2.7.4 > > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Mon, 14 Nov 2016 16:45:51 +0100 Subject: [PATCH] ARM: dts: at91: replace gpio-key,wakeup with wakeup-source for sam9260ek In-Reply-To: <1479138250-17780-2-git-send-email-sudeep.holla@arm.com> References: <1479138250-17780-2-git-send-email-sudeep.holla@arm.com> Message-ID: <55e95acc-d30f-432e-90d6-f96bad69ac3d@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 14/11/2016 ? 16:44, Sudeep Holla a ?crit : > Though the keyboard driver for GPIO buttons(gpio-keys) will continue to > check for/support the legacy "gpio-key,wakeup" boolean property to > enable gpio buttons as wakeup source, "wakeup-source" is the new > standard binding. > > This patch replaces the legacy "gpio-key,wakeup" with the unified > "wakeup-source" property in order to avoid any further copy-paste > duplication. > > Cc: Nicolas Ferre Acked-by: Nicolas Ferre > Cc: Alexandre Belloni > Cc: Jean-Christophe Plagniol-Villard > Signed-off-by: Sudeep Holla > --- > arch/arm/boot/dts/at91sam9260ek.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > Hi, > > Inspite of getting rid of most of the legacy property almost a year ago, > addition of new platforms have brought this back and over time it's > now found again in few places. Just get rid of them *again* > > Regards, > Sudeep Sorry for this Sudeep and thanks for the patch. Best regards, > diff --git a/arch/arm/boot/dts/at91sam9260ek.dts b/arch/arm/boot/dts/at91sam9260ek.dts > index 2c87f58448e7..b2578feceb08 100644 > --- a/arch/arm/boot/dts/at91sam9260ek.dts > +++ b/arch/arm/boot/dts/at91sam9260ek.dts > @@ -174,14 +174,14 @@ > label = "Button 3"; > gpios = <&pioA 30 GPIO_ACTIVE_LOW>; > linux,code = <0x103>; > - gpio-key,wakeup; > + wakeup-source; > }; > > btn4 { > label = "Button 4"; > gpios = <&pioA 31 GPIO_ACTIVE_LOW>; > linux,code = <0x104>; > - gpio-key,wakeup; > + wakeup-source; > }; > }; > > -- > 2.7.4 > > -- Nicolas Ferre