From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751115AbdAQRyI (ORCPT ); Tue, 17 Jan 2017 12:54:08 -0500 Received: from nm6-vm2.bullet.mail.ne1.yahoo.com ([98.138.90.154]:37119 "EHLO nm6-vm2.bullet.mail.ne1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750933AbdAQRyG (ORCPT ); Tue, 17 Jan 2017 12:54:06 -0500 X-Yahoo-Newman-Id: 930230.50796.bm@smtp109.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: c79FDhYVM1lhq.QKlWzdWj0tOdbaQrJXy6OtYr4ym2JW4p5 E80wTGYl79UjsrhrjG.kNR4rjBIFQLTMmFZFDmzkb3qigrvQtoNb6GCXuzsC S3CYEcIqP6youk6HCQFstXYEgL71qNImii2f26PaPLuaOeFUfkbXA9.ac8By 1Cwp2aLqMGZYPzrNrEwj61UHurc2rWjomEant6wmPbIqyby4rE9sa5AdvwLd _j6YtoMPTzkUXJGVKcxINMR7ygzWMRFKt2dJbghFsojg7q3zFqWgCO82iFQo lL9wuyi0LwQgcrFrd4mClYKPOxMzsjjcTMlLOhtNTCvj8SPNWhhWzjGQPl21 LUzcr_JkN35C_eVvI9TH3xcjFhTAkv84cJq3EPzLrrJpeUT3ESmfsb9UkeX9 eD8TvpzyZbgIEOsP9dIaaY91eieIxHKco_8M5D9gGZIGeOg41CQcCoGIi2F5 fHQ3.y.xqL1HIbhyqAaE2_XkbamXBZ1O9xE0PVUlB7tavBBA.xhFNXYadSQa sXoBS1zMWVtws.Ti6wRyFw.ePR9UfEeL2YMg0.46Z2r3bcI5l4Y2U4QY- X-Yahoo-SMTP: OIJXglSswBDfgLtXluJ6wiAYv6_cnw-- Subject: Re: [PATCH 15/46] selinux: One check and function call less in genfs_read() after error detection To: SF Markus Elfring , linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov References: <60ed4f02-4ff8-2ef2-bcc3-ae62bc61cda9@users.sourceforge.net> Cc: Eric Paris , James Morris , Paul Moore , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org From: Casey Schaufler Message-ID: <55f62ee9-9e98-f5e0-67eb-fc7aa5cbe8f8@schaufler-ca.com> Date: Tue, 17 Jan 2017 09:53:27 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <60ed4f02-4ff8-2ef2-bcc3-ae62bc61cda9@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/17/2017 8:37 AM, SF Markus Elfring wrote: >>> @@ -2015,7 +2015,7 @@ static int genfs_read(struct policydb *p, void *fp) >>> newgenfs = kzalloc(sizeof(*newgenfs), GFP_KERNEL); >>> if (!newgenfs) { >>> rc = -ENOMEM; >>> - goto out; >>> + goto exit; >>> } >>> >>> rc = str_read(&newgenfs->fstype, GFP_KERNEL, fp, len); >>> @@ -2101,7 +2101,7 @@ static int genfs_read(struct policydb *p, void *fp) >>> kfree(newgenfs); >>> } >>> ocontext_destroy(newc, OCON_FSUSE); >>> - >>> +exit: >>> return rc; >> Why not replace the "goto out" with "return rc" rather >> than add a target? > Would you accept to use the statement "return -ENOMEM;" there instead? That would be even better. > > Regards, > Markus > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Casey Schaufler Date: Tue, 17 Jan 2017 17:53:27 +0000 Subject: Re: [PATCH 15/46] selinux: One check and function call less in genfs_read() after error detection Message-Id: <55f62ee9-9e98-f5e0-67eb-fc7aa5cbe8f8@schaufler-ca.com> List-Id: References: <60ed4f02-4ff8-2ef2-bcc3-ae62bc61cda9@users.sourceforge.net> In-Reply-To: <60ed4f02-4ff8-2ef2-bcc3-ae62bc61cda9@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: SF Markus Elfring , linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov Cc: Eric Paris , James Morris , Paul Moore , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org On 1/17/2017 8:37 AM, SF Markus Elfring wrote: >>> @@ -2015,7 +2015,7 @@ static int genfs_read(struct policydb *p, void *fp) >>> newgenfs = kzalloc(sizeof(*newgenfs), GFP_KERNEL); >>> if (!newgenfs) { >>> rc = -ENOMEM; >>> - goto out; >>> + goto exit; >>> } >>> >>> rc = str_read(&newgenfs->fstype, GFP_KERNEL, fp, len); >>> @@ -2101,7 +2101,7 @@ static int genfs_read(struct policydb *p, void *fp) >>> kfree(newgenfs); >>> } >>> ocontext_destroy(newc, OCON_FSUSE); >>> - >>> +exit: >>> return rc; >> Why not replace the "goto out" with "return rc" rather >> than add a target? > Would you accept to use the statement "return -ENOMEM;" there instead? That would be even better. > > Regards, > Markus >