From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 980FEC4707F for ; Thu, 27 May 2021 11:16:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BEEC601FA for ; Thu, 27 May 2021 11:16:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BEEC601FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE2EF6EE8C; Thu, 27 May 2021 11:16:20 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C27C6EE7E; Thu, 27 May 2021 11:16:19 +0000 (UTC) IronPort-SDR: 23YBh+YSdMY6ES8mP5FOyZAE2qowXS2Ftz+mF4xk1t3rlqUIJ8pVjuSn2LzpvhDoekBQG8my+A VD5gzDyjZDBg== X-IronPort-AV: E=McAfee;i="6200,9189,9996"; a="183043840" X-IronPort-AV: E=Sophos;i="5.82,334,1613462400"; d="scan'208";a="183043840" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 04:16:19 -0700 IronPort-SDR: JXKNcgLd2D7JcHiYEpSi4GmeQktlDsODPL9sQXU/Abvda2SID17EBc+NlLq3nNPsiNwH9A045k 5hGpwAXvwkkA== X-IronPort-AV: E=Sophos;i="5.82,334,1613462400"; d="scan'208";a="477443491" Received: from vsorokin-mobl.ccr.corp.intel.com (HELO [10.249.39.216]) ([10.249.39.216]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 04:16:15 -0700 Subject: Re: [PATCH] drm/i915: Disable gpu relocations To: Daniel Vetter , Intel Graphics Development References: <20210526163730.3423181-1-daniel.vetter@ffwll.ch> From: Maarten Lankhorst Message-ID: <55fb9d6c-23aa-bdce-250f-7f0377441a53@linux.intel.com> Date: Thu, 27 May 2021 13:16:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210526163730.3423181-1-daniel.vetter@ffwll.ch> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , DRI Development , Chris Wilson , Jon Bloomfield , Matthew Auld , Jason Ekstrand , Dave Airlie , Daniel Vetter Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Op 2021-05-26 om 18:37 schreef Daniel Vetter: > Media userspace was the last userspace to still use them, and they > converted now too: > > https://github.com/intel/media-driver/commit/144020c37770083974bedf59902b70b8f444c799 > > This means no reason anymore to make relocations faster than they've > been for the first 9 years of gem. This code was added in > > commit 7dd4f6729f9243bd7046c6f04c107a456bda38eb > Author: Chris Wilson > Date: Fri Jun 16 15:05:24 2017 +0100 > > drm/i915: Async GPU relocation processing > > Furthermore there's pretty strong indications it's buggy, since the > code to use it by default as the only option had to be reverted: > > commit ad5d95e4d538737ed3fa25493777decf264a3011 > Author: Dave Airlie > Date: Tue Sep 8 15:41:17 2020 +1000 > > Revert "drm/i915/gem: Async GPU relocations only" > > This code just disables gpu relocations, leaving the garbage > collection for later patches and more importantly, much less confusing > diff. Also given how much headaches this code has caused in the past, > letting this soak for a bit seems justified. > > Cc: Jon Bloomfield > Signed-off-by: Daniel Vetter > Cc: Chris Wilson > Cc: Maarten Lankhorst > Cc: Joonas Lahtinen > Cc: Daniel Vetter > Cc: "Thomas Hellström" > Cc: Matthew Auld > Cc: Lionel Landwerlin > Cc: Dave Airlie > Cc: Jason Ekstrand > --- > .../gpu/drm/i915/gem/i915_gem_execbuffer.c | 43 ++++++++----------- > 1 file changed, 18 insertions(+), 25 deletions(-) Reviewed-by: Maarten Lankhorst Note that a lot of complexity may be removed with gpu relocations gone. Some igt tests might also start to fail, as they expect relocations to complete asynchronously. Is it kept in case we need to revive it? ~Maarten From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 080CCC4707F for ; Thu, 27 May 2021 11:16:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAA8E601FA for ; Thu, 27 May 2021 11:16:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CAA8E601FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A4CE96EE96; Thu, 27 May 2021 11:16:21 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2C27C6EE7E; Thu, 27 May 2021 11:16:19 +0000 (UTC) IronPort-SDR: 23YBh+YSdMY6ES8mP5FOyZAE2qowXS2Ftz+mF4xk1t3rlqUIJ8pVjuSn2LzpvhDoekBQG8my+A VD5gzDyjZDBg== X-IronPort-AV: E=McAfee;i="6200,9189,9996"; a="183043840" X-IronPort-AV: E=Sophos;i="5.82,334,1613462400"; d="scan'208";a="183043840" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 04:16:19 -0700 IronPort-SDR: JXKNcgLd2D7JcHiYEpSi4GmeQktlDsODPL9sQXU/Abvda2SID17EBc+NlLq3nNPsiNwH9A045k 5hGpwAXvwkkA== X-IronPort-AV: E=Sophos;i="5.82,334,1613462400"; d="scan'208";a="477443491" Received: from vsorokin-mobl.ccr.corp.intel.com (HELO [10.249.39.216]) ([10.249.39.216]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 May 2021 04:16:15 -0700 To: Daniel Vetter , Intel Graphics Development References: <20210526163730.3423181-1-daniel.vetter@ffwll.ch> From: Maarten Lankhorst Message-ID: <55fb9d6c-23aa-bdce-250f-7f0377441a53@linux.intel.com> Date: Thu, 27 May 2021 13:16:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210526163730.3423181-1-daniel.vetter@ffwll.ch> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH] drm/i915: Disable gpu relocations X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= , DRI Development , Chris Wilson , Matthew Auld , Dave Airlie , Daniel Vetter Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T3AgMjAyMS0wNS0yNiBvbSAxODozNyBzY2hyZWVmIERhbmllbCBWZXR0ZXI6Cj4gTWVkaWEgdXNl cnNwYWNlIHdhcyB0aGUgbGFzdCB1c2Vyc3BhY2UgdG8gc3RpbGwgdXNlIHRoZW0sIGFuZCB0aGV5 Cj4gY29udmVydGVkIG5vdyB0b286Cj4KPiBodHRwczovL2dpdGh1Yi5jb20vaW50ZWwvbWVkaWEt ZHJpdmVyL2NvbW1pdC8xNDQwMjBjMzc3NzAwODM5NzRiZWRmNTk5MDJiNzBiOGY0NDRjNzk5Cj4K PiBUaGlzIG1lYW5zIG5vIHJlYXNvbiBhbnltb3JlIHRvIG1ha2UgcmVsb2NhdGlvbnMgZmFzdGVy IHRoYW4gdGhleSd2ZQo+IGJlZW4gZm9yIHRoZSBmaXJzdCA5IHllYXJzIG9mIGdlbS4gVGhpcyBj b2RlIHdhcyBhZGRlZCBpbgo+Cj4gY29tbWl0IDdkZDRmNjcyOWY5MjQzYmQ3MDQ2YzZmMDRjMTA3 YTQ1NmJkYTM4ZWIKPiBBdXRob3I6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNv LnVrPgo+IERhdGU6ICAgRnJpIEp1biAxNiAxNTowNToyNCAyMDE3ICswMTAwCj4KPiAgICAgZHJt L2k5MTU6IEFzeW5jIEdQVSByZWxvY2F0aW9uIHByb2Nlc3NpbmcKPgo+IEZ1cnRoZXJtb3JlIHRo ZXJlJ3MgcHJldHR5IHN0cm9uZyBpbmRpY2F0aW9ucyBpdCdzIGJ1Z2d5LCBzaW5jZSB0aGUKPiBj b2RlIHRvIHVzZSBpdCBieSBkZWZhdWx0IGFzIHRoZSBvbmx5IG9wdGlvbiBoYWQgdG8gYmUgcmV2 ZXJ0ZWQ6Cj4KPiBjb21taXQgYWQ1ZDk1ZTRkNTM4NzM3ZWQzZmEyNTQ5Mzc3N2RlY2YyNjRhMzAx MQo+IEF1dGhvcjogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAcmVkaGF0LmNvbT4KPiBEYXRlOiAgIFR1 ZSBTZXAgOCAxNTo0MToxNyAyMDIwICsxMDAwCj4KPiAgICAgUmV2ZXJ0ICJkcm0vaTkxNS9nZW06 IEFzeW5jIEdQVSByZWxvY2F0aW9ucyBvbmx5Igo+Cj4gVGhpcyBjb2RlIGp1c3QgZGlzYWJsZXMg Z3B1IHJlbG9jYXRpb25zLCBsZWF2aW5nIHRoZSBnYXJiYWdlCj4gY29sbGVjdGlvbiBmb3IgbGF0 ZXIgcGF0Y2hlcyBhbmQgbW9yZSBpbXBvcnRhbnRseSwgbXVjaCBsZXNzIGNvbmZ1c2luZwo+IGRp ZmYuIEFsc28gZ2l2ZW4gaG93IG11Y2ggaGVhZGFjaGVzIHRoaXMgY29kZSBoYXMgY2F1c2VkIGlu IHRoZSBwYXN0LAo+IGxldHRpbmcgdGhpcyBzb2FrIGZvciBhIGJpdCBzZWVtcyBqdXN0aWZpZWQu Cj4KPiBDYzogSm9uIEJsb29tZmllbGQgPGpvbi5ibG9vbWZpZWxkQGludGVsLmNvbT4KPiBTaWdu ZWQtb2ZmLWJ5OiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiBDYzog Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IE1hYXJ0ZW4gTGFu a2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IEpvb25hcyBM YWh0aW5lbiA8am9vbmFzLmxhaHRpbmVuQGxpbnV4LmludGVsLmNvbT4KPiBDYzogRGFuaWVsIFZl dHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBDYzogIlRob21hcyBIZWxsc3Ryw7ZtIiA8 dGhvbWFzLmhlbGxzdHJvbUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IE1hdHRoZXcgQXVsZCA8bWF0 dGhldy5hdWxkQGludGVsLmNvbT4KPiBDYzogTGlvbmVsIExhbmR3ZXJsaW4gPGxpb25lbC5nLmxh bmR3ZXJsaW5AaW50ZWwuY29tPgo+IENjOiBEYXZlIEFpcmxpZSA8YWlybGllZEByZWRoYXQuY29t Pgo+IENjOiBKYXNvbiBFa3N0cmFuZCA8amFzb25Aamxla3N0cmFuZC5uZXQ+Cj4gLS0tCj4gIC4u Li9ncHUvZHJtL2k5MTUvZ2VtL2k5MTVfZ2VtX2V4ZWNidWZmZXIuYyAgICB8IDQzICsrKysrKysr LS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDE4IGluc2VydGlvbnMoKyksIDI1IGRlbGV0 aW9ucygtKQoKUmV2aWV3ZWQtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3Jz dEBsaW51eC5pbnRlbC5jb20+CgpOb3RlIHRoYXQgYSBsb3Qgb2YgY29tcGxleGl0eSBtYXkgYmUg cmVtb3ZlZCB3aXRoIGdwdSByZWxvY2F0aW9ucyBnb25lLiBTb21lIGlndCB0ZXN0cyBtaWdodCBh bHNvIHN0YXJ0IHRvIGZhaWwsIGFzIHRoZXkgZXhwZWN0IHJlbG9jYXRpb25zIHRvIGNvbXBsZXRl IGFzeW5jaHJvbm91c2x5LgoKSXMgaXQga2VwdCBpbiBjYXNlIHdlIG5lZWQgdG8gcmV2aXZlIGl0 PwoKfk1hYXJ0ZW4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cg==