From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH 0/7] Add hierarchical support to make install
Date: Tue, 22 Sep 2015 10:00:17 +0200
Message-ID: <56010A91.5020607@6wind.com>
References: <1442608390-12537-1-git-send-email-mario.alfredo.c.arevalo@intel.com>
 <5600F549.20000@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
To: Panu Matilainen <pmatilai@redhat.com>,
 Mario Carrillo <mario.alfredo.c.arevalo@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67])
 by dpdk.org (Postfix) with ESMTP id 25BB0234
 for <dev@dpdk.org>; Tue, 22 Sep 2015 10:00:29 +0200 (CEST)
In-Reply-To: <5600F549.20000@redhat.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

On 09/22/2015 08:29 AM, Panu Matilainen wrote:
> On 09/18/2015 11:33 PM, Mario Carrillo wrote:
>> DPDK package lacks of a mechanism to install libraries, headers
>> applications and kernel modules to a file system tree.
>>
>> This patch set allows to install files according to the next
>> proposal:
>> http://www.freedesktop.org/software/systemd/man/file-hierarchy.html
>>
>> By adding a parameter H=1 (hierarchy-file) to makefile system, it is
>> possible to do the next steps
>>
>> make config T=TARGET
>> make
>> make install H=1
>>
>> and files will be installed on the proper directory. Also you can use
>> the DESTDIR variable.
> 
> Thanks for working on this!
> 
> My 5c is that I'd rather see "make install" do the right thing (as in,
> behave like a normal OSS project) by default instead of requiring some
> obscure additional parameter (which almost nobody will then find) to
> activate it.

Actually, the current "install" directive means: install all stuff
required to build a project for the specified targets (example:
x86_64-native-linuxapp-gcc).

If we just do "make install T=${target}", the target is installed
into the current SDK source. Adding DESTDIR will install the binary
DPDK in a new directory. Example:

 make -j32 T="*-native-linuxapp-gcc" DESTDIR=/tmp/binary-dpdk install

In both cases, the result can be used to build an application (like
the one found in examples) using the the DPDK framework. So, the current
"install" directive should be understood as "install binary sdk".

>>From what I understand, what Mario wants to add is a "install runtime
libraries" directive.

I agree that using H=1 is maybe not the clearest solution. What about
renaming the "install" directive to:
  - install-sdk
  - install-runtime

It would help to keep the current behavior of "install" for some time,
marking it as deprecated.

Regards,
Olivier