From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755395AbbIWPdF (ORCPT ); Wed, 23 Sep 2015 11:33:05 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:41168 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753832AbbIWPdD (ORCPT ); Wed, 23 Sep 2015 11:33:03 -0400 Subject: Re: [PATCH 08/17] hwmon: abx500: drop the use of IRQF_NO_SUSPEND To: Sudeep Holla , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1442850433-5903-1-git-send-email-sudeep.holla@arm.com> <1442850433-5903-9-git-send-email-sudeep.holla@arm.com> Cc: Thomas Gleixner , "Rafael J. Wysocki" , Jean Delvare , lm-sensors@lm-sensors.org From: Guenter Roeck Message-ID: <5602C629.3080109@roeck-us.net> Date: Wed, 23 Sep 2015 08:32:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <1442850433-5903-9-git-send-email-sudeep.holla@arm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/21/2015 08:47 AM, Sudeep Holla wrote: > The description in the driver states: "ABX500 does not provide auto ADC, > so to monitor the required temperatures, a periodic work is used. It is > more important to not wake up the CPU... If the chip gets too hot during > a sleep state it's most likely due to external factors, such as the > surrounding temperature and nothing can be done in S/W." > > So it makes no sense to keep IRQs enabled as it need not be wakeup > source. This patch removes the use of IRQF_NO_SUSPEND flag > > Cc: Jean Delvare > Cc: Guenter Roeck > Cc: lm-sensors@lm-sensors.org > Signed-off-by: Sudeep Holla Applied to hwmon-next. Thanks, Guenter > --- > drivers/hwmon/abx500.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/abx500.c b/drivers/hwmon/abx500.c > index 6cb89c0ebab6..dcab258f60c1 100644 > --- a/drivers/hwmon/abx500.c > +++ b/drivers/hwmon/abx500.c > @@ -377,7 +377,7 @@ static int setup_irqs(struct platform_device *pdev) > } > > ret = devm_request_threaded_irq(&pdev->dev, irq, NULL, > - abx500_temp_irq_handler, IRQF_NO_SUSPEND, "abx500-temp", pdev); > + abx500_temp_irq_handler, 0, "abx500-temp", pdev); > if (ret < 0) > dev_err(&pdev->dev, "Request threaded irq failed (%d)\n", ret); > >