From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751688AbdGYWpR convert rfc822-to-8bit (ORCPT ); Tue, 25 Jul 2017 18:45:17 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:8739 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751620AbdGYWpQ (ORCPT ); Tue, 25 Jul 2017 18:45:16 -0400 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 25 Jul 2017 15:45:14 -0700 Subject: Re: [HMM 12/15] mm/migrate: new memory migration helper for use with device memory v4 To: Jerome Glisse CC: "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , John Hubbard , David Nellans , Mark Hairgrove , Sherry Cheung , Subhash Gutti References: <20170701005749.GA7232@redhat.com> <20170711182922.GC5347@redhat.com> <7a4478cb-7eb6-2546-e707-1b0f18e3acd4@nvidia.com> <20170711184919.GD5347@redhat.com> <84d83148-41a3-d0e8-be80-56187a8e8ccc@nvidia.com> <20170713201620.GB1979@redhat.com> <20170715005554.GA12694@redhat.com> <20170721013303.GA25991@redhat.com> From: Evgeny Baskakov Message-ID: <5602b0e5-0051-f726-420e-7013446d3f42@nvidia.com> Date: Tue, 25 Jul 2017 15:45:14 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170721013303.GA25991@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8BIT Content-Language: en-US X-Originating-IP: [172.17.163.47] X-ClientProxiedBy: HQMAIL102.nvidia.com (172.18.146.10) To HQMAIL103.nvidia.com (172.20.187.11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/20/17 6:33 PM, Jerome Glisse wrote: > So i pushed an updated hmm-next branch it should have all fixes so far, including > something that should fix this issue. I still want to go over all emails again > to make sure i am not forgetting anything. > > Cheers, > Jérôme Hi Jerome, Thanks for updating the documentation for hmm_devmem_ops. I have an inquiry about the "fault" callback, though. The documentation says "Returns: 0 on success", but can the driver set any VM_FAULT_* flags? For instance, the driver might want to set the VM_FAULT_MAJOR flag to indicate that a heavy-weight page migration has happened on the page fault. If that is possible, can you please update the documentation and list the flags that are permitted in the callback's return value? Thanks! -- Evgeny Baskakov NVIDIA From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f71.google.com (mail-pg0-f71.google.com [74.125.83.71]) by kanga.kvack.org (Postfix) with ESMTP id 4C0B76B025F for ; Tue, 25 Jul 2017 18:45:17 -0400 (EDT) Received: by mail-pg0-f71.google.com with SMTP id 125so196998799pgi.2 for ; Tue, 25 Jul 2017 15:45:17 -0700 (PDT) Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com. [216.228.121.65]) by mx.google.com with ESMTPS id 1si8793337pgo.618.2017.07.25.15.45.15 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Jul 2017 15:45:16 -0700 (PDT) Subject: Re: [HMM 12/15] mm/migrate: new memory migration helper for use with device memory v4 References: <20170701005749.GA7232@redhat.com> <20170711182922.GC5347@redhat.com> <7a4478cb-7eb6-2546-e707-1b0f18e3acd4@nvidia.com> <20170711184919.GD5347@redhat.com> <84d83148-41a3-d0e8-be80-56187a8e8ccc@nvidia.com> <20170713201620.GB1979@redhat.com> <20170715005554.GA12694@redhat.com> <20170721013303.GA25991@redhat.com> From: Evgeny Baskakov Message-ID: <5602b0e5-0051-f726-420e-7013446d3f42@nvidia.com> Date: Tue, 25 Jul 2017 15:45:14 -0700 MIME-Version: 1.0 In-Reply-To: <20170721013303.GA25991@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US Sender: owner-linux-mm@kvack.org List-ID: To: Jerome Glisse Cc: "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , John Hubbard , David Nellans , Mark Hairgrove , Sherry Cheung , Subhash Gutti On 7/20/17 6:33 PM, Jerome Glisse wrote: > So i pushed an updated hmm-next branch it should have all fixes so far, i= ncluding > something that should fix this issue. I still want to go over all emails = again > to make sure i am not forgetting anything. > > Cheers, > J=C3=A9r=C3=B4me Hi Jerome, Thanks for updating the documentation for hmm_devmem_ops. I have an inquiry about the "fault" callback, though. The documentation=20 says "Returns: 0 on success", but can the driver set any VM_FAULT_*=20 flags? For instance, the driver might want to set the VM_FAULT_MAJOR=20 flag to indicate that a heavy-weight page migration has happened on the=20 page fault. If that is possible, can you please update the documentation and list=20 the flags that are permitted in the callback's return value? Thanks! --=20 Evgeny Baskakov NVIDIA -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org