From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDB37C4167B for ; Thu, 15 Dec 2022 00:52:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229722AbiLOAwI (ORCPT ); Wed, 14 Dec 2022 19:52:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229448AbiLOAwG (ORCPT ); Wed, 14 Dec 2022 19:52:06 -0500 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60B4A303FE for ; Wed, 14 Dec 2022 16:52:04 -0800 (PST) Received: by mail-lf1-x133.google.com with SMTP id x28so13267115lfn.6 for ; Wed, 14 Dec 2022 16:52:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=S6mAIVbE3TYfe/sfWszMjsZBqUjDt0fQZqgGBAUpy8I=; b=ByXnkyrSsttOE9yaSrHKJ9PTVsP8OSTXEDlhVcK0vltwTJpeofa/qPcGMhuYp9yqUX e7cgOS1KawYLWjYOEivEru4sKz9XjVOIwc6/cN5MseSeoqF1tM+t3cmKtXx8D7E5gSzP qh79npKk4m7i71hW8tTyrFNtVL0iY2Isz71f6eoK7UU1X0HjSaoLVmBZvottVJX8ztkj tCOpD9Dq5NQhTVZNJthrNy6xKzaF6vibEF34dWjpDrQciyvsCT+tpHS+oJhw/11LUoQL Fi8/Ve2xf2PvX100VbCj5bh5jKZ6febAW7ufjg+hENZG+h0lZXvALwuyI3BLHcRMm9fH Zbfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=S6mAIVbE3TYfe/sfWszMjsZBqUjDt0fQZqgGBAUpy8I=; b=aEaTgnXpdME9RGs5vHLElrt/8yFc4Foe9p0eOs3vYVz1m6aIw6C6mXQmg+WHIzUUGW C4wRpLpLlPLmNfs/kWazRvCoAcosONLWJsK2tIJ3wim9kviJkOOZjZNZJE6p9KcKupnZ PwEYjiEgZWpOeh05r9p10MKrb1OFYYftf/+u95K3ANBMVxR4z/pr9ev7OBrH8jC8MC7g A/zr3NWk1aGHYI3XIq9jQD1Wgzlx7I5cJQjopj7skHGf21kq3lgqkJJFvj6gELi2z91r 3VY2nn9ltolGqb+cGVrMK1HFszdcBiyHWjAjzEFIu2xccvcasheKRpjpjTq+5FQzaD85 3C0Q== X-Gm-Message-State: ANoB5plVob1Uo9nEHaaMWDYs44DsPurStILBWrFqna+cwEmh4QWwo5rV 1Ibb59zzpPBs4LopSumrP09JGQrbyOvx+5D+94k= X-Google-Smtp-Source: AA0mqf4t5Y8GMiTGp+fKIC782S6ls3TtAofUfVlKy6Q2R1OccaJr26S2ArFTXFMKWtDcenAd/6Nudg== X-Received: by 2002:a05:6512:159c:b0:4b4:f212:6173 with SMTP id bp28-20020a056512159c00b004b4f2126173mr7866197lfb.4.1671065522702; Wed, 14 Dec 2022 16:52:02 -0800 (PST) Received: from ?IPV6:2001:14ba:a085:4d00::8a5? (dzccz6yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a085:4d00::8a5]) by smtp.gmail.com with ESMTPSA id d3-20020ac24c83000000b004947984b385sm986881lfl.87.2022.12.14.16.52.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Dec 2022 16:52:02 -0800 (PST) Message-ID: <560508a2-9ff5-16b5-ac50-efe9a2afbddb@linaro.org> Date: Thu, 15 Dec 2022 02:52:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH 0/6] drm/msm: DSC Electric Boogaloo for sm8[12]50 To: Marijn Suijten , phone-devel@vger.kernel.org, Rob Clark , Abhinav Kumar , Vinod Koul , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Sean Paul , David Airlie , Daniel Vetter , Stephen Boyd , Bjorn Andersson , Jessica Zhang , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Kuogee Hsieh , Jani Nikula , sunliming , Sam Ravnborg , Haowen Bai , Konrad Dybcio , Loic Poulain , Vinod Polimera , Douglas Anderson , Vladimir Lypak , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20221213232207.113607-1-marijn.suijten@somainline.org> <154b2e08-25a0-c8b7-1dc8-2d41b8787f05@linaro.org> <20221214192322.vs4tvhlzjc265bva@SoMainline.org> Content-Language: en-GB From: Dmitry Baryshkov In-Reply-To: <20221214192322.vs4tvhlzjc265bva@SoMainline.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 14/12/2022 21:23, Marijn Suijten wrote: > On 2022-12-14 20:40:06, Dmitry Baryshkov wrote: >> On 14/12/2022 01:22, Marijn Suijten wrote: >>> This preliminary Display Stream Compression support package for >>> (initially tested on) sm8[12]50 is based on comparing DSC behaviour >>> between downstream and mainline. Some new callbacks are added (for >>> binding blocks on active CTLs), logic bugs are corrected, zeroed struct >>> members are now assigned proper values, and RM allocation and hw block >>> retrieval now hand out (or not) DSC blocks without causing null-pointer >>> dereferences. >>> >>> Unfortunately it is not yet enough to get rid of completely corrupted >>> display output on the boards I tested here: >>> - Sony Xperia 1 (sm8150), 1644x3840 or 1096x2560 pixels; >>> - Sony Xperia 5II (sm8250), 1080x2520, at 60 or 120Hz; >>> - (can include more Xperia boards if desired) >>> >>> Both devices use the DUALPIPE_DSCMERGE topology downstream: dual LM, PP >>> and DSC, but only a single INTF/encoder/DSI-link. >>> >>> Hopefully this spawns some community/upstream interest to help rootcause >>> our corruption issues (after we open a drm/msm report on GitLab for more >>> appropriate tracking). >>> >>> The Sony Xperia XZ3 (sdm845) was fully tested and validated with this >>> series to not cause any regressions (an one of the math fixes now allows >>> us to change slice_count in the panel driver, which would corrupt >>> previously). >>> >>> Marijn Suijten (6): >>> drm/msm/dpu1: Implement DSC binding to PP block for CTL V1 >>> drm/msm/dpu1: Add DSC config for sm8150 and sm8250 >>> drm/msm/dpu1: Wire up DSC mask for active CTL configuration >>> drm/msm/dsi: Use DSC slice(s) packet size to compute word count >>> drm/msm/dsi: Flip greater-than check for slice_count and >>> slice_per_intf >>> drm/msm/dpu: Disallow unallocated (DSC) resources to be returned >> >> General comment: patches with Fixes ideally should come first. Usually >> they are picked into -fixes and/or stable kernels. If the Fixes patches >> are in the middle of the series, one can not be sure that they do not >> have dependencies on previous patches. If there is one, it should >> probably be stated clearly to ease work on backporting them. > > Ack, I may have rushed these RFC patches straight off my branches onto > the lists in hopes of sparking some suggestions on what may still be > broken or missing to get DSC working on sm[12]50, but will keep this in > mind for v2 after receiving some more review. > > That said, any suggestions? From what I've noticed lately: - set dsc_version_major/dsc_version_minor - try using dsc params from 1.2 rater than 1.1 version spec (there is small difference there) -- With best wishes Dmitry