From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40393) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgsO5-0004m6-NQ for qemu-devel@nongnu.org; Tue, 29 Sep 2015 06:43:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZgsO1-00016j-QH for qemu-devel@nongnu.org; Tue, 29 Sep 2015 06:43:57 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33926) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZgsO1-000166-KQ for qemu-devel@nongnu.org; Tue, 29 Sep 2015 06:43:53 -0400 References: <1443389342-2186-1-git-send-email-somlo@cmu.edu> <1443389342-2186-6-git-send-email-somlo@cmu.edu> From: Laszlo Ersek Message-ID: <560A6B64.40801@redhat.com> Date: Tue, 29 Sep 2015 12:43:48 +0200 MIME-Version: 1.0 In-Reply-To: <1443389342-2186-6-git-send-email-somlo@cmu.edu> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4 5/5] fw_cfg: document ACPI device node information List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Gabriel L. Somlo" , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, drjones@redhat.com, matt.fleming@intel.com, ehabkost@redhat.com, mst@redhat.com, zhaoshenglong@huawei.com, leif.lindholm@linaro.org, ard.biesheuvel@linaro.org, kevin@koconnor.net, kraxel@redhat.com, pbonzini@redhat.com, imammedo@redhat.com, markmb@redhat.com, rth@twiddle.net On 09/27/15 23:29, Gabriel L. Somlo wrote: > Signed-off-by: Gabriel Somlo > --- > docs/specs/fw_cfg.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/docs/specs/fw_cfg.txt b/docs/specs/fw_cfg.txt > index bc95404..4d85701 100644 > --- a/docs/specs/fw_cfg.txt > +++ b/docs/specs/fw_cfg.txt > @@ -77,6 +77,15 @@ increasing address order, similar to memcpy(). > Selector Register IOport: 0x510 > Data Register IOport: 0x511 > > +== ACPI Interface == > + > +The fw_cfg device is defined with ACPI ID "QEMU0002". I'd have preferred spelling out "_HID" or "ACPI Hardware ID" here, but I agree that this wording matches that of "docs/specs/pvpanic.txt". > Since we expect > +ACPI tables to be passed into the guest through the fw_cfg device itself, > +the guest-side BIOS can not use ACPI to find fw_cfg. However, once the > +bios is finished setting up ACPI tables and hands control over to the Please replace both "BIOS" and "bios" with "firmware". > +guest kernel, the latter can use the fw_cfg ACPI node for a more accurate > +inventory of in-use IOport or MMIO regions. > + Looks good otherwise. For the next version: Reviewed-by: Laszlo Ersek > == Firmware Configuration Items == > > === Signature (Key 0x0000, FW_CFG_SIGNATURE) === >