From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754243AbbI3Gwl (ORCPT ); Wed, 30 Sep 2015 02:52:41 -0400 Received: from lucky1.263xmail.com ([211.157.147.133]:36513 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753714AbbI3Gwi (ORCPT ); Wed, 30 Sep 2015 02:52:38 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <81b104e26afd3d7184c32754c993fe0c> X-DNS-TYPE: 0 Message-ID: <560B86A7.3090100@rock-chips.com> Date: Wed, 30 Sep 2015 14:52:23 +0800 From: Yakir Yang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Heiko Stuebner , Mark Yao , Thierry Reding , joe@perches.com, Rob Herring CC: David Airlie , Russell King , djkurtz@chromium.org, dianders@chromium.org, Sean Paul , Kukjin Kim , Kumar Gala , emil.l.velikov@gmail.com, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , ajaynumb@gmail.com, robherring2@gmail.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v5 03/17] drm: bridge: analogix/dp: fix some obvious code style References: <1442906428-2609-1-git-send-email-ykk@rock-chips.com> <1442907276-2997-1-git-send-email-ykk@rock-chips.com> <560B719A.4040309@samsung.com> In-Reply-To: <560B719A.4040309@samsung.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 09/30/2015 01:22 PM, Krzysztof Kozlowski wrote: > On 22.09.2015 16:34, Yakir Yang wrote: >> Fix some obvious alignment problems, like alignment and line >> over 80 characters problems, make this easy to be maintained >> later. >> >> Signed-off-by: Yakir Yang >> --- >> Changes in v5: >> - Resequence this patch after analogix_dp driver have been split >> from exynos_dp code, and rephrase reasonable commit message, and >> remove some controversial style (Krzysztof) >> - analogix_dp_write_byte_to_dpcd( >> - dp, DP_TEST_RESPONSE, >> + analogix_dp_write_byte_to_dpcd(dp, >> + DP_TEST_RESPONSE, >> DP_TEST_EDID_CHECKSUM_WRITE); >> >> Changes in v4: None >> Changes in v3: None >> Changes in v2: >> - Improved commit message more readable, and avoid using some >> uncommon style like bellow: (Joe Preches) >> - retval = exynos_dp_read_bytes_from_i2c(... >> ...); >> + retval = >> + exynos_dp_read_bytes_from_i2c(......); >> >> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 129 ++++++++++----------- >> drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 72 ++++++------ >> drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 124 ++++++++++---------- >> 3 files changed, 163 insertions(+), 162 deletions(-) >> > IMHO much better than in previous attempt. The code looks good: > > Reviewed-by: Krzysztof Kozlowski > > BTW my opinion is not enough, you still need an ack from Exynos DP > maintainer (or DRM guys). Aha, thanks. - Yakir > Best regards, > Krzysztof > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Wed, 30 Sep 2015 14:52:23 +0800 Subject: [PATCH v5 03/17] drm: bridge: analogix/dp: fix some obvious code style In-Reply-To: <560B719A.4040309@samsung.com> References: <1442906428-2609-1-git-send-email-ykk@rock-chips.com> <1442907276-2997-1-git-send-email-ykk@rock-chips.com> <560B719A.4040309@samsung.com> Message-ID: <560B86A7.3090100@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Krzysztof, On 09/30/2015 01:22 PM, Krzysztof Kozlowski wrote: > On 22.09.2015 16:34, Yakir Yang wrote: >> Fix some obvious alignment problems, like alignment and line >> over 80 characters problems, make this easy to be maintained >> later. >> >> Signed-off-by: Yakir Yang >> --- >> Changes in v5: >> - Resequence this patch after analogix_dp driver have been split >> from exynos_dp code, and rephrase reasonable commit message, and >> remove some controversial style (Krzysztof) >> - analogix_dp_write_byte_to_dpcd( >> - dp, DP_TEST_RESPONSE, >> + analogix_dp_write_byte_to_dpcd(dp, >> + DP_TEST_RESPONSE, >> DP_TEST_EDID_CHECKSUM_WRITE); >> >> Changes in v4: None >> Changes in v3: None >> Changes in v2: >> - Improved commit message more readable, and avoid using some >> uncommon style like bellow: (Joe Preches) >> - retval = exynos_dp_read_bytes_from_i2c(... >> ...); >> + retval = >> + exynos_dp_read_bytes_from_i2c(......); >> >> drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 129 ++++++++++----------- >> drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 72 ++++++------ >> drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 124 ++++++++++---------- >> 3 files changed, 163 insertions(+), 162 deletions(-) >> > IMHO much better than in previous attempt. The code looks good: > > Reviewed-by: Krzysztof Kozlowski > > BTW my opinion is not enough, you still need an ack from Exynos DP > maintainer (or DRM guys). Aha, thanks. - Yakir > Best regards, > Krzysztof > > > >