From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zhzdf-0005HY-Fq for qemu-devel@nongnu.org; Fri, 02 Oct 2015 08:40:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zhzdb-0007Qm-El for qemu-devel@nongnu.org; Fri, 02 Oct 2015 08:40:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zhzdb-0007PD-8Q for qemu-devel@nongnu.org; Fri, 02 Oct 2015 08:40:35 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 82039C0B64D7 for ; Fri, 2 Oct 2015 12:40:34 +0000 (UTC) References: <1443787955-19823-1-git-send-email-kchamart@redhat.com> From: Eric Blake Message-ID: <560E7B3C.2080905@redhat.com> Date: Fri, 2 Oct 2015 06:40:28 -0600 MIME-Version: 1.0 In-Reply-To: <1443787955-19823-1-git-send-email-kchamart@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GRs2jOHA1xBFll3hi28Dx81O0In9tpmfc" Subject: Re: [Qemu-devel] [PATCH] qmp-commands.hx: Update the supported 'transaction' operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kashyap Chamarthy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, jsnow@redhat.com, famz@redhat.com, mreitz@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GRs2jOHA1xBFll3hi28Dx81O0In9tpmfc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/02/2015 06:12 AM, Kashyap Chamarthy wrote: > Although the canonical source of reference for QMP commands is > qapi-schema.json, for consistency's sake, update qmp-commands.hx to > state the list of supported transactionable operations, namely: >=20 > drive-backup > blockdev-backup > blockdev-snapshot-internal-sync > abort > block-dirty-bitmap-add > block-dirty-bitmap-clear >=20 > Also update the possible values for the "type" action array. >=20 > Signed-off-by: Kashyap Chamarthy > Reviewed-by: Eric Blake Significant enough changes that I would have dropped R-b before posting to ensure it gets looked at. But fortunately, you did a good job, so you can still keep my R-b. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GRs2jOHA1xBFll3hi28Dx81O0In9tpmfc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWDns8AAoJEKeha0olJ0NqDwgIAIE1LABhc3fesRNH5U1Bu8GA ELCaeUMxkgfSEPkzLZ36z7OD6/TXZSvJvuJPHEzSkHQRPQQ7d0Atc37xsISBO9kZ tOZHBlGmpqQn8rPl41himqDAbm5YYv0HkqE55HbcGruP36rr/LI7Ew9Yic/ZutUj yyTZMnrDVrtE+9OCpqoZErSyFNfixdqnAVlUCJ1XAGR4BjdaTVFVxg2joUUTff2x XoO7/Xq7WvzCyeD1ey6MgffqdyDFa1zov688GAH8ehwTpJb4OWpTWkIkC+t6R/Th wd76ai80FHiBa2wIiJ0F4Z72PJK2MlsQ2jMNn3hJedCQq7+5pfN1Ay589pBzZqw= =hMdh -----END PGP SIGNATURE----- --GRs2jOHA1xBFll3hi28Dx81O0In9tpmfc--