From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi4ce-0006A2-WF for qemu-devel@nongnu.org; Fri, 02 Oct 2015 13:59:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zi4ca-00015x-Uv for qemu-devel@nongnu.org; Fri, 02 Oct 2015 13:59:56 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58234) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zi4ca-00015t-Nl for qemu-devel@nongnu.org; Fri, 02 Oct 2015 13:59:52 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 5EFA22FE854 for ; Fri, 2 Oct 2015 17:59:52 +0000 (UTC) References: <1443787955-19823-1-git-send-email-kchamart@redhat.com> From: Max Reitz Message-ID: <560EC614.9000109@redhat.com> Date: Fri, 2 Oct 2015 19:59:48 +0200 MIME-Version: 1.0 In-Reply-To: <1443787955-19823-1-git-send-email-kchamart@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f2IA98BwcOFNV1IjA2EV8oO4vEajHALSf" Subject: Re: [Qemu-devel] [PATCH] qmp-commands.hx: Update the supported 'transaction' operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kashyap Chamarthy , qemu-devel@nongnu.org Cc: kwolf@redhat.com, famz@redhat.com, jsnow@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --f2IA98BwcOFNV1IjA2EV8oO4vEajHALSf Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 02.10.2015 14:12, Kashyap Chamarthy wrote: > Although the canonical source of reference for QMP commands is > qapi-schema.json, for consistency's sake, update qmp-commands.hx to > state the list of supported transactionable operations, namely: >=20 > drive-backup > blockdev-backup > blockdev-snapshot-internal-sync > abort > block-dirty-bitmap-add > block-dirty-bitmap-clear >=20 > Also update the possible values for the "type" action array. >=20 > Signed-off-by: Kashyap Chamarthy > Reviewed-by: Eric Blake > --- > In v8 ("v8" because Fam included this as part of a series that is > in its "v7" edition): > - Update the possible values for supported 'type' of operation > --- > qmp-commands.hx | 29 ++++++++++++++++++++++------- > 1 file changed, 22 insertions(+), 7 deletions(-) >=20 > diff --git a/qmp-commands.hx b/qmp-commands.hx > index d2ba800d5effaddcae4c437452ef1f67c0aaaaa9..2b52980cfc2f80904a3c737= 5a382b638e8a51161 100644 > --- a/qmp-commands.hx > +++ b/qmp-commands.hx > @@ -1270,11 +1270,22 @@ SQMP > transaction > ----------- > =20 > -Atomically operate on one or more block devices. The only supported o= perations > -for now are drive-backup, internal and external snapshotting. A list = of > -dictionaries is accepted, that contains the actions to be performed. > -If there is any failure performing any of the operations, all operatio= ns > -for the group are abandoned. > +Atomically operate on one or more block devices. Operations that are > +currently supported: > + > + - drive-backup > + - blockdev-backup > + - blockdev-snapshot-sync > + - blockdev-snapshot-internal-sync > + - abort > + - block-dirty-bitmap-add > + - block-dirty-bitmap-clear > + > +Refer to the qemu/qapi-schema.json file for minimum required QEMU > +versions for these operations. A list of dictionaries is accepted, > +that contains the actions to be performed. If there is any failure > +performing any of the operations, all operations for the group are > +abandoned. > =20 > For external snapshots, the dictionary contains the device, the file t= o use for > the new snapshot, and the format. The default format, if not specifie= d, is > @@ -1301,8 +1312,12 @@ it later with qemu-img or other command. > Arguments: > =20 > actions array: > - - "type": the operation to perform. The only supported > - value is "blockdev-snapshot-sync". (json-string) > + - "type": the operation to perform (json-string). Possible > + values: "drive-backup", "blockdev-backup", > + "blockdev-snapshot-sync", > + "blockdev-snapshot-internal-sync", > + "abort", "block-dirty-bitmap-add", > + "block-dirty-bitmap-clear" > - "data": a dictionary. The contents depend on the value > of "type". When "type" is "blockdev-snapshot-sync": > - "device": device name to snapshot (json-string) >=20 Do you want to extend this list, too? Right now it only contains parameter information for blockdev-snapshot-sync and blockdev-snapshot-internal-sync. Max --f2IA98BwcOFNV1IjA2EV8oO4vEajHALSf Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWDsYUAAoJEDuxQgLoOKytKi0H/AoA6ulfRo0UGk6Q7lH4nxdi zJGeGGQ6gpsotBcWre30qKapcJoUbfHDSHVW30wDSdck8bF7+nz5Jc4uFR2SikDC 3d4NW0XgZfrr9IrrBxDB3Xpp+9Omh78CMGx4yeJntEHK6ohgK4cEbM6IUISdGqoa +PyO2lA5J3U0ORQbGjrwBxW9eZkR3UoEjfHHCukuMLkelpLxKrO++e+UOt35QJzI HqtYRT5tTJuRUfWIox8kWgqVVrep+HUBvEZx/6KElXIeuNVFvFmWSCRQ3qR5Nc3z GoHTjy9CKlwyYokOggdDDL/joTcxXsk+oWA+14Wue3md9K2IRa9y5KKgUKHrvFk= =19vK -----END PGP SIGNATURE----- --f2IA98BwcOFNV1IjA2EV8oO4vEajHALSf--