From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH v1 1/5] xsplice: Design document. Date: Mon, 05 Oct 2015 04:02:40 -0600 Message-ID: <561266E002000078000A804B@prv-mh.provo.novell.com> References: <1442437276-2620-1-git-send-email-konrad.wilk@oracle.com> <1442437276-2620-2-git-send-email-konrad.wilk@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zj2cs-0005sr-S0 for xen-devel@lists.xenproject.org; Mon, 05 Oct 2015 10:04:10 +0000 In-Reply-To: <1442437276-2620-2-git-send-email-konrad.wilk@oracle.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Konrad Rzeszutek Wilk Cc: elena.ufimtseva@oracle.com, hanweidong@huawei.com, john.liuqiming@huawei.com, paul.voccio@rackspace.com, daniel.kiper@oracle.com, major.hayden@rackspace.com, liuyingdong@huawei.com, aliguori@amazon.com, xiantao.zxt@alibaba-inc.com, lars.kurth@citrix.com, steven.wilson@rackspace.com, ian.campbell@citrix.com, peter.huangpeng@huawei.com, msw@amazon.com, xen-devel@lists.xenproject.org, rick.harris@rackspace.com, boris.ostrovsky@oracle.com, josh.kearney@rackspace.com, jinsong.liu@alibaba-inc.com, amesserl@rackspace.com, mpohlack@amazon.com, fanhenglong@huawei.com, andrew.cooper3@citrix.com List-Id: xen-devel@lists.xenproject.org >>> On 16.09.15 at 23:01, wrote: > +### Symbol names > + > + > +Xen as it is now, has a couple of non-unique symbol names which will > +make runtime symbol identification hard. Sometimes, static symbols > +simply have the same name in C files, sometimes such symbols get > +included via header files, and some C files are also compiled > +multiple times and linked under different names (guest_walk.c). > + > +As such we need to modify the linker to make sure that the symbol > +table qualifies also symbols by their source file name. > + > +For the awkward situations in which C-files are compiled multiple > +times patches we would need to some modification in the Xen code. > + > + > +The convention for file-type symbols (that would allow to map many > +symbols to their compilation unit) says that only the basename (i.e., > +without directories) is embedded. This creates another layer of > +confusion for duplicate file names in the build tree. > + > +That would have to be resolved. I'm working on this, btw. From what I can tell after some investigation over the weekend we probably don't even need to fully overhaul the current symbol handling logic, we just need to pass different options to nm and alter processing its output accordingly. The cumbersome case (but that would have been so also with the originally considered full symbol table approach) will be xen.efi, but I guess I'll first try to deal with this on the binutils side. Jan