All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gujjar, Abhinandan S" <abhinandan.gujjar@intel.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "jerinjacobk@gmail.com" <jerinjacobk@gmail.com>
Subject: Re: [dpdk-dev] [PATCH v2 1/3] test/event_crypto: fix missing IV value for AES algo
Date: Tue, 19 Nov 2019 10:36:05 +0000	[thread overview]
Message-ID: <5612CB344B05EE4F95FC5B729939F780795E3E51@PGSMSX102.gar.corp.intel.com> (raw)
In-Reply-To: <20191107090121.3246-1-hemant.agrawal@nxp.com>

For series:
Acked-by: abhinandan.gujjar@intel.com

I noticed that these patches have issue with "Intel-compilation".
Hope, it will be taken care before merging. 

> -----Original Message-----
> From: Hemant Agrawal <hemant.agrawal@nxp.com>
> Sent: Thursday, November 7, 2019 2:31 PM
> To: dev@dpdk.org
> Cc: jerinjacobk@gmail.com; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>
> Subject: [PATCH v2 1/3] test/event_crypto: fix missing IV value for AES algo
> 
> The IV was not set, which was causing HW based SEC on DPAA1 to fail.
> 
> Fixes: ce02103ad072 ("test/event_crypto: change the SEC cipher algo")
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
> Sending only the fixes. dropped the functional changes
> 
>  app/test/test_event_crypto_adapter.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 652e458f0..bf83a6357 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -171,6 +171,7 @@ test_op_forward_mode(uint8_t session_less)
>  	struct rte_event ev;
>  	uint32_t cap;
>  	int ret;
> +	uint8_t cipher_key[17];
> 
>  	memset(&m_data, 0, sizeof(m_data));
> 
> @@ -186,6 +187,11 @@ test_op_forward_mode(uint8_t session_less)
>  	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
>  	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> 
> +	cipher_xform.cipher.key.data = cipher_key;
> +	cipher_xform.cipher.key.length = 16;
> +	cipher_xform.cipher.iv.offset = IV_OFFSET;
> +	cipher_xform.cipher.iv.length = 16;
> +
>  	op = rte_crypto_op_alloc(params.op_mpool,
>  			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
>  	TEST_ASSERT_NOT_NULL(op,
> @@ -364,6 +370,7 @@ test_op_new_mode(uint8_t session_less)
>  	struct rte_mbuf *m;
>  	uint32_t cap;
>  	int ret;
> +	uint8_t cipher_key[17];
> 
>  	memset(&m_data, 0, sizeof(m_data));
> 
> @@ -379,6 +386,11 @@ test_op_new_mode(uint8_t session_less)
>  	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
>  	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> 
> +	cipher_xform.cipher.key.data = cipher_key;
> +	cipher_xform.cipher.key.length = 16;
> +	cipher_xform.cipher.iv.offset = IV_OFFSET;
> +	cipher_xform.cipher.iv.length = 16;
> +
>  	op = rte_crypto_op_alloc(params.op_mpool,
>  			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
>  	TEST_ASSERT_NOT_NULL(op, "Failed to allocate crypto_op!\n");
> --
> 2.17.1


  parent reply	other threads:[~2019-11-19 10:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-01 11:33 [dpdk-dev] [PATCH 1/6] test/event_crypto: fix missing IV value for AES algo Hemant Agrawal
2019-10-01 11:33 ` [dpdk-dev] [PATCH 2/6] test/event_crypto: fix check for HW support Hemant Agrawal
2019-10-01 11:33 ` [dpdk-dev] [PATCH 3/6] test/event_crypto: fix to avail the mempool entries Hemant Agrawal
2019-10-01 11:33 ` [dpdk-dev] [PATCH 4/6] test/event_crypto: support to release the atomic ctxt Hemant Agrawal
2019-10-01 11:33 ` [dpdk-dev] [PATCH 5/6] test/event_crypto: use device cap instead of fixed values Hemant Agrawal
2019-10-01 11:33 ` [dpdk-dev] [PATCH 6/6] test/event_crypto: separate the NEW and FWD mode inits Hemant Agrawal
2019-10-03  3:24 ` [dpdk-dev] [PATCH 1/6] test/event_crypto: fix missing IV value for AES algo Jerin Jacob
2019-10-03  4:52   ` Gujjar, Abhinandan S
2019-10-04  9:35 ` Gujjar, Abhinandan S
2019-10-16  8:01   ` Jerin Jacob
2019-10-18  5:28   ` Hemant Agrawal
2019-11-07  9:01 ` [dpdk-dev] [PATCH v2 1/3] " Hemant Agrawal
2019-11-07  9:01   ` [dpdk-dev] [PATCH v2 2/3] test/event_crypto: fix to avail the mempool entries Hemant Agrawal
2019-11-07  9:01   ` [dpdk-dev] [PATCH v2 3/3] test/event_crypto: fix check for HW support Hemant Agrawal
2019-11-18 15:59   ` [dpdk-dev] [PATCH v2 1/3] test/event_crypto: fix missing IV value for AES algo Jerin Jacob
2019-11-18 16:02     ` Gujjar, Abhinandan S
2019-11-19 10:36   ` Gujjar, Abhinandan S [this message]
2019-11-20 13:39   ` Jerin Jacob
2019-11-26  5:55     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5612CB344B05EE4F95FC5B729939F780795E3E51@PGSMSX102.gar.corp.intel.com \
    --to=abhinandan.gujjar@intel.com \
    --cc=dev@dpdk.org \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerinjacobk@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.