From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DDFAC433B4 for ; Mon, 10 May 2021 17:10:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24CD961288 for ; Mon, 10 May 2021 17:10:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231874AbhEJRLF (ORCPT ); Mon, 10 May 2021 13:11:05 -0400 Received: from sibelius.xs4all.nl ([83.163.83.176]:63886 "EHLO sibelius.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231713AbhEJRLF (ORCPT ); Mon, 10 May 2021 13:11:05 -0400 Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id 04c0d1db; Mon, 10 May 2021 19:09:58 +0200 (CEST) Date: Mon, 10 May 2021 19:09:58 +0200 (CEST) From: Mark Kettenis To: Krzysztof Kozlowski Cc: kettenis@openbsd.org, devicetree@vger.kernel.org, marcan@marcan.st, linus.walleij@linaro.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <3bad54b9-599a-91c6-48b8-dd1c494f61b5@canonical.com> (message from Krzysztof Kozlowski on Mon, 10 May 2021 09:03:13 -0400) Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl References: <20210508142000.85116-1-kettenis@openbsd.org> <20210508142000.85116-2-kettenis@openbsd.org> <3bad54b9-599a-91c6-48b8-dd1c494f61b5@canonical.com> Message-ID: <5612be6e2a63adbd@bloch.sibelius.xs4all.nl> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org > From: Krzysztof Kozlowski > Date: Mon, 10 May 2021 09:03:13 -0400 > > On 08/05/2021 10:19, Mark Kettenis wrote: > > The Apple GPIO controller is a simple combined pin and GPIO conroller > > present on Apple ARM SoC platforms, including various iPhone and iPad > > devices and the "Apple Silicon" Macs. > > > > Signed-off-by: Mark Kettenis > > --- > > .../bindings/pinctrl/apple,pinctrl.yaml | 103 ++++++++++++++++++ > > MAINTAINERS | 2 + > > include/dt-bindings/pinctrl/apple.h | 13 +++ > > 3 files changed, 118 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > > create mode 100644 include/dt-bindings/pinctrl/apple.h > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > > new file mode 100644 > > index 000000000000..cc7805ca6ba1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > > @@ -0,0 +1,103 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/pinctrl/apple,pinctrl.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Apple GPIO controller > > + > > +maintainers: > > + - Mark Kettenis > > + > > +description: | > > + The Apple GPIO controller is a simple combined pin and GPIO conroller > > + present on Apple ARM SoC platforms, including various iPhone and iPad > > + devices and the "Apple Silicon" Macs. > > + > > +properties: > > + compatible: > > + items: > > + - const: apple,t8103-pinctrl > > + - const: apple,pinctrl > > What is the point of having very generic final compatible in the binding > which does not relate to actual hardware? > > Let's say next SoC will be > apple,x-abcd-foo-2323-whatever-nothing-in-common and you still have to > use generic "apple,pinctrl" even though HW is not at all compatible? > This looks like wildcard, not HW description. Hi Krzysztof, See my reply to Rob's mail. We have some confidence that Apple isn't changing their GPIO block very often. If they were to change it in an incompatible way in a future SoC, we'd drop the "apple,pinctrl" compatible of course. Thanks, Mark From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF3DBC433B4 for ; Mon, 10 May 2021 17:11:30 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 83AEC613CA for ; Mon, 10 May 2021 17:11:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 83AEC613CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=xs4all.nl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:Subject:In-Reply-To:Cc:To:From :Date:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wjzDP2u92E/G1eJH0yO3ZT5jJTnIQXDFymoQDbxZzgE=; b=CHoA4DZDnNVvfmDWWdZZvpKDdN gimKRl+wEn9TB3OoWo0xX8d04AfookxDb76mmA1szi+8XdENxDmVykKYUn9e7QjIN9UWknX51yrTw eLhQq/m602CSWXVdN9PCo6yH3ESGV7PMJauIdyw8/S4NAb7xIqAGum9TT5yyZxWELxTHB4J6pKya5 vZCZqt+jly1A6ddpRByQcqhIHEZ/Dm7nhDNB2Qy7y0BhiVE9hGieIx0oRjuZfvKg52xOC6FakRLUy ySCBWkTdl3ztyb3DI9rArsdMlBxvQ3FgWwDngm30T4VmzinRVl1RAfC0ByTbniuUKQfOlqpCqdCgS VBzV3Lng==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lg9Q3-00F6hd-Pr; Mon, 10 May 2021 17:10:11 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg9Px-00F6gn-HS for linux-arm-kernel@desiato.infradead.org; Mon, 10 May 2021 17:10:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Message-ID:References:Subject: In-Reply-To:Cc:To:From:Date:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description; bh=EFq7k139py3jOiz2gVTT27JGV9kOFZ+gd9lnRQVktLM=; b=2Gw2ATTvuV0bwdXSwg5BCsCYz+ /lhoYgyMZJSGu+i2FITpZNIK4PXdB/r+21QK8NWKuc0Z6RsdBeB69AtNV1KYRhdo323G0n1u/8I+N tBrjCrpc+NnZch8L1cULkNZrKl1haZYcbVXMQFDytSLPPOFIs4CGldhF5z0RHC9cCWxgdeeubTYt6 E+0RvdrvOwPc8n6UatkqMNm0DMeXZRMUO3jpb22WMiPd5t7yM/pTv2FuYa98wQs7J+IZk+SqJOGxn Mz5aH0Aa5uduqEwzmtS/9vOmCokzFNPP5SyhbGWaCEjOFp6LtcCQH5KbdYR9+dZPRYhuc+DKrUjvJ ABp3ct7A==; Received: from sibelius.xs4all.nl ([83.163.83.176]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lg9Ps-008xg6-8E for linux-arm-kernel@lists.infradead.org; Mon, 10 May 2021 17:10:04 +0000 Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id 04c0d1db; Mon, 10 May 2021 19:09:58 +0200 (CEST) Date: Mon, 10 May 2021 19:09:58 +0200 (CEST) From: Mark Kettenis To: Krzysztof Kozlowski Cc: kettenis@openbsd.org, devicetree@vger.kernel.org, marcan@marcan.st, linus.walleij@linaro.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <3bad54b9-599a-91c6-48b8-dd1c494f61b5@canonical.com> (message from Krzysztof Kozlowski on Mon, 10 May 2021 09:03:13 -0400) Subject: Re: [PATCH 1/2] dt-bindings: pinctrl: Add DT bindings for apple,pinctrl References: <20210508142000.85116-1-kettenis@openbsd.org> <20210508142000.85116-2-kettenis@openbsd.org> <3bad54b9-599a-91c6-48b8-dd1c494f61b5@canonical.com> Message-ID: <5612be6e2a63adbd@bloch.sibelius.xs4all.nl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210510_101000_635641_C194CB77 X-CRM114-Status: GOOD ( 19.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > From: Krzysztof Kozlowski > Date: Mon, 10 May 2021 09:03:13 -0400 > > On 08/05/2021 10:19, Mark Kettenis wrote: > > The Apple GPIO controller is a simple combined pin and GPIO conroller > > present on Apple ARM SoC platforms, including various iPhone and iPad > > devices and the "Apple Silicon" Macs. > > > > Signed-off-by: Mark Kettenis > > --- > > .../bindings/pinctrl/apple,pinctrl.yaml | 103 ++++++++++++++++++ > > MAINTAINERS | 2 + > > include/dt-bindings/pinctrl/apple.h | 13 +++ > > 3 files changed, 118 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > > create mode 100644 include/dt-bindings/pinctrl/apple.h > > > > diff --git a/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > > new file mode 100644 > > index 000000000000..cc7805ca6ba1 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pinctrl/apple,pinctrl.yaml > > @@ -0,0 +1,103 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/pinctrl/apple,pinctrl.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Apple GPIO controller > > + > > +maintainers: > > + - Mark Kettenis > > + > > +description: | > > + The Apple GPIO controller is a simple combined pin and GPIO conroller > > + present on Apple ARM SoC platforms, including various iPhone and iPad > > + devices and the "Apple Silicon" Macs. > > + > > +properties: > > + compatible: > > + items: > > + - const: apple,t8103-pinctrl > > + - const: apple,pinctrl > > What is the point of having very generic final compatible in the binding > which does not relate to actual hardware? > > Let's say next SoC will be > apple,x-abcd-foo-2323-whatever-nothing-in-common and you still have to > use generic "apple,pinctrl" even though HW is not at all compatible? > This looks like wildcard, not HW description. Hi Krzysztof, See my reply to Rob's mail. We have some confidence that Apple isn't changing their GPIO block very often. If they were to change it in an incompatible way in a future SoC, we'd drop the "apple,pinctrl" compatible of course. Thanks, Mark _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel