From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH V7 6/7] xl: add usb-assignable-list command Date: Tue, 6 Oct 2015 17:55:03 +0100 Message-ID: <5613FCE7.5080002@citrix.com> References: <1443147102-6471-1-git-send-email-cyliu@suse.com> <1443147102-6471-7-git-send-email-cyliu@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1443147102-6471-7-git-send-email-cyliu@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Chunyan Liu , xen-devel@lists.xen.org Cc: jgross@suse.com, wei.liu2@citrix.com, ian.campbell@citrix.com, george.dunlap@eu.citrix.com, Ian.Jackson@eu.citrix.com, jfehlig@suse.com List-Id: xen-devel@lists.xenproject.org On 25/09/15 03:11, Chunyan Liu wrote: > Add xl usb-assignable-list command to list assignable USB devices. > Assignable USB device means the USB device type is assignable and > it's not assigned to any guest yet. > > Signed-off-by: Chunyan Liu > > --- > Same as "libxl: add libxl_device_usb_assignable_list API" patch, > this patch could be sqaushed to previous one. Split because of > some dispute. Could be squashed if acceptable, otherwise could > be removed. I think it's worth pointing out to other reviewers that the "usb-assignable-list" command introduced here: 1. Has identical behavior to "xm usb-assignable-list", but 2. Has different behavior than "xl pci-assignable-list". Namely: xl pci-assignable-list will list PCI devices which have been detached from their normal driver and have been assigned to pciback (in preparation for being attached to a domain). This command will list all USB devices in dom0 that are not assigned to VMs. Juergen and I had a long back-and-forth about it around v3. I thought having slightly different semantics might be confusing, and Juergen thought the functionality was important to include. We didn't really come to a conclusion and none of the tools maintainers expressed an opinion. I don't feel like arguing about it anymore, so I won't oppose the naming; but I think whoever gives final approval should at least be aware of the slight functional difference between {pci,usb}-assignable-list. Other than that, the patch looks good to me. -George