From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8635DC433EF for ; Fri, 17 Sep 2021 11:34:24 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6A46611C8 for ; Fri, 17 Sep 2021 11:34:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A6A46611C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BDA3B8321C; Fri, 17 Sep 2021 13:34:20 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id CF75B83224; Fri, 17 Sep 2021 13:34:18 +0200 (CEST) Received: from sibelius.xs4all.nl (sibelius.xs4all.nl [83.163.83.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C55DC83216 for ; Fri, 17 Sep 2021 13:34:15 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=mark.kettenis@xs4all.nl Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id dea4aa60; Fri, 17 Sep 2021 13:34:14 +0200 (CEST) Date: Fri, 17 Sep 2021 13:34:14 +0200 (CEST) From: Mark Kettenis To: Qu Wenruo Cc: u-boot@lists.denx.de In-Reply-To: <20210917110235.63885-1-wqu@suse.com> (message from Qu Wenruo on Fri, 17 Sep 2021 19:02:35 +0800) Subject: Re: [PATCH] distro_bootcmd: change the default dtb search path to include default kernel dtbs directory References: <20210917110235.63885-1-wqu@suse.com> Message-ID: <5614667c8ec89eba@bloch.sibelius.xs4all.nl> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean > From: Qu Wenruo > Date: Fri, 17 Sep 2021 19:02:35 +0800 > > When booting using U-boot -> systemd-boot (EFI payload) -> kernel on > RK3399, systemd-boot by some bug can't execute its "devicetree" key > correctly to load its proper dtb from files. > > In that case, it will use fallback dtb from U-boot, which can be > out-of-date, and on RK3399, even the latest U-boot contains out-of-date > dtb which can cause problems like invalid opp tables. > > And for systemd-boot, it doesn't provide any board specific dtb, but > completely relies on the EFI environment provided by U-boot, thus if we > can't find a good dtb, the fallback one will be used anyway. > > So this patch will workaround the problem by appending common linux dtbs > directory to the existing "efi_dtb_prefixes" so that for systemd-boot it > can use the existing fdt and boot properly. Why isn't the dtb installed in the standard location? Slowing the boot process down because distro's can't agree where to put the files is a bit lame... > Signed-off-by: Qu Wenruo > --- > include/config_distro_bootcmd.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/config_distro_bootcmd.h b/include/config_distro_bootcmd.h > index 2627c2a6a541..4ec87483eb65 100644 > --- a/include/config_distro_bootcmd.h > +++ b/include/config_distro_bootcmd.h > @@ -151,7 +151,7 @@ > "load ${devtype} ${devnum}:${distro_bootpart} " \ > "${fdt_addr_r} ${prefix}${efi_fdtfile}\0" \ > \ > - "efi_dtb_prefixes=/ /dtb/ /dtb/current/\0" \ > + "efi_dtb_prefixes=/ /dtb/ /dtb/current/ /dtbs/ /dtbs/current/\0" \ > "scan_dev_for_efi=" \ > "setenv efi_fdtfile ${fdtfile}; " \ > BOOTENV_EFI_SET_FDTFILE_FALLBACK \ > -- > 2.33.0 > >