All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, alyssa@rosenzweig.io,
	kettenis@openbsd.org, tglx@linutronix.de, maz@kernel.org,
	marcan@marcan.st, bhelgaas@google.com, jim2101024@gmail.com,
	nsaenz@kernel.org, f.fainelli@gmail.com,
	bcm-kernel-feedback-list@broadcom.com,
	daire.mcnamara@microchip.com, nsaenzjulienne@suse.de,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/4] dt-bindings: interrupt-controller: msi: Add msi-ranges property
Date: Tue, 21 Sep 2021 19:52:18 +0200 (CEST)	[thread overview]
Message-ID: <56147407e10f61cb@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <YS6cEkDn5IAVW/xQ@robh.at.kernel.org> (message from Rob Herring on Tue, 31 Aug 2021 16:16:02 -0500)

> Date: Tue, 31 Aug 2021 16:16:02 -0500
> From: Rob Herring <robh@kernel.org>
> 
> On Fri, Aug 27, 2021 at 07:15:27PM +0200, Mark Kettenis wrote:
> > From: Mark Kettenis <kettenis@openbsd.org>
> > 
> > Update the MSI controller binding to add an msi-ranges property
> > that specifies how MSIs map onto regular interrupts on some other
> > interrupt controller.
> > 
> > Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> > ---
> >  .../bindings/interrupt-controller/msi-controller.yaml     | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/msi-controller.yaml b/Documentation/devicetree/bindings/interrupt-controller/msi-controller.yaml
> > index 5ed6cd46e2e0..bf8b8a7dba09 100644
> > --- a/Documentation/devicetree/bindings/interrupt-controller/msi-controller.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/msi-controller.yaml
> > @@ -31,4 +31,12 @@ properties:
> >        Identifies the node as an MSI controller.
> >      $ref: /schemas/types.yaml#/definitions/flag
> >  
> > +  msi-ranges:
> > +    description:
> > +      A list of pairs <intid span>, where "intid" is the specification
> 
> It's not really 'pairs' and 'interrupt specifier' is the terminology the 
> spec uses. How about:
> 
> A list of <phandle intspec span>, where "phandle" is parent interrupt 
> controller, "intspec" is the starting/base interrupt specifier, and 
> "span" is the size of that range (typically multiples of 32).
> 
> The 'multiples of 32' part is what Marc told me.

Thanks Rob!  That sounds good.  But 32 is what's typical for the Apple
hardware, and I expect that different hardware that might use this
property will use a different value, so I left that last bit out.  I
also kept the bit that states that multiple ranges are allowed.

> > +      of the first interrupt (including the phandle for the interrupt
> > +      controller) that can be used as an MSI, and "span" the size of
> > +      that range. Multiple ranges can be provided.
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +
> >  additionalProperties: true
> > -- 
> > 2.32.0
> > 
> > 
> 

WARNING: multiple messages have this Message-ID

From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, alyssa@rosenzweig.io,
	kettenis@openbsd.org, tglx@linutronix.de, maz@kernel.org,
	marcan@marcan.st, bhelgaas@google.com, jim2101024@gmail.com,
	nsaenz@kernel.org, f.fainelli@gmail.com,
	bcm-kernel-feedback-list@broadcom.com,
	daire.mcnamara@microchip.com, nsaenzjulienne@suse.de,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org,
	linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v4 2/4] dt-bindings: interrupt-controller: msi: Add msi-ranges property
Date: Tue, 21 Sep 2021 19:52:18 +0200 (CEST)	[thread overview]
Message-ID: <56147407e10f61cb@bloch.sibelius.xs4all.nl> (raw)
In-Reply-To: <YS6cEkDn5IAVW/xQ@robh.at.kernel.org> (message from Rob Herring on Tue, 31 Aug 2021 16:16:02 -0500)

> Date: Tue, 31 Aug 2021 16:16:02 -0500
> From: Rob Herring <robh@kernel.org>
> 
> On Fri, Aug 27, 2021 at 07:15:27PM +0200, Mark Kettenis wrote:
> > From: Mark Kettenis <kettenis@openbsd.org>
> > 
> > Update the MSI controller binding to add an msi-ranges property
> > that specifies how MSIs map onto regular interrupts on some other
> > interrupt controller.
> > 
> > Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> > ---
> >  .../bindings/interrupt-controller/msi-controller.yaml     | 8 ++++++++
> >  1 file changed, 8 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/interrupt-controller/msi-controller.yaml b/Documentation/devicetree/bindings/interrupt-controller/msi-controller.yaml
> > index 5ed6cd46e2e0..bf8b8a7dba09 100644
> > --- a/Documentation/devicetree/bindings/interrupt-controller/msi-controller.yaml
> > +++ b/Documentation/devicetree/bindings/interrupt-controller/msi-controller.yaml
> > @@ -31,4 +31,12 @@ properties:
> >        Identifies the node as an MSI controller.
> >      $ref: /schemas/types.yaml#/definitions/flag
> >  
> > +  msi-ranges:
> > +    description:
> > +      A list of pairs <intid span>, where "intid" is the specification
> 
> It's not really 'pairs' and 'interrupt specifier' is the terminology the 
> spec uses. How about:
> 
> A list of <phandle intspec span>, where "phandle" is parent interrupt 
> controller, "intspec" is the starting/base interrupt specifier, and 
> "span" is the size of that range (typically multiples of 32).
> 
> The 'multiples of 32' part is what Marc told me.

Thanks Rob!  That sounds good.  But 32 is what's typical for the Apple
hardware, and I expect that different hardware that might use this
property will use a different value, so I left that last bit out.  I
also kept the bit that states that multiple ranges are allowed.

> > +      of the first interrupt (including the phandle for the interrupt
> > +      controller) that can be used as an MSI, and "span" the size of
> > +      that range. Multiple ranges can be provided.
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +
> >  additionalProperties: true
> > -- 
> > 2.32.0
> > 
> > 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-09-21 17:52 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-27 17:15 [PATCH v4 0/4] Apple M1 PCIe DT bindings Mark Kettenis
2021-08-27 17:15 ` Mark Kettenis
2021-08-27 17:15 ` [PATCH v4 1/4] dt-bindings: interrupt-controller: Convert MSI controller to json-schema Mark Kettenis
2021-08-27 17:15   ` Mark Kettenis
2021-08-27 19:15   ` Mark Kettenis
2021-08-27 19:15     ` Mark Kettenis
2021-08-31 21:04     ` Rob Herring
2021-08-31 21:04       ` Rob Herring
2021-08-31 20:57   ` Rob Herring
2021-08-31 20:57     ` Rob Herring
2021-09-01 10:56     ` Mark Kettenis
2021-09-01 10:56       ` Mark Kettenis
2021-08-31 20:58   ` Rob Herring
2021-08-31 20:58     ` Rob Herring
2021-08-27 17:15 ` [PATCH v4 2/4] dt-bindings: interrupt-controller: msi: Add msi-ranges property Mark Kettenis
2021-08-27 17:15   ` Mark Kettenis
2021-08-31 21:16   ` Rob Herring
2021-08-31 21:16     ` Rob Herring
2021-09-21 17:52     ` Mark Kettenis [this message]
2021-09-21 17:52       ` Mark Kettenis
2021-08-27 17:15 ` [PATCH v4 3/4] dt-bindings: pci: Add DT bindings for apple,pcie Mark Kettenis
2021-08-27 17:15   ` Mark Kettenis
2021-08-27 17:58   ` Alyssa Rosenzweig
2021-08-27 17:58     ` Alyssa Rosenzweig
2021-08-27 18:22     ` Mark Kettenis
2021-08-27 18:22       ` Mark Kettenis
2021-08-31 21:21   ` Rob Herring
2021-08-31 21:21     ` Rob Herring
2021-09-01 11:29     ` Mark Kettenis
2021-09-01 11:29       ` Mark Kettenis
2021-09-12 20:13       ` Marc Zyngier
2021-09-12 20:13         ` Marc Zyngier
2021-09-13 20:55         ` Rob Herring
2021-09-13 20:55           ` Rob Herring
2021-08-27 17:15 ` [PATCH v4 4/4] arm64: apple: Add PCIe node Mark Kettenis
2021-08-27 17:15   ` Mark Kettenis
2021-08-27 17:59   ` Alyssa Rosenzweig
2021-08-27 17:59     ` Alyssa Rosenzweig
2021-08-27 18:24     ` Mark Kettenis
2021-08-27 18:24       ` Mark Kettenis
2021-08-27 20:09       ` Alyssa Rosenzweig
2021-08-27 20:09         ` Alyssa Rosenzweig
2021-08-30 11:37   ` Marc Zyngier
2021-08-30 11:37     ` Marc Zyngier
2021-08-30 14:57     ` Mark Kettenis
2021-08-30 14:57       ` Mark Kettenis
2021-08-30 20:40       ` Marc Zyngier
2021-08-30 20:40         ` Marc Zyngier
2021-08-30 15:57     ` Rob Herring
2021-08-30 15:57       ` Rob Herring
2021-08-30 20:20       ` Marc Zyngier
2021-08-30 20:20         ` Marc Zyngier
2021-09-12 21:30   ` Marc Zyngier
2021-09-12 21:30     ` Marc Zyngier
2021-09-13 18:35     ` Mark Kettenis
2021-09-13 18:35       ` Mark Kettenis
2021-09-21 11:01 ` [PATCH v4 0/4] Apple M1 PCIe DT bindings Marc Zyngier
2021-09-21 11:01   ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56147407e10f61cb@bloch.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=alyssa@rosenzweig.io \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bhelgaas@google.com \
    --cc=daire.mcnamara@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=jim2101024@gmail.com \
    --cc=kettenis@openbsd.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=marcan@marcan.st \
    --cc=maz@kernel.org \
    --cc=nsaenz@kernel.org \
    --cc=nsaenzjulienne@suse.de \
    --cc=robh@kernel.org \
    --cc=tglx@linutronix.de \
    --subject='Re: [PATCH v4 2/4] dt-bindings: interrupt-controller: msi: Add msi-ranges property' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.