From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 758EFC433F5 for ; Fri, 24 Sep 2021 10:36:27 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5010960F6F for ; Fri, 24 Sep 2021 10:36:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5010960F6F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id E8B668335D; Fri, 24 Sep 2021 12:36:23 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 431F18338C; Fri, 24 Sep 2021 12:36:21 +0200 (CEST) Received: from sibelius.xs4all.nl (sibelius.xs4all.nl [83.163.83.176]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4A3C683246 for ; Fri, 24 Sep 2021 12:36:17 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=xs4all.nl Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=mark.kettenis@xs4all.nl Received: from localhost (bloch.sibelius.xs4all.nl [local]) by bloch.sibelius.xs4all.nl (OpenSMTPD) with ESMTPA id c6e99ea8; Fri, 24 Sep 2021 12:36:16 +0200 (CEST) Date: Fri, 24 Sep 2021 12:36:16 +0200 (CEST) From: Mark Kettenis To: Simon Glass Cc: trini@konsulko.com, xypron.glpk@gmx.de, u-boot@lists.denx.de, ilias.apalodimas@linaro.org, bmeng.cn@gmail.com, christian.melki@t2data.com, agraf@csgraf.de In-Reply-To: (message from Simon Glass on Thu, 23 Sep 2021 20:48:42 -0600) Subject: Re: [PATCH 11/35] RFC: efi: Drop code that doesn't work with driver model References: <20210908133405.696481-1-sjg@chromium.org> <20210908073355.11.Id572ddf5eb457096b95d30ae2d8675f539367fe8@changeid> <56144ca004c70ce9@bloch.sibelius.xs4all.nl> <20210909202308.GG12964@bill-the-cat> <56144d0e41952059@bloch.sibelius.xs4all.nl> Message-ID: <56148065e53864ac@bloch.sibelius.xs4all.nl> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean > From: Simon Glass > Date: Thu, 23 Sep 2021 20:48:42 -0600 > > Hi Mark, > > On Thu, 9 Sept 2021 at 15:45, Mark Kettenis wrote: > > > > > Date: Thu, 9 Sep 2021 16:23:08 -0400 > > > From: Tom Rini > > > > > > On Thu, Sep 09, 2021 at 10:15:44PM +0200, Mark Kettenis wrote: > > > > > From: Simon Glass > > > > > Date: Thu, 9 Sep 2021 13:57:39 -0600 > > > > > > > > > > Hi Heinrich, > > > > > > > > > > On Thu, 9 Sept 2021 at 03:26, Heinrich Schuchardt wrote: > > > > > > > > > > > > > > > > > > > > > > > > On 9/9/21 10:57 AM, Simon Glass wrote: > > > > > > > Hi Heinrich, > > > > > > > > > > > > > > On Wed, 8 Sept 2021 at 11:44, Heinrich Schuchardt wrote: > > > > > > >> > > > > > > >> > > > > > > >> > > > > > > >> On 9/8/21 3:33 PM, Simon Glass wrote: > > > > > > >>> This code should never have been added as it builds a new feature on top > > > > > > >>> of legacy code. Drop it and add a dependency on BLK for this feature. > > > > > > >>> > > > > > > >>> Boards which want EFI_LOADER should migrate to driver model first. > > > > > > >>> > > > > > > >>> Signed-off-by: Simon Glass > > > > > > >> > > > > > > >> This patch is not related to the rest of the series and the code has a > > > > > > >> different maintainer. > > > > > > >> > > > > > > >> So, please, separate it from the series. > > > > > > > > > > > > > > Who is the maintainer? > > > > > > > > > > > > Until 623b3a57976 ("efi_selftest: provide an EFI selftest application") > > > > > > there was no official maintainer for lib/efi/ but you were the main > > > > > > contributor. > > > > > > > > > > > > But with that patch directory lib/efi/ was assigned to EFI PAYLOAD. > > > > > > > > > > > > I am happy if you would continue to care about U-Boot on EFI. > > > > > > > > > > OK. > > > > > > > > > > > > > > > > > > > > > > > > > I need this patch for this series to work. You can still review things > > > > > > > for other maintainers and in this case it is common for one maintainer > > > > > > > to pick up the series once the others are happy. > > > > > > > > > > > > The direction of this patch is completely correct. > > > > > > > > > > > > There are some things that will have to be changed, e.g we should not > > > > > > require CONFIG_DM_ETH=y. I will work on reviewing this patch in detail. > > > > > > > > > > OK, but why not require DM_ETH? The deadline passed a year ago. > > > > > > > > Because we support boards without network ports? > > > > > > Boards without networking should disable the relevant code, and as > > > needed the EFI code return the proper error code? > > > > Yes, but it means you can't make DM_ETH a (hard) requirement for > > EFI_LOADER support. What I mean is that it should still be possible > > to build U-Boot with EFI_LOADER support even if DM_EFI isn't set for a > > board. It should just result in a UEFI implementation with no network > > support instead. > > I think you are misunderstanding my patch. I have: > > depends on DM_ETH || !NET > > which means that if NET is used, DM_ETH must be. I think that is reasonable. Yes, that should be fine (Kconfig stuff doesn't always make sense to me).