From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH net-next 01/15] ipv4: Fix ip_local_out_sk by passing the sk into __ip_local_out_sk Date: Wed, 7 Oct 2015 16:37:03 +0300 Message-ID: <56151FFF.90506@cogentembedded.com> References: <878u7fesrg.fsf_-_@x220.int.ebiederm.org> <1444157595-28816-1-git-send-email-ebiederm@xmission.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org, Nicolas Dichtel , lvs-devel@vger.kernel.org To: "Eric W. Biederman" , David Miller Return-path: In-Reply-To: <1444157595-28816-1-git-send-email-ebiederm@xmission.com> Sender: lvs-devel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org Hello. On 10/6/2015 9:53 PM, Eric W. Biederman wrote: > In the rare case where sk != skb->sk ip_local_out_sk arranges > to call dst->output differently if the skb is queued or not. > This is a bug. > > Fix this bug by passing the sk parameter of ip_local_out_sk through > from ip_local_out_sk to __ip_local_out_sk (skipping __ip_local_out). > > Fixes: 7026b1ddb6b8d4e6ee33dc2bd06c0ca8746fa7ab Please see Documentation/SubmittingPatches on how the Fixes tag should look like. > Signed-off-by: "Eric W. Biederman" MBR, Sergei