From: Giulio Benetti <giulio.benetti@benettiengineering.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/parted: disable on uclibc
Date: Thu, 13 Feb 2020 23:30:52 +0100 [thread overview]
Message-ID: <56158908-2e56-10bd-ff3d-d9b8b5879d23@benettiengineering.com> (raw)
In-Reply-To: <f4f69402-631b-ef46-5f2c-af49fc279cb0@benettiengineering.com>
On 2/13/20 11:26 PM, Giulio Benetti wrote:
> Hi Peter,
>
> On 2/13/20 10:51 PM, Peter Korsgaard wrote:
>>>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
>>
>> > Like postgreSQL (and imagemagick), parted does not build against uClibc
>> > with locales enabled, due to an uClibc bug, see
>> > http://lists.uclibc.org/pipermail/uclibc/2014-April/048326.html:
>>
>> > In file included from atari.c:42:
>> > atari.c: In function 'atr_part_correct':
>> > atari.c:221:9: error: dereferencing pointer to incomplete type 'struct __uclibc_locale_struct'
>> > return isalnum_l(part->id[0], atr_c_locale)
>> > ^~~~~~~~~
>>
>> > So disable parted on uclibc
>>
>> > Fixes:
>> > - http://autobuild.buildroot.org/results/992518d340a9f32a0721d6e66936850c4c3ef2e4
>>
>> > Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>>
>> What about the reverse dependencies? E.G. udisks and python-pyparted?
>
> Since I'm bumping udisks :-), udisks already depends on
> !BR2_TOOLCHAIN_USES_UCLIBC, but python-pyparted does not, so it deserves
> a build with the same autobuilder failure defconfig, I let you know.
Right, "!BR2_TOOLCHAIN_USES_UCLIBC" must be added to
python-pyparted/Config.in. And then it must not be possible to build it
with uclibc, so this patch must be adjusted.
Sorry for the noise
Best regards
--
Giulio Benetti
Benetti Engineering sas
prev parent reply other threads:[~2020-02-13 22:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 16:39 [Buildroot] [PATCH 1/1] package/parted: disable on uclibc Fabrice Fontaine
2020-02-13 21:19 ` Giulio Benetti
2020-02-13 21:51 ` Peter Korsgaard
2020-02-13 22:26 ` Giulio Benetti
2020-02-13 22:30 ` Giulio Benetti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56158908-2e56-10bd-ff3d-d9b8b5879d23@benettiengineering.com \
--to=giulio.benetti@benettiengineering.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.