From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 1/2] net/iavf: rename avf to iavf Date: Fri, 22 Feb 2019 16:43:25 +0000 Message-ID: <5615a7c5-3204-fa69-8119-068be2b0e9fa@intel.com> References: <20190222150336.22299-1-leyi.rong@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: dev@dpdk.org To: Leyi Rong , jingjing.wu@intel.com, wenzhuo.lu@intel.com, qi.z.zhang@intel.com Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id D66DB2BD5 for ; Fri, 22 Feb 2019 17:43:32 +0100 (CET) In-Reply-To: <20190222150336.22299-1-leyi.rong@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 2/22/2019 3:03 PM, Leyi Rong wrote: > Rename Intel Ethernet Adaptive Virtual Function driver avf to iavf. > > This patch renames the directory name, filenames, lib name, macros, > functions, structs and any other strings in the iavf src code. > > Signed-off-by: Leyi Rong > --- > config/common_base | 16 +- > drivers/net/Makefile | 2 +- > drivers/net/avf/avf.h | 216 -- > drivers/net/avf/base/avf_adminq_cmd.h | 2841 ----------------- > drivers/net/avf/base/avf_common.c | 1845 ----------- > drivers/net/avf/base/avf_hmc.h | 245 -- > drivers/net/avf/base/avf_prototype.h | 206 -- > drivers/net/avf/base/avf_register.h | 346 -- > drivers/net/avf/base/avf_status.h | 108 - > drivers/net/avf/base/avf_type.h | 2024 ------------ > drivers/net/{avf => iavf}/Makefile | 16 +- > drivers/net/{avf => iavf}/base/README | 8 +- > .../avf_adminq.c => iavf/base/iavf_adminq.c} | 582 ++-- > .../avf_adminq.h => iavf/base/iavf_adminq.h} | 116 +- > drivers/net/iavf/base/iavf_adminq_cmd.h | 2841 +++++++++++++++++ > .../avf_alloc.h => iavf/base/iavf_alloc.h} | 46 +- > drivers/net/iavf/base/iavf_common.c | 1845 +++++++++++ > .../avf_devids.h => iavf/base/iavf_devids.h} | 10 +- > drivers/net/iavf/base/iavf_hmc.h | 245 ++ > .../base/iavf_lan_hmc.h} | 132 +- > .../avf_osdep.h => iavf/base/iavf_osdep.h} | 82 +- > drivers/net/iavf/base/iavf_prototype.h | 206 ++ > drivers/net/iavf/base/iavf_register.h | 346 ++ > drivers/net/iavf/base/iavf_status.h | 108 + > drivers/net/iavf/base/iavf_type.h | 2024 ++++++++++++ > drivers/net/{avf => iavf}/base/meson.build | 6 +- > drivers/net/{avf => iavf}/base/virtchnl.h | 10 +- > drivers/net/iavf/iavf.h | 216 ++ > .../{avf/avf_ethdev.c => iavf/iavf_ethdev.c} | 730 ++--- > .../net/{avf/avf_log.h => iavf/iavf_log.h} | 20 +- > .../net/{avf/avf_rxtx.c => iavf/iavf_rxtx.c} | 592 ++-- > .../net/{avf/avf_rxtx.h => iavf/iavf_rxtx.h} | 162 +- > .../iavf_rxtx_vec_common.h} | 30 +- > .../iavf_rxtx_vec_sse.c} | 120 +- > .../{avf/avf_vchnl.c => iavf/iavf_vchnl.c} | 256 +- > drivers/net/{avf => iavf}/meson.build | 10 +- > .../rte_pmd_iavf_version.map} | 0 > drivers/net/meson.build | 2 +- > mk/rte.app.mk | 2 +- > 39 files changed, 9306 insertions(+), 9306 deletions(-) > delete mode 100644 drivers/net/avf/avf.h > delete mode 100644 drivers/net/avf/base/avf_adminq_cmd.h > delete mode 100644 drivers/net/avf/base/avf_common.c > delete mode 100644 drivers/net/avf/base/avf_hmc.h > delete mode 100644 drivers/net/avf/base/avf_prototype.h > delete mode 100644 drivers/net/avf/base/avf_register.h > delete mode 100644 drivers/net/avf/base/avf_status.h > delete mode 100644 drivers/net/avf/base/avf_type.h > rename drivers/net/{avf => iavf}/Makefile (73%) > rename drivers/net/{avf => iavf}/base/README (65%) > rename drivers/net/{avf/base/avf_adminq.c => iavf/base/iavf_adminq.c} (56%) > rename drivers/net/{avf/base/avf_adminq.h => iavf/base/iavf_adminq.h} (57%) > create mode 100644 drivers/net/iavf/base/iavf_adminq_cmd.h > rename drivers/net/{avf/base/avf_alloc.h => iavf/base/iavf_alloc.h} (66%) > create mode 100644 drivers/net/iavf/base/iavf_common.c > rename drivers/net/{avf/base/avf_devids.h => iavf/base/iavf_devids.h} (91%) > create mode 100644 drivers/net/iavf/base/iavf_hmc.h > rename drivers/net/{avf/base/avf_lan_hmc.h => iavf/base/iavf_lan_hmc.h} (59%) > rename drivers/net/{avf/base/avf_osdep.h => iavf/base/iavf_osdep.h} (60%) > create mode 100644 drivers/net/iavf/base/iavf_prototype.h > create mode 100644 drivers/net/iavf/base/iavf_register.h > create mode 100644 drivers/net/iavf/base/iavf_status.h > create mode 100644 drivers/net/iavf/base/iavf_type.h > rename drivers/net/{avf => iavf}/base/meson.build (83%) > rename drivers/net/{avf => iavf}/base/virtchnl.h (98%) > create mode 100644 drivers/net/iavf/iavf.h > rename drivers/net/{avf/avf_ethdev.c => iavf/iavf_ethdev.c} (57%) > rename drivers/net/{avf/avf_log.h => iavf/iavf_log.h} (72%) > rename drivers/net/{avf/avf_rxtx.c => iavf/iavf_rxtx.c} (73%) > rename drivers/net/{avf/avf_rxtx.h => iavf/iavf_rxtx.h} (58%) > rename drivers/net/{avf/avf_rxtx_vec_common.h => iavf/iavf_rxtx_vec_common.h} (87%) > rename drivers/net/{avf/avf_rxtx_vec_sse.c => iavf/iavf_rxtx_vec_sse.c} (85%) > rename drivers/net/{avf/avf_vchnl.c => iavf/iavf_vchnl.c} (74%) > rename drivers/net/{avf => iavf}/meson.build (63%) > rename drivers/net/{avf/rte_pmd_avf_version.map => iavf/rte_pmd_iavf_version.map} (100%) > Hi Leyi, Some of the files above look like removed and added new file, instead of renamed, like 'avf_type.h'. This makes this patch too big, and prevents the tractability. When you git log 'iavf_type.h' it shows a single commit that adds this file, if something is broken/forgotten while renaming 'avf' to 'iavf', no way to find it. Do you think how below works: 1- in first patch rename folders and files only, this will force you to update some includes in .c files and makefile/meson files, but I assume git can take this as renaming. 2- second patch update the context of the files, and search/replace each 'avf' with 'iavf'. This can let us to see the if and check easily if there is something wrong. Thanks, ferruh