From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86A9BC07E9A for ; Mon, 5 Jul 2021 08:21:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 74090613C8 for ; Mon, 5 Jul 2021 08:21:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230145AbhGEIY3 (ORCPT ); Mon, 5 Jul 2021 04:24:29 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:43966 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230081AbhGEIYY (ORCPT ); Mon, 5 Jul 2021 04:24:24 -0400 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1658LTJ0005911; Mon, 5 Jul 2021 03:21:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1625473289; bh=Y5AlfMUgJJYX/2dmO0aHXkikhRLjjtuU8z3wKxricB0=; h=From:Subject:To:CC:References:Date:In-Reply-To; b=AaI85ThQ6sn8gb1DpFaqvtAe9iPcadMGWGata0NI9XKZ3m1sX8+UyeZt8Nm4GvGia m6/BYDrsUoYJ0+4fW2O7HDwekOiteOnirynRY2s7B5m7PjzNCEoKIp6uNvMo6uIsQ+ PISwMnGtSwdxUbEli4ipDfWO5CjjQ3luGPrn8k6Y= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1658LTVF129783 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Jul 2021 03:21:29 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 5 Jul 2021 03:21:29 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Mon, 5 Jul 2021 03:21:28 -0500 Received: from [10.250.232.207] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1658LNtD100793; Mon, 5 Jul 2021 03:21:24 -0500 From: Kishon Vijay Abraham I Subject: Re: [RFC PATCH 08/40] PCI: keystone: Cleanup MSI/legacy interrupt configuration and handling To: =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= CC: Jingoo Han , Joao Pinto , Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , , Mark Rutland , Santosh Shilimkar , Nishanth Menon , , , , References: <20180921102155.22839-1-kishon@ti.com> <20180921102155.22839-9-kishon@ti.com> <20210703210152.GA16176@rocinante> Message-ID: <56160f1d-ec91-3b99-312c-aef66eb1a7c2@ti.com> Date: Mon, 5 Jul 2021 13:51:23 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210703210152.GA16176@rocinante> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On 04/07/21 2:31 am, Krzysztof Wilczyński wrote: > Hi Kishon, > >> Now that all PCI keystone functionality has been moved to pci-keystone.c, >> cleanup MSI/legacy interrupt configuration and handling. >> *) Cleanup macros >> *) Remove unnecessary structure variables (required when 2 files are >> used) >> *) Remove ks_dw_pcie_legacy_irq_chip and use dummy_irq_chip >> *) Move request_irq of error irq from ks_add_pcie_port to ks_pcie_probe >> as error_irq is common to both host mode and device mode > [...] > > While looking at some small clean-ups for Bjorn, I stumbled upon this > series, and it seems a lot of your work here cover what Bjorn wanted to > do, thus I need to ask - do you recall, and I appreciate it's been > a while (three years actually), what happened and/or if you ever had the > time to work on this series? > > Would it be possible to resurrect this? Do you need any help? A lot of patches in this series should already be merged (after splitting into smaller ones) http://patchwork.ozlabs.org/project/linux-pci/list/?series=71185 https://patchwork.kernel.org/project/linux-arm-kernel/cover/20190321095927.7058-1-kishon@ti.com/ The following series is still pending and is in my TODO list https://lore.kernel.org/r/20210325090026.8843-1-kishon@ti.com Are there any other clean-ups you are looking into? Thanks and Regards Kishon From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 381BFC07E98 for ; Mon, 5 Jul 2021 08:35:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1AEE61164 for ; Mon, 5 Jul 2021 08:35:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F1AEE61164 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=ti.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:CC:To:Subject:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=bIKS3rsM6saec6lLUgtmeRMjTcRKRSIdWVVQ/rGoLOM=; b=3QHd808gbvQA0AL2vJNpoCP+LT eoOy5M4ekzYx2e3tBLSkQ1kfdDGt0R7MZaRDtYOLU3SFaJtQVsdjAHDYWm2JJRImLtFPXZcdbOvyJ GsGSI0LstGawjjRghYgv8t01ea+i+72LOCn/CwZgkHsFrd3fLLRl3d5DVpH700/iX7C1+JpqlMNh3 xIbr7C0dB+Vk6TWm4nBshJ+5rBn5n7jfsIys26c+Jr1+/QAW38GKNbSON7bHd+s8BzZQ4eBvDCRFP VTbnPzuKIGHmRLq1UIjVTZFL8lmrh7mFCEhALrhK/94FhXKOzWWkEEPg5j8vfzALxMBT5PysCIGTV AMkvD0XA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0K2S-008Hwu-Uf; Mon, 05 Jul 2021 08:33:14 +0000 Received: from fllv0016.ext.ti.com ([198.47.19.142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m0JrL-008Cuj-S6 for linux-arm-kernel@lists.infradead.org; Mon, 05 Jul 2021 08:21:45 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1658LTJ0005911; Mon, 5 Jul 2021 03:21:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1625473289; bh=Y5AlfMUgJJYX/2dmO0aHXkikhRLjjtuU8z3wKxricB0=; h=From:Subject:To:CC:References:Date:In-Reply-To; b=AaI85ThQ6sn8gb1DpFaqvtAe9iPcadMGWGata0NI9XKZ3m1sX8+UyeZt8Nm4GvGia m6/BYDrsUoYJ0+4fW2O7HDwekOiteOnirynRY2s7B5m7PjzNCEoKIp6uNvMo6uIsQ+ PISwMnGtSwdxUbEli4ipDfWO5CjjQ3luGPrn8k6Y= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1658LTVF129783 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 5 Jul 2021 03:21:29 -0500 Received: from DLEE109.ent.ti.com (157.170.170.41) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 5 Jul 2021 03:21:29 -0500 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE109.ent.ti.com (157.170.170.41) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Mon, 5 Jul 2021 03:21:28 -0500 Received: from [10.250.232.207] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1658LNtD100793; Mon, 5 Jul 2021 03:21:24 -0500 From: Kishon Vijay Abraham I Subject: Re: [RFC PATCH 08/40] PCI: keystone: Cleanup MSI/legacy interrupt configuration and handling To: =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= CC: Jingoo Han , Joao Pinto , Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , , Mark Rutland , Santosh Shilimkar , Nishanth Menon , , , , References: <20180921102155.22839-1-kishon@ti.com> <20180921102155.22839-9-kishon@ti.com> <20210703210152.GA16176@rocinante> Message-ID: <56160f1d-ec91-3b99-312c-aef66eb1a7c2@ti.com> Date: Mon, 5 Jul 2021 13:51:23 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210703210152.GA16176@rocinante> Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210705_012144_070136_89FC4B0A X-CRM114-Status: GOOD ( 17.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org SGkgS3J6eXN6dG9mLAoKT24gMDQvMDcvMjEgMjozMSBhbSwgS3J6eXN6dG9mIFdpbGN6ecWEc2tp IHdyb3RlOgo+IEhpIEtpc2hvbiwKPiAKPj4gTm93IHRoYXQgYWxsIFBDSSBrZXlzdG9uZSBmdW5j dGlvbmFsaXR5IGhhcyBiZWVuIG1vdmVkIHRvIHBjaS1rZXlzdG9uZS5jLAo+PiBjbGVhbnVwIE1T SS9sZWdhY3kgaW50ZXJydXB0IGNvbmZpZ3VyYXRpb24gYW5kIGhhbmRsaW5nLgo+PiAgKikgQ2xl YW51cCBtYWNyb3MKPj4gICopIFJlbW92ZSB1bm5lY2Vzc2FyeSBzdHJ1Y3R1cmUgdmFyaWFibGVz IChyZXF1aXJlZCB3aGVuIDIgZmlsZXMgYXJlCj4+ICAgICB1c2VkKQo+PiAgKikgUmVtb3ZlIGtz X2R3X3BjaWVfbGVnYWN5X2lycV9jaGlwIGFuZCB1c2UgZHVtbXlfaXJxX2NoaXAKPj4gICopIE1v dmUgcmVxdWVzdF9pcnEgb2YgZXJyb3IgaXJxIGZyb20ga3NfYWRkX3BjaWVfcG9ydCB0byBrc19w Y2llX3Byb2JlCj4+ICAgICBhcyBlcnJvcl9pcnEgaXMgY29tbW9uIHRvIGJvdGggaG9zdCBtb2Rl IGFuZCBkZXZpY2UgbW9kZQo+IFsuLi5dCj4gCj4gV2hpbGUgbG9va2luZyBhdCBzb21lIHNtYWxs IGNsZWFuLXVwcyBmb3IgQmpvcm4sIEkgc3R1bWJsZWQgdXBvbiB0aGlzCj4gc2VyaWVzLCBhbmQg aXQgc2VlbXMgYSBsb3Qgb2YgeW91ciB3b3JrIGhlcmUgY292ZXIgd2hhdCBCam9ybiB3YW50ZWQg dG8KPiBkbywgdGh1cyBJIG5lZWQgdG8gYXNrIC0gZG8geW91IHJlY2FsbCwgYW5kIEkgYXBwcmVj aWF0ZSBpdCdzIGJlZW4KPiBhIHdoaWxlICh0aHJlZSB5ZWFycyBhY3R1YWxseSksIHdoYXQgaGFw cGVuZWQgYW5kL29yIGlmIHlvdSBldmVyIGhhZCB0aGUKPiB0aW1lIHRvIHdvcmsgb24gdGhpcyBz ZXJpZXM/Cj4gCj4gV291bGQgaXQgYmUgcG9zc2libGUgdG8gcmVzdXJyZWN0IHRoaXM/ICBEbyB5 b3UgbmVlZCBhbnkgaGVscD8KCkEgbG90IG9mIHBhdGNoZXMgaW4gdGhpcyBzZXJpZXMgc2hvdWxk IGFscmVhZHkgYmUgbWVyZ2VkIChhZnRlcgpzcGxpdHRpbmcgaW50byBzbWFsbGVyIG9uZXMpCmh0 dHA6Ly9wYXRjaHdvcmsub3psYWJzLm9yZy9wcm9qZWN0L2xpbnV4LXBjaS9saXN0Lz9zZXJpZXM9 NzExODUKCmh0dHBzOi8vcGF0Y2h3b3JrLmtlcm5lbC5vcmcvcHJvamVjdC9saW51eC1hcm0ta2Vy bmVsL2NvdmVyLzIwMTkwMzIxMDk1OTI3LjcwNTgtMS1raXNob25AdGkuY29tLwoKVGhlIGZvbGxv d2luZyBzZXJpZXMgaXMgc3RpbGwgcGVuZGluZyBhbmQgaXMgaW4gbXkgVE9ETyBsaXN0Cmh0dHBz Oi8vbG9yZS5rZXJuZWwub3JnL3IvMjAyMTAzMjUwOTAwMjYuODg0My0xLWtpc2hvbkB0aS5jb20K CkFyZSB0aGVyZSBhbnkgb3RoZXIgY2xlYW4tdXBzIHlvdSBhcmUgbG9va2luZyBpbnRvPwoKVGhh bmtzIGFuZCBSZWdhcmRzCktpc2hvbgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtl cm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxt YW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=