From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tomas Elf <tomas.elf@intel.com>
Subject: Re: [PATCH 2/8] drm/i915: Migrate to safe iterators in
 error state capture
Date: Fri, 09 Oct 2015 12:40:51 +0100
Message-ID: <5617A7C3.1050903@intel.com>
References: <1444329100-19189-1-git-send-email-tomas.elf@intel.com>
 <1444329100-19189-3-git-send-email-tomas.elf@intel.com>
 <20151009082712.GG26718@phenom.ffwll.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by gabe.freedesktop.org (Postfix) with ESMTP id B1DC67A118
 for <Intel-GFX@lists.freedesktop.org>; Fri,  9 Oct 2015 04:40:53 -0700 (PDT)
In-Reply-To: <20151009082712.GG26718@phenom.ffwll.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Intel-GFX@Lists.FreeDesktop.Org
List-Id: intel-gfx@lists.freedesktop.org

T24gMDkvMTAvMjAxNSAwOToyNywgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBUaHUsIE9jdCAw
OCwgMjAxNSBhdCAwNzozMTozNFBNICswMTAwLCBUb21hcyBFbGYgd3JvdGU6Cj4+IFVzaW5nIHNh
ZmUgbGlzdCBpdGVyYXRvcnMgYWxsZXZpYXRlcyB0aGUgcHJvYmxlbSBvZiB1bnN5bmNocm9uaXpl
ZCBkcml2ZXIgbGlzdAo+PiBtYW5pcHVsYXRpb25zIHdoaWxlIGVycm9yIHN0YXRlIGNhcHR1cmUg
aXMgaW4gdGhlIHByb2Nlc3Mgb2YgdHJhdmVyc2luZyBsaXN0cy4KPj4KPj4gU2lnbmVkLW9mZi1i
eTogVG9tYXMgRWxmIDx0b21hcy5lbGZAaW50ZWwuY29tPgo+PiAtLS0KPj4gICBkcml2ZXJzL2dw
dS9kcm0vaTkxNS9pOTE1X2dwdV9lcnJvci5jIHwgMzggKysrKysrKysrKysrKysrKystLS0tLS0t
LS0tLS0tLS0tLS0KPj4gICAxIGZpbGUgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMTkgZGVs
ZXRpb25zKC0pCj4+Cj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dw
dV9lcnJvci5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9ncHVfZXJyb3IuYwo+PiBpbmRl
eCAyZjA0ZTRmLi4zMmMxNzk5IDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
OTE1X2dwdV9lcnJvci5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ3B1X2Vy
cm9yLmMKPj4gQEAgLTcxOCwxMCArNzE4LDEwIEBAIHN0YXRpYyB2b2lkIGNhcHR1cmVfYm8oc3Ry
dWN0IGRybV9pOTE1X2Vycm9yX2J1ZmZlciAqZXJyLAo+PiAgIHN0YXRpYyB1MzIgY2FwdHVyZV9h
Y3RpdmVfYm8oc3RydWN0IGRybV9pOTE1X2Vycm9yX2J1ZmZlciAqZXJyLAo+PiAgIAkJCSAgICAg
aW50IGNvdW50LCBzdHJ1Y3QgbGlzdF9oZWFkICpoZWFkKQo+PiAgIHsKPj4gLQlzdHJ1Y3QgaTkx
NV92bWEgKnZtYTsKPj4gKwlzdHJ1Y3QgaTkxNV92bWEgKnZtYSwgKnRtcHZtYTsKPj4gICAJaW50
IGkgPSAwOwo+Pgo+PiAtCWxpc3RfZm9yX2VhY2hfZW50cnkodm1hLCBoZWFkLCBtbV9saXN0KSB7
Cj4+ICsJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKHZtYSwgdG1wdm1hLCBoZWFkLCBtbV9saXN0
KSB7Cj4KPiBfc2FmZSBpc24ndCBzYWZlIGFnYWluc3QgYW55dGhpbmcsIGl0J3Mgb25seSBzYWZl
IGFnYWluc3QgcmVtb3ZhbCBvZiB0aGUKPiBjdXJyZW50IGxpc3QgaXRlbSBkb25lIHdpdGggYSBs
aXN0X2RlbC9saXN0X21vdmUgZnJvbSB0aGlzIHRocmVhZC4gSS5lLgo+IHRoZSBvbmx5IHRoaW5n
IGl0IGRvZXMgaXMgaGF2ZSBhIHRlbXBvcmFyeSBwb2ludGVyIHRvIHRoZSBuZXh0IGxpc3QKPiBl
bGVtZW50IHNvIGlmIHlvdSBkZWxldGUgdGhlIGN1cnJlbnQgb25lIGl0IHdvbid0IGZhbGwgb3Zl
ci4KPgo+IEl0IGRvZXNuJ3QgcHJvdGVjdCBhZ2FpbnN0IGFueXRoaW5nIGVsc2UsIGFuZCBlc3Bl
Y2lhbGx5IG5vdCBhZ2FpbnN0IG90aGVyCj4gdGhyZWFkcyB0b3RhbGx5IHN0b21waW5nIHRoZSBs
aXN0LgoKQWJzb2x1dGVseSEgQnV0IGl0J3MgZ29vZCBlbm91Z2ggdG8gbWFrZSB0aGUgdGVzdCBu
b3QgZmFsbCBvdmVyIHdpdGhpbiAKYW4gaG91ciBvZiB0ZXN0aW5nIGFuZCBpbnN0ZWFkIGFsbG93
IGl0IHRvIHJ1biBmb3IgMTIrIGhvdXJzIGR1cmluZyAKY29udGludW91cyBsb25nLWR1cmF0aW9u
IHRlc3RpbmcsIHdoaWNoIGlzIHdoYXQgSSBuZWVkIGZvciB0aGUgVERSIAp2YWxpZGF0aW9uLgoK
Pgo+IFNvIHdlIG5lZWQgcHJvcGVyIHByb3RlY3Rpb24gZm9yIHRoZXNlIGxpc3RzLCBpbmRlcGVu
ZGVudCBvZgo+IGRldi0+c3RydWN0X211dGV4LiBUaGUgbGVhc3QgaW52YXNpdmUgd2F5IHRvIGRv
IHRoYXQgaXMgcHJvYmFibHkgcmN1LAo+IHdoaWNoIG9ubHkgcmVxdWlyZXMgdXMgdGhhdCB3ZSBy
ZWxlYXNlIHRoZSBtZW1vcnkgZm9yIGFueSBvYmplY3Qgc2l0dGluZwo+IG9uIHRoZXNlIGxpc3Rz
IHdpdGgga2ZyZWVfcmN1IGluc3RlYWQgb2Ygbm9ybWFsIGtmcmVlLiBBbm90aGVyIG9wdGlvbgo+
IG1pZ2h0IGJlIGEgc3BpbmxvY2ssIGJ1dCB0aGF0IHdvdWxkIGJlIGEgbG90IG1vcmUgaW52YXNp
dmUsIGFuZCBDaHJpcwo+IHdvbid0IGxpa2UgdGhlIGV4ZWNidWYgb3ZlcmhlYWQgdGhpcyBjYXVz
ZXMgOy0pCj4gLURhbmllbAoKQXdlc29tZSEgTGV0J3MgZ28gd2l0aCB0aGF0IHRoZW4uCgpUaGFu
a3MsClRvbWFzCgo+Cj4+ICAgCQljYXB0dXJlX2JvKGVycisrLCB2bWEpOwo+PiAgIAkJaWYgKCsr
aSA9PSBjb3VudCkKPj4gICAJCQlicmVhazsKPj4gQEAgLTczNCwxNyArNzM0LDE3IEBAIHN0YXRp
YyB1MzIgY2FwdHVyZV9waW5uZWRfYm8oc3RydWN0IGRybV9pOTE1X2Vycm9yX2J1ZmZlciAqZXJy
LAo+PiAgIAkJCSAgICAgaW50IGNvdW50LCBzdHJ1Y3QgbGlzdF9oZWFkICpoZWFkLAo+PiAgIAkJ
CSAgICAgc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0pCj4+ICAgewo+PiAtCXN0cnVjdCBk
cm1faTkxNV9nZW1fb2JqZWN0ICpvYmo7Cj4+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3Qg
Km9iaiwgKnRtcG9iajsKPj4gICAJc3RydWN0IGRybV9pOTE1X2Vycm9yX2J1ZmZlciAqIGNvbnN0
IGZpcnN0ID0gZXJyOwo+PiAgIAlzdHJ1Y3QgZHJtX2k5MTVfZXJyb3JfYnVmZmVyICogY29uc3Qg
bGFzdCA9IGVyciArIGNvdW50Owo+Pgo+PiAtCWxpc3RfZm9yX2VhY2hfZW50cnkob2JqLCBoZWFk
LCBnbG9iYWxfbGlzdCkgewo+PiAtCQlzdHJ1Y3QgaTkxNV92bWEgKnZtYTsKPj4gKwlsaXN0X2Zv
cl9lYWNoX2VudHJ5X3NhZmUob2JqLCB0bXBvYmosIGhlYWQsIGdsb2JhbF9saXN0KSB7Cj4+ICsJ
CXN0cnVjdCBpOTE1X3ZtYSAqdm1hLCAqdG1wdm1hOwo+Pgo+PiAgIAkJaWYgKGVyciA9PSBsYXN0
KQo+PiAgIAkJCWJyZWFrOwo+Pgo+PiAtCQlsaXN0X2Zvcl9lYWNoX2VudHJ5KHZtYSwgJm9iai0+
dm1hX2xpc3QsIHZtYV9saW5rKQo+PiArCQlsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUodm1hLCB0
bXB2bWEsICZvYmotPnZtYV9saXN0LCB2bWFfbGluaykKPj4gICAJCQlpZiAodm1hLT52bSA9PSB2
bSAmJiB2bWEtPnBpbl9jb3VudCA+IDApCj4+ICAgCQkJCWNhcHR1cmVfYm8oZXJyKyssIHZtYSk7
Cj4+ICAgCX0KPj4gQEAgLTk1OCwxMyArOTU4LDEzIEBAIHN0YXRpYyB2b2lkIGk5MTVfZ2VtX3Jl
Y29yZF9hY3RpdmVfY29udGV4dChzdHJ1Y3QgaW50ZWxfZW5naW5lX2NzICpyaW5nLAo+PiAgIAkJ
CQkJICAgc3RydWN0IGRybV9pOTE1X2Vycm9yX3JpbmcgKmVyaW5nKQo+PiAgIHsKPj4gICAJc3Ry
dWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gcmluZy0+ZGV2LT5kZXZfcHJpdmF0ZTsK
Pj4gLQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX29iamVjdCAqb2JqOwo+PiArCXN0cnVjdCBkcm1faTkx
NV9nZW1fb2JqZWN0ICpvYmosICp0bXBvYmo7Cj4+Cj4+ICAgCS8qIEN1cnJlbnRseSByZW5kZXIg
cmluZyBpcyB0aGUgb25seSBIVyBjb250ZXh0IHVzZXIgKi8KPj4gICAJaWYgKHJpbmctPmlkICE9
IFJDUyB8fCAhZXJyb3ItPmNjaWQpCj4+ICAgCQlyZXR1cm47Cj4+Cj4+IC0JbGlzdF9mb3JfZWFj
aF9lbnRyeShvYmosICZkZXZfcHJpdi0+bW0uYm91bmRfbGlzdCwgZ2xvYmFsX2xpc3QpIHsKPj4g
KwlsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUob2JqLCB0bXBvYmosICZkZXZfcHJpdi0+bW0uYm91
bmRfbGlzdCwgZ2xvYmFsX2xpc3QpIHsKPj4gICAJCWlmICghaTkxNV9nZW1fb2JqX2dndHRfYm91
bmQob2JqKSkKPj4gICAJCQljb250aW51ZTsKPj4KPj4gQEAgLTk3OSw3ICs5NzksNyBAQCBzdGF0
aWMgdm9pZCBpOTE1X2dlbV9yZWNvcmRfcmluZ3Moc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPj4g
ICAJCQkJICBzdHJ1Y3QgZHJtX2k5MTVfZXJyb3Jfc3RhdGUgKmVycm9yKQo+PiAgIHsKPj4gICAJ
c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPj4g
LQlzdHJ1Y3QgZHJtX2k5MTVfZ2VtX3JlcXVlc3QgKnJlcXVlc3Q7Cj4+ICsJc3RydWN0IGRybV9p
OTE1X2dlbV9yZXF1ZXN0ICpyZXF1ZXN0LCAqdG1wcmVxOwo+PiAgIAlpbnQgaSwgY291bnQ7Cj4+
Cj4+ICAgCWZvciAoaSA9IDA7IGkgPCBJOTE1X05VTV9SSU5HUzsgaSsrKSB7Cj4+IEBAIC0xMDU1
LDcgKzEwNTUsNyBAQCBzdGF0aWMgdm9pZCBpOTE1X2dlbV9yZWNvcmRfcmluZ3Moc3RydWN0IGRy
bV9kZXZpY2UgKmRldiwKPj4gICAJCWk5MTVfZ2VtX3JlY29yZF9hY3RpdmVfY29udGV4dChyaW5n
LCBlcnJvciwgJmVycm9yLT5yaW5nW2ldKTsKPj4KPj4gICAJCWNvdW50ID0gMDsKPj4gLQkJbGlz
dF9mb3JfZWFjaF9lbnRyeShyZXF1ZXN0LCAmcmluZy0+cmVxdWVzdF9saXN0LCBsaXN0KQo+PiAr
CQlsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUocmVxdWVzdCwgdG1wcmVxLCAmcmluZy0+cmVxdWVz
dF9saXN0LCBsaXN0KQo+PiAgIAkJCWNvdW50Kys7Cj4+Cj4+ICAgCQllcnJvci0+cmluZ1tpXS5u
dW1fcmVxdWVzdHMgPSBjb3VudDsKPj4gQEAgLTEwNjgsNyArMTA2OCw3IEBAIHN0YXRpYyB2b2lk
IGk5MTVfZ2VtX3JlY29yZF9yaW5ncyhzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+PiAgIAkJfQo+
Pgo+PiAgIAkJY291bnQgPSAwOwo+PiAtCQlsaXN0X2Zvcl9lYWNoX2VudHJ5KHJlcXVlc3QsICZy
aW5nLT5yZXF1ZXN0X2xpc3QsIGxpc3QpIHsKPj4gKwkJbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZl
KHJlcXVlc3QsIHRtcHJlcSwgJnJpbmctPnJlcXVlc3RfbGlzdCwgbGlzdCkgewo+PiAgIAkJCXN0
cnVjdCBkcm1faTkxNV9lcnJvcl9yZXF1ZXN0ICplcnE7Cj4+Cj4+ICAgCQkJZXJxID0gJmVycm9y
LT5yaW5nW2ldLnJlcXVlc3RzW2NvdW50KytdOwo+PiBAQCAtMTA4OCwxNyArMTA4OCwxNyBAQCBz
dGF0aWMgdm9pZCBpOTE1X2dlbV9jYXB0dXJlX3ZtKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpk
ZXZfcHJpdiwKPj4gICAJCQkJY29uc3QgaW50IG5keCkKPj4gICB7Cj4+ICAgCXN0cnVjdCBkcm1f
aTkxNV9lcnJvcl9idWZmZXIgKmFjdGl2ZV9ibyA9IE5VTEwsICpwaW5uZWRfYm8gPSBOVUxMOwo+
PiAtCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmo7Cj4+IC0Jc3RydWN0IGk5MTVfdm1h
ICp2bWE7Cj4+ICsJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaiwgKnRtcG9iajsKPj4g
KwlzdHJ1Y3QgaTkxNV92bWEgKnZtYSwgKnRtcHZtYTsKPj4gICAJaW50IGk7Cj4+Cj4+ICAgCWkg
PSAwOwo+PiAtCWxpc3RfZm9yX2VhY2hfZW50cnkodm1hLCAmdm0tPmFjdGl2ZV9saXN0LCBtbV9s
aXN0KQo+PiArCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZSh2bWEsIHRtcHZtYSwgJnZtLT5hY3Rp
dmVfbGlzdCwgbW1fbGlzdCkKPj4gICAJCWkrKzsKPj4gICAJZXJyb3ItPmFjdGl2ZV9ib19jb3Vu
dFtuZHhdID0gaTsKPj4KPj4gLQlsaXN0X2Zvcl9lYWNoX2VudHJ5KG9iaiwgJmRldl9wcml2LT5t
bS5ib3VuZF9saXN0LCBnbG9iYWxfbGlzdCkgewo+PiAtCQlsaXN0X2Zvcl9lYWNoX2VudHJ5KHZt
YSwgJm9iai0+dm1hX2xpc3QsIHZtYV9saW5rKQo+PiArCWxpc3RfZm9yX2VhY2hfZW50cnlfc2Fm
ZShvYmosIHRtcG9iaiwgJmRldl9wcml2LT5tbS5ib3VuZF9saXN0LCBnbG9iYWxfbGlzdCkgewo+
PiArCQlsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUodm1hLCB0bXB2bWEsICZvYmotPnZtYV9saXN0
LCB2bWFfbGluaykKPj4gICAJCQlpZiAodm1hLT52bSA9PSB2bSAmJiB2bWEtPnBpbl9jb3VudCA+
IDApCj4+ICAgCQkJCWkrKzsKPj4gICAJfQo+PiBAQCAtMTEyOCwxMCArMTEyOCwxMCBAQCBzdGF0
aWMgdm9pZCBpOTE1X2dlbV9jYXB0dXJlX3ZtKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZf
cHJpdiwKPj4gICBzdGF0aWMgdm9pZCBpOTE1X2dlbV9jYXB0dXJlX2J1ZmZlcnMoc3RydWN0IGRy
bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+PiAgIAkJCQkgICAgIHN0cnVjdCBkcm1faTkxNV9l
cnJvcl9zdGF0ZSAqZXJyb3IpCj4+ICAgewo+PiAtCXN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2Ug
KnZtOwo+PiArCXN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLCAqdG1wdm07Cj4+ICAgCWlu
dCBjbnQgPSAwLCBpID0gMDsKPj4KPj4gLQlsaXN0X2Zvcl9lYWNoX2VudHJ5KHZtLCAmZGV2X3By
aXYtPnZtX2xpc3QsIGdsb2JhbF9saW5rKQo+PiArCWxpc3RfZm9yX2VhY2hfZW50cnlfc2FmZSh2
bSwgdG1wdm0sICZkZXZfcHJpdi0+dm1fbGlzdCwgZ2xvYmFsX2xpbmspCj4+ICAgCQljbnQrKzsK
Pj4KPj4gICAJZXJyb3ItPmFjdGl2ZV9ibyA9IGtjYWxsb2MoY250LCBzaXplb2YoKmVycm9yLT5h
Y3RpdmVfYm8pLCBHRlBfQVRPTUlDKTsKPj4gQEAgLTExNTUsNyArMTE1NSw3IEBAIHN0YXRpYyB2
b2lkIGk5MTVfZ2VtX2NhcHR1cmVfYnVmZmVycyhzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2
X3ByaXYsCj4+ICAgCQllcnJvci0+cGlubmVkX2JvID0gTlVMTDsKPj4gICAJCWVycm9yLT5waW5u
ZWRfYm9fY291bnQgPSBOVUxMOwo+PiAgIAl9IGVsc2Ugewo+PiAtCQlsaXN0X2Zvcl9lYWNoX2Vu
dHJ5KHZtLCAmZGV2X3ByaXYtPnZtX2xpc3QsIGdsb2JhbF9saW5rKQo+PiArCQlsaXN0X2Zvcl9l
YWNoX2VudHJ5X3NhZmUodm0sIHRtcHZtLCAmZGV2X3ByaXYtPnZtX2xpc3QsIGdsb2JhbF9saW5r
KQo+PiAgIAkJCWk5MTVfZ2VtX2NhcHR1cmVfdm0oZGV2X3ByaXYsIGVycm9yLCB2bSwgaSsrKTsK
Pj4KPj4gICAJCWVycm9yLT52bV9jb3VudCA9IGNudDsKPj4gLS0KPj4gMS45LjEKPj4KPj4gX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4gSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdAo+PiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4+IGh0dHA6
Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKPgoKX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1h
aWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5m
cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK