All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] provide irq_force_affinity fallback for non-SMP
@ 2014-04-23 12:49 Arnd Bergmann
  2014-05-06  5:02 ` Kukjin Kim
  2014-05-06 22:46 ` [tip:irq/urgent] genirq: Provide " tip-bot for Arnd Bergmann
  0 siblings, 2 replies; 3+ messages in thread
From: Arnd Bergmann @ 2014-04-23 12:49 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: linux-kernel, Krzysztof Kozlowski, Kukjin Kim

Patch 01f8fa4f01d "genirq: Allow forcing cpu affinity of interrupts" added
an irq_force_affinity() function, and 30ccf03b4a6 "clocksource: Exynos_mct:
Use irq_force_affinity() in cpu bringup" subsequently uses it. However, the
driver can be used with CONFIG_SMP disabled, but the function declaration
is only available for CONFIG_SMP, leading to this build error:

drivers/clocksource/exynos_mct.c:431:3: error: implicit declaration of function 'irq_force_affinity' [-Werror=implicit-function-declaration]
   irq_force_affinity(mct_irqs[MCT_L0_IRQ + cpu], cpumask_of(cpu));

This patch introduces a dummy helper function for the non-SMP case
that always returns success, to get rid of the build error.
Since the patches causing the problem are marked for stable backports,
this one should be as well.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: stable@vger.kernel.org
---
diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 0e6b23f..b72a643 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -272,6 +272,11 @@ static inline int irq_set_affinity(unsigned int irq, const struct cpumask *m)
 	return -EINVAL;
 }
 
+static inline int irq_force_affinity(unsigned int irq, const struct cpumask *cpumask)
+{
+	return 0;
+}
+
 static inline int irq_can_set_affinity(unsigned int irq)
 {
 	return 0;


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] provide irq_force_affinity fallback for non-SMP
  2014-04-23 12:49 [PATCH] provide irq_force_affinity fallback for non-SMP Arnd Bergmann
@ 2014-05-06  5:02 ` Kukjin Kim
  2014-05-06 22:46 ` [tip:irq/urgent] genirq: Provide " tip-bot for Arnd Bergmann
  1 sibling, 0 replies; 3+ messages in thread
From: Kukjin Kim @ 2014-05-06  5:02 UTC (permalink / raw)
  To: 'Arnd Bergmann', 'Thomas Gleixner'
  Cc: linux-kernel, 'Krzysztof Kozlowski'

Arnd Bergmann wrote:
> 
> Patch 01f8fa4f01d "genirq: Allow forcing cpu affinity of interrupts" added
> an irq_force_affinity() function, and 30ccf03b4a6 "clocksource:
Exynos_mct:
> Use irq_force_affinity() in cpu bringup" subsequently uses it. However,
> the
> driver can be used with CONFIG_SMP disabled, but the function declaration
> is only available for CONFIG_SMP, leading to this build error:
> 
> drivers/clocksource/exynos_mct.c:431:3: error: implicit declaration of
> function 'irq_force_affinity' [-Werror=implicit-function-declaration]
>    irq_force_affinity(mct_irqs[MCT_L0_IRQ + cpu], cpumask_of(cpu));
> 
> This patch introduces a dummy helper function for the non-SMP case
> that always returns success, to get rid of the build error.
> Since the patches causing the problem are marked for stable backports,
> this one should be as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Arnd, thanks for your fix the build error.

Acked-by: Kukjin Kim <kgene.kim@samsung.com>

- Kukjin

> Cc: stable@vger.kernel.org
> ---
> diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
> index 0e6b23f..b72a643 100644
> --- a/include/linux/interrupt.h
> +++ b/include/linux/interrupt.h
> @@ -272,6 +272,11 @@ static inline int irq_set_affinity(unsigned int irq,
> const struct cpumask *m)
>  	return -EINVAL;
>  }
> 
> +static inline int irq_force_affinity(unsigned int irq, const struct
> cpumask *cpumask)
> +{
> +	return 0;
> +}
> +
>  static inline int irq_can_set_affinity(unsigned int irq)
>  {
>  	return 0;


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [tip:irq/urgent] genirq: Provide irq_force_affinity fallback for non-SMP
  2014-04-23 12:49 [PATCH] provide irq_force_affinity fallback for non-SMP Arnd Bergmann
  2014-05-06  5:02 ` Kukjin Kim
@ 2014-05-06 22:46 ` tip-bot for Arnd Bergmann
  1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Arnd Bergmann @ 2014-05-06 22:46 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: linux-kernel, arnd, hpa, mingo, k.kozlowski, tglx, kgene.kim

Commit-ID:  4c88d7f9b0d5fb0588c3386be62115cc2eaa8f9f
Gitweb:     http://git.kernel.org/tip/4c88d7f9b0d5fb0588c3386be62115cc2eaa8f9f
Author:     Arnd Bergmann <arnd@arndb.de>
AuthorDate: Wed, 23 Apr 2014 14:49:17 +0200
Committer:  Thomas Gleixner <tglx@linutronix.de>
CommitDate: Wed, 7 May 2014 00:42:09 +0200

genirq: Provide irq_force_affinity fallback for non-SMP

Patch 01f8fa4f01d "genirq: Allow forcing cpu affinity of interrupts" added
an irq_force_affinity() function, and 30ccf03b4a6 "clocksource: Exynos_mct:
Use irq_force_affinity() in cpu bringup" subsequently uses it. However, the
driver can be used with CONFIG_SMP disabled, but the function declaration
is only available for CONFIG_SMP, leading to this build error:

drivers/clocksource/exynos_mct.c:431:3: error: implicit declaration of function 'irq_force_affinity' [-Werror=implicit-function-declaration]
   irq_force_affinity(mct_irqs[MCT_L0_IRQ + cpu], cpumask_of(cpu));

This patch introduces a dummy helper function for the non-SMP case
that always returns success, to get rid of the build error.
Since the patches causing the problem are marked for stable backports,
this one should be as well.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Cc: stable@vger.kernel.org
Link: http://lkml.kernel.org/r/5619084.0zmrrIUZLV@wuerfel
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
---
 include/linux/interrupt.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/include/linux/interrupt.h b/include/linux/interrupt.h
index 97ac926..051c850 100644
--- a/include/linux/interrupt.h
+++ b/include/linux/interrupt.h
@@ -272,6 +272,11 @@ static inline int irq_set_affinity(unsigned int irq, const struct cpumask *m)
 	return -EINVAL;
 }
 
+static inline int irq_force_affinity(unsigned int irq, const struct cpumask *cpumask)
+{
+	return 0;
+}
+
 static inline int irq_can_set_affinity(unsigned int irq)
 {
 	return 0;

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-05-06 22:46 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-23 12:49 [PATCH] provide irq_force_affinity fallback for non-SMP Arnd Bergmann
2014-05-06  5:02 ` Kukjin Kim
2014-05-06 22:46 ` [tip:irq/urgent] genirq: Provide " tip-bot for Arnd Bergmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.