From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55936) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zl0ZE-0004Bq-Ou for qemu-devel@nongnu.org; Sat, 10 Oct 2015 16:16:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zl0ZB-0002MH-Hf for qemu-devel@nongnu.org; Sat, 10 Oct 2015 16:16:32 -0400 Received: from resqmta-po-07v.sys.comcast.net ([2001:558:fe16:19:96:114:154:166]:36830) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zl0ZB-0002LV-Ce for qemu-devel@nongnu.org; Sat, 10 Oct 2015 16:16:29 -0400 References: <1443930073-19359-1-git-send-email-eblake@redhat.com> <1443930073-19359-6-git-send-email-eblake@redhat.com> <874mi2ws4q.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <5619721A.9070605@redhat.com> Date: Sat, 10 Oct 2015 14:16:26 -0600 MIME-Version: 1.0 In-Reply-To: <874mi2ws4q.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tmsfU8HAi2UrwJ8UF1vewBtdeWdF9lhqX" Subject: Re: [Qemu-devel] [PATCH v7 05/14] qapi: Lazy creation of array types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tmsfU8HAi2UrwJ8UF1vewBtdeWdF9lhqX Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/07/2015 10:38 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Commit ac88219a had several TODO markers about whether we needed >> to automatically create the corresponding array type alongside >> any other type. It turns out that most of the time, we don't! >> >> + def _make_simple_variant(self, case, typ, info): >> if isinstance(typ, list): >> assert len(typ) =3D=3D 1 >> - typ =3D self._make_array_type(typ[0]) >> - typ =3D self._make_implicit_object_type(typ, 'wrapper', >> - [self._make_member('dat= a', typ)]) >> + typ =3D self._make_array_type(typ[0], info) >> + typ =3D self._make_implicit_object_type( >> + typ, 'wrapper', [self._make_member('data', typ, info)]) >=20 > I'd indent the hanging intent a bit more, to make the =3D stand out. pep8 doesn't like it: scripts/qapi.py:1299:17: E126 continuation line over-indented for hanging indent but it was okay with: type =3D (self._make_implicit_object_type( type, ...)) and that does look a little better. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tmsfU8HAi2UrwJ8UF1vewBtdeWdF9lhqX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWGXIaAAoJEKeha0olJ0NqUxcH/2oS/KtdMCYGe9x3myqkVUy2 3P5e8w6YaJwp9saSdLTHv5w3jAckYlAYQNqcn+Ke9pdB3ZFvRhg75gtp3wf3SYYN XnVlfWkCQlkSmsTTTMxp7aWnknsVFnzgJaJIXklFL0QJBvYFoNU1a0FD5ugsMW2l qsnHHTVZIjar7SuomWIxDl5T9yWknIer1iIdmmDmf3Bmvpyu5THKGv731kHqFY3q i8tUht/qq7DEi49Z7w/gyrlWdh/2n/26aVfwyTrx+ZCH2m6lyzLOKFDOC3xpBGl9 X6/qAuz5TuwsgxE6cHDfBQPx6cVT5Cv+IqaN1dqhTmXsWcI5TCQDFvQTUexdRxw= =UgIF -----END PGP SIGNATURE----- --tmsfU8HAi2UrwJ8UF1vewBtdeWdF9lhqX--