From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726AbbJLAt3 (ORCPT ); Sun, 11 Oct 2015 20:49:29 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:53581 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752463AbbJLAt0 (ORCPT ); Sun, 11 Oct 2015 20:49:26 -0400 X-AuditID: cbfec7f5-f794b6d000001495-09-561b0392ae97 Subject: Re: [PATCH v6 05/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range To: Yakir Yang , Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Thierry Reding , Rob Herring , joe@perches.com, Heiko Stuebner , Mark Yao References: <1444491357-26095-1-git-send-email-ykk@rock-chips.com> <1444491961-26799-1-git-send-email-ykk@rock-chips.com> <561B00D4.9060302@rock-chips.com> Cc: Russell King , djkurtz@chromium.org, dianders@chromium.org, Sean Paul , Kukjin Kim , Kumar Gala , emil.l.velikov@gmail.com, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , ajaynumb@gmail.com, robherring2@gmail.com, javier@osg.samsung.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <561B0385.1070704@samsung.com> Date: Mon, 12 Oct 2015 09:49:09 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-version: 1.0 In-reply-to: <561B00D4.9060302@rock-chips.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02SW0iTcRjG+3+nfYqLz9XqjwuDQURGK7PoJSSqmz66qKCwsIta+jGreWhz lXrhNBVPc6aWc5pL1EybHZyR2sGSSDOPWHZ0kzS03DrYPERYOUfU3fO8z+99n5uXJSWVdAB7 PCZe0MQo1XLGl3r2q31gXQEpC9tgsUnhzfUeGm46K0gw9r5GYHk8b7uvPGIgxWSh4fnUFwbu vbATYHRW0DB5LV0Ev99P0NDzqRZBgSOfAqfLSsBVd4kISh0jFIzb+ymYGA8G48gECX0fchno TnWKoGFkkIaBljIGJod/k2DqfUDA2wExNBU9JCC/uJ6C9PuPRTAzPc3A0M1uBKbCjwy8/bkY evSFou1y3lpuRXzauVyGL9X3U/xAnoHg58ZeUnyzeUjE19a4Gb6hLovhHTntBG+rSuYN5z4z fKNxPnTXDZL8nLmV4vMa6xB/Z7Cc3CcJ9w2NFNTHTwua9duO+kalue2iuA7ubMetID0a98tG PizmNuGe3nTSq5fhPvsNJhv5shKuGuFLRhvyGjfCRT9KCQ+1hFPjV6ZRwhMs5WwkHv7aKvJS FoRvW2ZIjyG5NhqnGDIXDjNcCLbVVDHekkBsyCmgPFrMBeGymiLk0RS3Ct96+miBl3KHcGe3 i/Ey/ni20L7A+3AKXH5vis5G7HyBAjv6gzxjkluJbVYXmY/8zf9tmP9R5v+oy4isQ1JBFxGn PaaK3qjQKqO1uhiVIiI2ugF5X2eqCVU/2dqGOBbJ/cRsY0CYhFae1iZEtyHMkvKl4vDE+ZE4 UpmQKGhij2h0akHbhmQsJV8uLmn5ckDCqZTxwklBiBM0f1OC9QnQo9gqmd5nh27L3d1RUlo9 N4kKUzNX1D+vzE5idjc4641JXUsW/fzxPeGs6/zsKBWyM6U4a2x7Tmeoyr26LNhyImPWfnDm 4J41rZXNfa67ud/U+S21Dl1e1K4zGZunrNJ3+2cuHjacMoWFy/Yau5oThy4kuZWr5mTJD0vS /CrUgWs/yyltlDI4iNRolX8AF9bScDYDAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.10.2015 09:37, Yakir Yang wrote: > Hi Krzysztof, > > On 10/10/2015 11:46 PM, Yakir Yang wrote: >> Both hsync/vsync polarity and interlace mode can be parsed from >> drm display mode, and dynamic_range and ycbcr_coeff can be judge >> by the video code. >> >> But presumably Exynos still relies on the DT properties, so take >> good use of mode_fixup() in to achieve the compatibility hacks. >> >> Signed-off-by: Yakir Yang >> --- >> Changes in v6: None > > + of_property_read_u32(dp_node, "hsync-active-high", > + &video->h_sync_polarity); > + of_property_read_u32(dp_node, "vsync-active-high", > + &video->v_sync_polarity); > + of_property_read_u32(dp_node, "interlaced", > + &video->interlaced); > +} > > > Sorry, forget to fix your previous comment here, would > remember to fix it to v7 version, wish v6 would collect > more comment/reviewed/ack. :) Right. You can send a v7 of only this patch. In the same time I would prefer not to chain-reply next version of entire patchset to cover letter of previous version. It confuses me because v6 appears UNDER v4 so I can't really find v6. I see v4 at the top of my email list. In the same time the patchset is quite big. Put the latest version (with this issue above fixed!) on some repo and link it in cover letter. Best regards, Krzysztof > > Best regards, > - Yakir > >> Changes in v5: >> - Switch video timing type to "u32", so driver could use >> "of_property_read_u32" >> to get the backword timing values. Krzysztof suggest me that driver >> could use >> the "of_property_read_bool" to get backword timing values, but that >> interfacs >> would modify the original drm_display_mode timing directly (whether >> those >> properties exists or not). >> >> Changes in v4: >> - Provide backword compatibility with samsung. (Krzysztof) >> >> Changes in v3: >> - Dynamic parse video timing info from struct drm_display_mode and >> struct drm_display_info. (Thierry) >> >> Changes in v2: None From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v6 05/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range Date: Mon, 12 Oct 2015 09:49:09 +0900 Message-ID: <561B0385.1070704@samsung.com> References: <1444491357-26095-1-git-send-email-ykk@rock-chips.com> <1444491961-26799-1-git-send-email-ykk@rock-chips.com> <561B00D4.9060302@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <561B00D4.9060302-TNX95d0MmH7DzftRWevZcw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+glpar-linux-rockchip=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Yakir Yang , Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Thierry Reding , Rob Herring , joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, Heiko Stuebner , Mark Yao Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Kishon Vijay Abraham I , javier-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Kukjin Kim , Sean Paul , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Kumar Gala , ajaynumb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Andy Yan , Gustavo Padovan , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org On 12.10.2015 09:37, Yakir Yang wrote: > Hi Krzysztof, > > On 10/10/2015 11:46 PM, Yakir Yang wrote: >> Both hsync/vsync polarity and interlace mode can be parsed from >> drm display mode, and dynamic_range and ycbcr_coeff can be judge >> by the video code. >> >> But presumably Exynos still relies on the DT properties, so take >> good use of mode_fixup() in to achieve the compatibility hacks. >> >> Signed-off-by: Yakir Yang >> --- >> Changes in v6: None > > + of_property_read_u32(dp_node, "hsync-active-high", > + &video->h_sync_polarity); > + of_property_read_u32(dp_node, "vsync-active-high", > + &video->v_sync_polarity); > + of_property_read_u32(dp_node, "interlaced", > + &video->interlaced); > +} > > > Sorry, forget to fix your previous comment here, would > remember to fix it to v7 version, wish v6 would collect > more comment/reviewed/ack. :) Right. You can send a v7 of only this patch. In the same time I would prefer not to chain-reply next version of entire patchset to cover letter of previous version. It confuses me because v6 appears UNDER v4 so I can't really find v6. I see v4 at the top of my email list. In the same time the patchset is quite big. Put the latest version (with this issue above fixed!) on some repo and link it in cover letter. Best regards, Krzysztof > > Best regards, > - Yakir > >> Changes in v5: >> - Switch video timing type to "u32", so driver could use >> "of_property_read_u32" >> to get the backword timing values. Krzysztof suggest me that driver >> could use >> the "of_property_read_bool" to get backword timing values, but that >> interfacs >> would modify the original drm_display_mode timing directly (whether >> those >> properties exists or not). >> >> Changes in v4: >> - Provide backword compatibility with samsung. (Krzysztof) >> >> Changes in v3: >> - Dynamic parse video timing info from struct drm_display_mode and >> struct drm_display_info. (Thierry) >> >> Changes in v2: None From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Mon, 12 Oct 2015 09:49:09 +0900 Subject: [PATCH v6 05/17] drm: bridge: analogix/dp: dynamic parse sync_pol & interlace & dynamic_range In-Reply-To: <561B00D4.9060302@rock-chips.com> References: <1444491357-26095-1-git-send-email-ykk@rock-chips.com> <1444491961-26799-1-git-send-email-ykk@rock-chips.com> <561B00D4.9060302@rock-chips.com> Message-ID: <561B0385.1070704@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12.10.2015 09:37, Yakir Yang wrote: > Hi Krzysztof, > > On 10/10/2015 11:46 PM, Yakir Yang wrote: >> Both hsync/vsync polarity and interlace mode can be parsed from >> drm display mode, and dynamic_range and ycbcr_coeff can be judge >> by the video code. >> >> But presumably Exynos still relies on the DT properties, so take >> good use of mode_fixup() in to achieve the compatibility hacks. >> >> Signed-off-by: Yakir Yang >> --- >> Changes in v6: None > > + of_property_read_u32(dp_node, "hsync-active-high", > + &video->h_sync_polarity); > + of_property_read_u32(dp_node, "vsync-active-high", > + &video->v_sync_polarity); > + of_property_read_u32(dp_node, "interlaced", > + &video->interlaced); > +} > > > Sorry, forget to fix your previous comment here, would > remember to fix it to v7 version, wish v6 would collect > more comment/reviewed/ack. :) Right. You can send a v7 of only this patch. In the same time I would prefer not to chain-reply next version of entire patchset to cover letter of previous version. It confuses me because v6 appears UNDER v4 so I can't really find v6. I see v4 at the top of my email list. In the same time the patchset is quite big. Put the latest version (with this issue above fixed!) on some repo and link it in cover letter. Best regards, Krzysztof > > Best regards, > - Yakir > >> Changes in v5: >> - Switch video timing type to "u32", so driver could use >> "of_property_read_u32" >> to get the backword timing values. Krzysztof suggest me that driver >> could use >> the "of_property_read_bool" to get backword timing values, but that >> interfacs >> would modify the original drm_display_mode timing directly (whether >> those >> properties exists or not). >> >> Changes in v4: >> - Provide backword compatibility with samsung. (Krzysztof) >> >> Changes in v3: >> - Dynamic parse video timing info from struct drm_display_mode and >> struct drm_display_info. (Thierry) >> >> Changes in v2: None