From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751608AbbJLGr6 (ORCPT ); Mon, 12 Oct 2015 02:47:58 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:49530 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751186AbbJLGrz (ORCPT ); Mon, 12 Oct 2015 02:47:55 -0400 X-AuditID: cbfec7f5-f794b6d000001495-2b-561b579739ba Subject: Re: [PATCH] arm: dts: Fix audio card detection on peach boards To: Alim Akhtar , linux-samsung-soc@vger.kernel.org References: <1444631169-19468-1-git-send-email-alim.akhtar@samsung.com> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kgene@kernel.org, devicetree@vger.kernel.org, dianders@chromium.org, stable@vger.kernel.org From: Krzysztof Kozlowski X-Enigmail-Draft-Status: N1110 Message-id: <561B578E.1050308@samsung.com> Date: Mon, 12 Oct 2015 15:47:42 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-version: 1.0 In-reply-to: <1444631169-19468-1-git-send-email-alim.akhtar@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsVy+t/xy7rTw6XDDH6vUrd4MG8bm8X8I+dY Lc4uO8hm8fqFoUX/49fMFpseX2O1uLxrDpvFjPP7mCwWbHzE6MDpMbvhIovHplWdbB6bl9R7 9G1ZxejxeZNcAGsUl01Kak5mWWqRvl0CV8ac+1NZCxaJVOx9u5+pgfGaQBcjJ4eEgInEnwNf mCBsMYkL99azgdhCAksZJfaf0uxi5AKyvzBKbP76EKxIWMBd4vTNWewgtoiAj8Ttg+1MEA3u Ett3TWMCaWAWWM4o0brjMlgRm4CxxOblS9ggNshJ9HZPYgGxeQW0JI58+c8MYrMIqEqc2Xsc bJCoQITExAkNrBA1ghI/Jt8Dq+cU8JD4dW870EwOoAV6EvcvaoGEmQXkJTavecs8gVFwFpKO WQhVs5BULWBkXsUomlqaXFCclJ5rpFecmFtcmpeul5yfu4kREgtfdzAuPWZ1iFGAg1GJh5dj i1SYEGtiWXFl7iFGCQ5mJRHevUHSYUK8KYmVValF+fFFpTmpxYcYpTlYlMR5Z+56HyIkkJ5Y kpqdmlqQWgSTZeLglGpgnBC56ml24cQn4lt0baQDdN7OuBkRGm7ELPogf4P1s6fHG43elYTn VFlbzpR91aGzuP3BkgtxU24n3Zm48uirEI5XJqfq1+ScfzmVUe7A6y/1ojfnvEjZk3cxuPzg TNZjaz9ueWZ18LCsj/X6/cVhG46yfTq35P3DPvtnp8WXG8xRPnmp7aULu7gSS3FGoqEWc1Fx IgCVbBgEgQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12.10.2015 15:26, Alim Akhtar wrote: > Since the merge of 2fad972 ("ARM: dts: Add mclk entry for Peach boards"), Please switch to longer SHA abbreviation: $ git config core.abbrev 12 > sound card detection is broken on peach boards and gives below errors: > > [ 3.630457] max98090 7-0010: MAX98091 REVID=0x51 > [ 3.634233] max98090 7-0010: use default 2.8v micbias > [ 3.640985] snow-audio sound: HiFi <-> 3830000.i2s mapping ok > [ 3.645307] max98090 7-0010: Invalid master clock frequency > [ 3.650824] snow-audio sound: ASoC: Peach-Pi-I2S-MAX98091 late_probe() failed: -22 > [ 3.658914] snow-audio sound: snd_soc_register_card failed (-22) > [ 3.664366] snow-audio: probe of sound failed with error -22 > > This patch adds missing assigned-clocks and assigned-clock-parents for > pmu_system_controller node which is used as "mclk" for audio codec. > > Signed-off-by: Alim Akhtar > Fixes: 2fad972 ("ARM: dts: Add mclk entry for Peach boards") > Cc: > --- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +++++ > arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index 8f4d76c..525a93a 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > @@ -1056,5 +1056,10 @@ > timeout-sec = <32>; > }; > > +&pmu_system_controller { Please put the node in alphabetical order. > + assigned-clocks = <&pmu_system_controller 0>; > + assigned-clock-parents = <&clock CLK_FIN_PLL>; I might be missing something here but isn't the first clock of pmu_system_controller already a CLK_FIN_PLL? So you are reparenting the FIN_PLL to FIN_PLL? In the same time there is doubled space character after '='. > +}; > + > #include "cros-ec-keyboard.dtsi" > #include "cros-adc-thermistors.dtsi" > diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts > index 7d5b386..411de8f 100644 > --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > @@ -1019,5 +1019,10 @@ > timeout-sec = <32>; > }; > > +&pmu_system_controller { > + assigned-clocks = <&pmu_system_controller 0>; > + assigned-clock-parents = <&clock CLK_FIN_PLL>; Ditto. Best regards, Krzysztof > +}; > + > #include "cros-ec-keyboard.dtsi" > #include "cros-adc-thermistors.dtsi" > From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Mon, 12 Oct 2015 15:47:42 +0900 Subject: [PATCH] arm: dts: Fix audio card detection on peach boards In-Reply-To: <1444631169-19468-1-git-send-email-alim.akhtar@samsung.com> References: <1444631169-19468-1-git-send-email-alim.akhtar@samsung.com> Message-ID: <561B578E.1050308@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 12.10.2015 15:26, Alim Akhtar wrote: > Since the merge of 2fad972 ("ARM: dts: Add mclk entry for Peach boards"), Please switch to longer SHA abbreviation: $ git config core.abbrev 12 > sound card detection is broken on peach boards and gives below errors: > > [ 3.630457] max98090 7-0010: MAX98091 REVID=0x51 > [ 3.634233] max98090 7-0010: use default 2.8v micbias > [ 3.640985] snow-audio sound: HiFi <-> 3830000.i2s mapping ok > [ 3.645307] max98090 7-0010: Invalid master clock frequency > [ 3.650824] snow-audio sound: ASoC: Peach-Pi-I2S-MAX98091 late_probe() failed: -22 > [ 3.658914] snow-audio sound: snd_soc_register_card failed (-22) > [ 3.664366] snow-audio: probe of sound failed with error -22 > > This patch adds missing assigned-clocks and assigned-clock-parents for > pmu_system_controller node which is used as "mclk" for audio codec. > > Signed-off-by: Alim Akhtar > Fixes: 2fad972 ("ARM: dts: Add mclk entry for Peach boards") > Cc: > --- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +++++ > arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 +++++ > 2 files changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index 8f4d76c..525a93a 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > @@ -1056,5 +1056,10 @@ > timeout-sec = <32>; > }; > > +&pmu_system_controller { Please put the node in alphabetical order. > + assigned-clocks = <&pmu_system_controller 0>; > + assigned-clock-parents = <&clock CLK_FIN_PLL>; I might be missing something here but isn't the first clock of pmu_system_controller already a CLK_FIN_PLL? So you are reparenting the FIN_PLL to FIN_PLL? In the same time there is doubled space character after '='. > +}; > + > #include "cros-ec-keyboard.dtsi" > #include "cros-adc-thermistors.dtsi" > diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts > index 7d5b386..411de8f 100644 > --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > @@ -1019,5 +1019,10 @@ > timeout-sec = <32>; > }; > > +&pmu_system_controller { > + assigned-clocks = <&pmu_system_controller 0>; > + assigned-clock-parents = <&clock CLK_FIN_PLL>; Ditto. Best regards, Krzysztof > +}; > + > #include "cros-ec-keyboard.dtsi" > #include "cros-adc-thermistors.dtsi" >