From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752233AbbJLM1o (ORCPT ); Mon, 12 Oct 2015 08:27:44 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:55498 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751830AbbJLM1m (ORCPT ); Mon, 12 Oct 2015 08:27:42 -0400 X-AuditID: cbfee68f-f796f6d0000014a4-87-561ba73c8c15 Message-id: <561BA50C.6020602@samsung.com> Date: Mon, 12 Oct 2015 17:48:20 +0530 From: Alim Akhtar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-version: 1.0 To: Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kgene@kernel.org, devicetree@vger.kernel.org, dianders@chromium.org, stable@vger.kernel.org Subject: Re: [PATCH] arm: dts: Fix audio card detection on peach boards References: <1444631169-19468-1-git-send-email-alim.akhtar@samsung.com> <561B578E.1050308@samsung.com> In-reply-to: <561B578E.1050308@samsung.com> Content-type: text/plain; charset=windows-1252; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRmVeSWpSXmKPExsWyRsSkWtdmuXSYwaIzHBbzj5xjtTi77CCb xesXhhb9j18zW2x6fI3V4vKuOWwWM87vY7JYsPERowOHx+yGiywem1Z1snlsXlLv0bdlFaPH 501yAaxRXDYpqTmZZalF+nYJXBnPJjazFLSKVWw6Pom5gbFHqIuRk0NCwETicc8DZghbTOLC vfVsXYxcHEICKxglFuw8xgxXtGIZM0RiFqPEqxn/WCCcB4wSPT+/A7VwcPAKaEl8uWsD0sAi oCpxa8o1NhCbTUBb4u70LUwgJaICERKPL4At5hUQlPgx+R4LiC0iECZx7+4aJpCRzALLGSVa d1xmB0kIC7hLnL45C8wWEsiQeHj3OthBnEAz129fDzafWcBWYsH7dSwQtrzE5jVvwQ6VELjF LnF1RT8zxEECEt8mH2IBOUJCQFZi0wGoxyQlDq64wTKBUWwWkptmIRk7C8nYBYzMqxhFUwuS C4qT0ouM9YoTc4tL89L1kvNzNzECo+/0v2f9OxjvHrA+xCjAwajEw8u5RSpMiDWxrLgy9xCj KdAVE5mlRJPzgTGeVxJvaGxmZGFqYmpsZG5ppiTOu1DqZ7CQQHpiSWp2ampBalF8UWlOavEh RiYOTqkGxq1adx5Mqfx/13k9c5yBWoeqDbuSwHSPpfnss6fs/ORx4fS7HaLTZe15fS436Nfs 0O7V9fV9eMEt1b/88qPfF85FqnRYB88MfCbDJ6vO+jJm4udjX85YMuana5j0eX/XOmq86dfe 8Jf/XmTy6T5amaNguuHSWX4VR5XDy2bkdIZsTtlZ65PwS4mlOCPRUIu5qDgRALpGAKW5AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMIsWRmVeSWpSXmKPExsVy+t9jQV2b5dJhBr/3MFrMP3KO1eLssoNs Fq9fGFr0P37NbLHp8TVWi8u75rBZzDi/j8liwcZHjA4cHrMbLrJ4bFrVyeaxeUm9R9+WVYwe nzfJBbBGNTDaZKQmpqQWKaTmJeenZOal2yp5B8c7x5uaGRjqGlpamCsp5CXmptoqufgE6Lpl 5gCdoqRQlphTChQKSCwuVtK3wzQhNMRN1wKmMULXNyQIrsfIAA0krGHMeDaxmaWgVaxi0/FJ zA2MPUJdjJwcEgImEo9XLGOGsMUkLtxbz9bFyMUhJDCLUeLVjH8sEM4DRomen9+BMhwcvAJa El/u2oA0sAioStyaco0NxGYT0Ja4O30LE0iJqECExOMLYPN5BQQlfky+xwJiiwiESdy7u4YJ ZCSzwHJGidYdl9lBEsIC7hKnb84Cs4UEMiQe3r0OdhAn0Mz129eDzWcWsJVY8H4dC4QtL7F5 zVvmCYxAVyLsmIWkbBaSsgWMzKsYJVILkguKk9JzDfNSy/WKE3OLS/PS9ZLzczcxgiP8mdQO xoO73A8xCnAwKvHwcmyRChNiTSwrrsw9xCjBwawkwqs0UTpMiDclsbIqtSg/vqg0J7X4EKMp MBAmMkuJJucDk09eSbyhsYm5qbGppYmFiZmlkjjvjUMMYUIC6YklqdmpqQWpRTB9TBycUg2M +r8rlq56cf1PpsFvTYu5qje/rV88oyF4u4Rb2wKzOZ+s7jdU/3KY7/8haPXTyqcJudsfPJ5w aqJ6ntGznnlLoneY6N1v0JvPXRPFEnvDVubKU75zB/5PnJ/2Tl7x6Gb7dwurteb9WpHXsCXd 8vdRxVJW5glPip85lkVlXpMQNH9uPaV31225RiWW4oxEQy3mouJEAMiBv2AGAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Kezysztof Thanks for your review. On 10/12/2015 12:17 PM, Krzysztof Kozlowski wrote: > On 12.10.2015 15:26, Alim Akhtar wrote: >> Since the merge of 2fad972 ("ARM: dts: Add mclk entry for Peach boards"), > > Please switch to longer SHA abbreviation: > $ git config core.abbrev 12 > ok, will do thanks >> sound card detection is broken on peach boards and gives below errors: >> >> [ 3.630457] max98090 7-0010: MAX98091 REVID=0x51 >> [ 3.634233] max98090 7-0010: use default 2.8v micbias >> [ 3.640985] snow-audio sound: HiFi <-> 3830000.i2s mapping ok >> [ 3.645307] max98090 7-0010: Invalid master clock frequency >> [ 3.650824] snow-audio sound: ASoC: Peach-Pi-I2S-MAX98091 late_probe() failed: -22 >> [ 3.658914] snow-audio sound: snd_soc_register_card failed (-22) >> [ 3.664366] snow-audio: probe of sound failed with error -22 >> >> This patch adds missing assigned-clocks and assigned-clock-parents for >> pmu_system_controller node which is used as "mclk" for audio codec. >> >> Signed-off-by: Alim Akhtar >> Fixes: 2fad972 ("ARM: dts: Add mclk entry for Peach boards") >> Cc: >> --- >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +++++ >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 +++++ >> 2 files changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> index 8f4d76c..525a93a 100644 >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> @@ -1056,5 +1056,10 @@ >> timeout-sec = <32>; >> }; >> >> +&pmu_system_controller { > > Please put the node in alphabetical order. > ok >> + assigned-clocks = <&pmu_system_controller 0>; >> + assigned-clock-parents = <&clock CLK_FIN_PLL>; > > I might be missing something here but isn't the first clock of > pmu_system_controller already a CLK_FIN_PLL? So you are reparenting the > FIN_PLL to FIN_PLL? > > In the same time there is doubled space character after '='. > will remove >> +}; >> + >> #include "cros-ec-keyboard.dtsi" >> #include "cros-adc-thermistors.dtsi" >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> index 7d5b386..411de8f 100644 >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> @@ -1019,5 +1019,10 @@ >> timeout-sec = <32>; >> }; >> >> +&pmu_system_controller { >> + assigned-clocks = <&pmu_system_controller 0>; >> + assigned-clock-parents = <&clock CLK_FIN_PLL>; > > Ditto. > > Best regards, > Krzysztof > > >> +}; >> + >> #include "cros-ec-keyboard.dtsi" >> #include "cros-adc-thermistors.dtsi" >> > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alim Akhtar Subject: Re: [PATCH] arm: dts: Fix audio card detection on peach boards Date: Mon, 12 Oct 2015 17:48:20 +0530 Message-ID: <561BA50C.6020602@samsung.com> References: <1444631169-19468-1-git-send-email-alim.akhtar@samsung.com> <561B578E.1050308@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <561B578E.1050308-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Krzysztof Kozlowski , linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, kgene-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hello Kezysztof Thanks for your review. On 10/12/2015 12:17 PM, Krzysztof Kozlowski wrote: > On 12.10.2015 15:26, Alim Akhtar wrote: >> Since the merge of 2fad972 ("ARM: dts: Add mclk entry for Peach boards"), > > Please switch to longer SHA abbreviation: > $ git config core.abbrev 12 > ok, will do thanks >> sound card detection is broken on peach boards and gives below errors: >> >> [ 3.630457] max98090 7-0010: MAX98091 REVID=0x51 >> [ 3.634233] max98090 7-0010: use default 2.8v micbias >> [ 3.640985] snow-audio sound: HiFi <-> 3830000.i2s mapping ok >> [ 3.645307] max98090 7-0010: Invalid master clock frequency >> [ 3.650824] snow-audio sound: ASoC: Peach-Pi-I2S-MAX98091 late_probe() failed: -22 >> [ 3.658914] snow-audio sound: snd_soc_register_card failed (-22) >> [ 3.664366] snow-audio: probe of sound failed with error -22 >> >> This patch adds missing assigned-clocks and assigned-clock-parents for >> pmu_system_controller node which is used as "mclk" for audio codec. >> >> Signed-off-by: Alim Akhtar >> Fixes: 2fad972 ("ARM: dts: Add mclk entry for Peach boards") >> Cc: >> --- >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +++++ >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 +++++ >> 2 files changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> index 8f4d76c..525a93a 100644 >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> @@ -1056,5 +1056,10 @@ >> timeout-sec = <32>; >> }; >> >> +&pmu_system_controller { > > Please put the node in alphabetical order. > ok >> + assigned-clocks = <&pmu_system_controller 0>; >> + assigned-clock-parents = <&clock CLK_FIN_PLL>; > > I might be missing something here but isn't the first clock of > pmu_system_controller already a CLK_FIN_PLL? So you are reparenting the > FIN_PLL to FIN_PLL? > > In the same time there is doubled space character after '='. > will remove >> +}; >> + >> #include "cros-ec-keyboard.dtsi" >> #include "cros-adc-thermistors.dtsi" >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> index 7d5b386..411de8f 100644 >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> @@ -1019,5 +1019,10 @@ >> timeout-sec = <32>; >> }; >> >> +&pmu_system_controller { >> + assigned-clocks = <&pmu_system_controller 0>; >> + assigned-clock-parents = <&clock CLK_FIN_PLL>; > > Ditto. > > Best regards, > Krzysztof > > >> +}; >> + >> #include "cros-ec-keyboard.dtsi" >> #include "cros-adc-thermistors.dtsi" >> > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: alim.akhtar@samsung.com (Alim Akhtar) Date: Mon, 12 Oct 2015 17:48:20 +0530 Subject: [PATCH] arm: dts: Fix audio card detection on peach boards In-Reply-To: <561B578E.1050308@samsung.com> References: <1444631169-19468-1-git-send-email-alim.akhtar@samsung.com> <561B578E.1050308@samsung.com> Message-ID: <561BA50C.6020602@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Kezysztof Thanks for your review. On 10/12/2015 12:17 PM, Krzysztof Kozlowski wrote: > On 12.10.2015 15:26, Alim Akhtar wrote: >> Since the merge of 2fad972 ("ARM: dts: Add mclk entry for Peach boards"), > > Please switch to longer SHA abbreviation: > $ git config core.abbrev 12 > ok, will do thanks >> sound card detection is broken on peach boards and gives below errors: >> >> [ 3.630457] max98090 7-0010: MAX98091 REVID=0x51 >> [ 3.634233] max98090 7-0010: use default 2.8v micbias >> [ 3.640985] snow-audio sound: HiFi <-> 3830000.i2s mapping ok >> [ 3.645307] max98090 7-0010: Invalid master clock frequency >> [ 3.650824] snow-audio sound: ASoC: Peach-Pi-I2S-MAX98091 late_probe() failed: -22 >> [ 3.658914] snow-audio sound: snd_soc_register_card failed (-22) >> [ 3.664366] snow-audio: probe of sound failed with error -22 >> >> This patch adds missing assigned-clocks and assigned-clock-parents for >> pmu_system_controller node which is used as "mclk" for audio codec. >> >> Signed-off-by: Alim Akhtar >> Fixes: 2fad972 ("ARM: dts: Add mclk entry for Peach boards") >> Cc: >> --- >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 5 +++++ >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 5 +++++ >> 2 files changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> index 8f4d76c..525a93a 100644 >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> @@ -1056,5 +1056,10 @@ >> timeout-sec = <32>; >> }; >> >> +&pmu_system_controller { > > Please put the node in alphabetical order. > ok >> + assigned-clocks = <&pmu_system_controller 0>; >> + assigned-clock-parents = <&clock CLK_FIN_PLL>; > > I might be missing something here but isn't the first clock of > pmu_system_controller already a CLK_FIN_PLL? So you are reparenting the > FIN_PLL to FIN_PLL? > > In the same time there is doubled space character after '='. > will remove >> +}; >> + >> #include "cros-ec-keyboard.dtsi" >> #include "cros-adc-thermistors.dtsi" >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> index 7d5b386..411de8f 100644 >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> @@ -1019,5 +1019,10 @@ >> timeout-sec = <32>; >> }; >> >> +&pmu_system_controller { >> + assigned-clocks = <&pmu_system_controller 0>; >> + assigned-clock-parents = <&clock CLK_FIN_PLL>; > > Ditto. > > Best regards, > Krzysztof > > >> +}; >> + >> #include "cros-ec-keyboard.dtsi" >> #include "cros-adc-thermistors.dtsi" >> > >