From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH] drm/i915: Convert WARNs during userptr revoke to SIGBUS Date: Mon, 12 Oct 2015 13:59:34 +0100 Message-ID: <561BAEB6.90701@linux.intel.com> References: <20150928141457.GY3383@phenom.ffwll.local> <56163B4B.6010604@linux.intel.com> <20151009074801.GE18060@phenom.ffwll.local> <20151009084053.GF27939@nuc-i3427.alporthouse.com> <20151009085526.GO26718@phenom.ffwll.local> <561782D2.2070408@linux.intel.com> <20151009171402.GQ26718@phenom.ffwll.local> <20151009172615.GG7517@nuc-i3427.alporthouse.com> <561B780F.4030904@linux.intel.com> <20151012093135.GA27629@nuc-i3427.alporthouse.com> <20151012101011.GB27629@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FFDA6E945 for ; Mon, 12 Oct 2015 05:59:39 -0700 (PDT) In-Reply-To: <20151012101011.GB27629@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Daniel Vetter , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDEyLzEwLzE1IDExOjEwLCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4gT24gTW9uLCBPY3QgMTIs IDIwMTUgYXQgMTA6MzE6MzVBTSArMDEwMCwgQ2hyaXMgV2lsc29uIHdyb3RlOgo+PiBXZSBiYXNp Y2FsbHkgbmVlZCB0byBjbG9uZSB0aGUgb2JqLCBtb3ZlIHRoZSBwYWdlcyBhbmQgdm1hIG92ZXIg YW5kIHNvCj4+IGFzIHRoZSB2bWEgZGllIHRoZSBwYWdlcyBhcmUgdW5yZWZlcmVuY2VkLiBBbGwg bmV3IHVzZSB3aWxsIGJlIGZvcmNlZCB0bwo+PiBjYWxsIGd1cCBhbmQgYmUgZmluZS4KPj4KPj4g T2ssIHRoYXQgc21lbGxzIG9rLCBJJ2xsIHNlZSBob3cgZG9hYmxlIHRoYXQgaXMuCj4KPiBIbW0u IElmIHdlIHRha2UgdGhlIHZtYS1jZW50cmljIGRyaXZlciBhcyBncmFudGVkIChpLmUuIHVzaW5n IHRoZSB2bWEgYXMgdGhlCj4gdG9rZW4gd2hlbiBwaW5uaW5nLCB0aGUgdm1hIGhvbGRzIGZlbmNl cyBldGMpLCB0aGUgdHJpY2t5IHBhcnQgaWYgdGhhdCB3ZQo+IGRvbid0IGhvbGQgYSByZWZlcmVu Y2UgZnJvbSB0aGUgcGlubmVkIHZtYSB0byB0aGUgb2JqZWN0LiBwaW5fZGlzcGxheSB0bwo+IHRo ZSByZXNjdWUhCj4KPiBJbml0aWFsIHNrZXRjaDoKPgo+IHN0YXRpYyBzdHJ1Y3QgZHJtX2k5MTVf Z2VtX29iamVjdCAqc3RlYWxfcGFnZXMoc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iaikK PiB7Cj4gICAgICAgICAgc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKmNsb25lOwo+ICAgICAg ICAgIHN0cnVjdCBpOTE1X3ZtYSAqdm1hOwo+ICAgICAgICAgIGludCBpOwo+Cj4gICAgICAgICAg QlVHX09OKG9iai0+c3RvbGVuKTsKPgo+ICAgICAgICAgIGNsb25lID0gaTkxNV9nZW1fb2JqZWN0 X2FsbG9jKG9iai0+YmFzZS5kZXYpOwo+ICAgICAgICAgIGlmIChjbG9uZSA9PSBOVUxMKQo+ICAg ICAgICAgICAgICAgICAgcmV0dXJuIGNsb25lOwo+Cj4gICAgICAgICAgZHJtX2dlbV9wcml2YXRl X29iamVjdF9pbml0KG9iai0+YmFzZS5kZXYsCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICZjbG9uZS0+YmFzZSwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgb2JqLT5iYXNlLnNpemUpOwo+ICAgICAgICAgIGk5MTVfZ2VtX29iamVjdF9pbml0KGNs b25lLCBvYmotPm9wcyk7Cj4KPiAgICAgICAgICBsaXN0X3NwbGljZV9pbml0KCZvYmotPnZtYV9s aXN0LCAmY2xvbmUtPnZtYV9saXN0KTsKPiAgICAgICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5KHZt YSwgJmNsb25lLT52bWFfbGlzdCwgb2JqX2xpbmspCj4gICAgICAgICAgICAgICAgICB2bWEtPm9i aiA9IGNsb25lOwo+Cj4gICAgICAgICAgaWYgKG9iai0+cGluX2Rpc3BsYXkpIHsKPiAgICAgICAg ICAgICAgICAgIGNsb25lLT5waW5fZGlzcGxheSA9IG9iai0+cGluX2Rpc3BsYXk7Cj4gICAgICAg ICAgICAgICAgICB3aGlsZSAob2JqLT5waW5fZGlzcGxheS0tKSB7Cj4gICAgICAgICAgICAgICAg ICAgICAgICAgIGRybV9nZW1fb2JqZWN0X3JlZmVyZW5jZSgmY2xvbmUtPmJhc2UpOwo+ICAgICAg ICAgICAgICAgICAgICAgICAgICBkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgmb2JqLT5iYXNl KTsKPiAgICAgICAgICAgICAgICAgIH0KPiAgICAgICAgICB9Cj4KPiAgICAgICAgICBjbG9uZS0+ YmluZF9jb3VudCA9IG9iai0+YmluZF9jb3VudDsKPiAgICAgICAgICBvYmotPmJpbmRfY291bnQg PSAwOwo+ICAgICAgICAgIC8qIHZtYV9odCAvIHZtYV9oYXNoZWQgKi8KPgo+ICAgICAgICAgIGZv ciAoaSA9IDA7IGkgPCBJOTE1X05VTV9SSU5HUzsgaSsrKSB7Cj4gICAgICAgICAgICAgICAgICBp ZiAob2JqLT5sYXN0X3JlYWRbaV0ucmVxdWVzdCA9PSBOVUxMKQo+ICAgICAgICAgICAgICAgICAg ICAgICAgICBjb250aW51ZTsKPgo+ICAgICAgICAgICAgICAgICAgY2xvbmUtPmxhc3RfcmVhZFtp XS5yZXF1ZXN0ID0gb2JqLT5sYXN0X3JlYWRbaV0ucmVxdWVzdDsKPiAgICAgICAgICAgICAgICAg IGxpc3RfcmVwbGFjZV9pbml0KCZvYmotPmxhc3RfcmVhZFtpXS5saW5rLAo+ICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgJmNsb25lLT5sYXN0X3JlYWRbaV0ubGluayk7Cj4gICAg ICAgICAgICAgICAgICBjbG9uZS0+ZmxhZ3MgfD0gMSA8PCAoaSArIEk5MTVfQk9fQUNUSVZFX1NI SUZUKTsKPiAgICAgICAgICB9Cj4gICAgICAgICAgaWYgKG9iai0+bGFzdF93cml0ZS5yZXF1ZXN0 KSB7Cj4gICAgICAgICAgICAgICAgICBjbG9uZS0+bGFzdF93cml0ZS5yZXF1ZXN0ID0gb2JqLT5s YXN0X3dyaXRlLnJlcXVlc3Q7Cj4gICAgICAgICAgICAgICAgICBsaXN0X3JlcGxhY2VfaW5pdCgm b2JqLT5sYXN0X3dyaXRlLmxpbmssCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAmY2xvbmUtPmxhc3Rfd3JpdGUubGluayk7Cj4gICAgICAgICAgfQo+Cj4gICAgICAgICAgY2xv bmUtPmRpcnR5ID0gb2JqLT5kaXJ0eTsKPiAgICAgICAgICBvYmotPmRpcnR5ID0gZmFsc2U7Cj4K PiAgICAgICAgICBjbG9uZS0+dGlsaW5nX21vZGUgPSBvYmotPnRpbGluZ19tb2RlOwo+ICAgICAg ICAgIGNsb25lLT5zdHJpZGUgPSBvYmotPnN0cmlkZTsKPgo+ICAgICAgICAgIGNsb25lLT5waW5f ZGlzcGxheSA9IG9iai0+cGluX2Rpc3BsYXk7Cj4gICAgICAgICAgb2JqLT5waW5fZGlzcGxheSA9 IDA7Cj4KPiAgICAgICAgICBjbG9uZS0+bWFkdiA9IEk5MTVfTUFEVl9ET05UTkVFRDsKPiAgICAg ICAgICBjbG9uZS0+cGFnZXMgPSBvYmotPnBhZ2VzOwo+ICAgICAgICAgIGNsb25lLT5wYWdlc19w aW5fY291bnQgPSBvYmotPnBhZ2VzX3Bpbl9jb3VudDsKPiAgICAgICAgICBjbG9uZS0+Z2V0X3Bh Z2UgPSBvYmotPmdldF9wYWdlOwo+ICAgICAgICAgIGNsb25lLT52bWFwcGluZyA9IG9iai0+dm1h cHBpbmc7Cj4gICAgICAgICAgb2JqLT5wYWdlcyA9IE5VTEw7Cj4gICAgICAgICAgb2JqLT5wYWdl c19waW5fY291bnQgPSAwOwo+ICAgICAgICAgIG9iai0+dm1hcHBpbmcgPSBOVUxMOwo+Cj4gICAg ICAgICAgY2xvbmUtPmJpdF8xNyA9IG9iai0+Yml0XzE3Owo+ICAgICAgICAgIG9iai0+Yml0XzE3 ID0gTlVMTDsKPgo+ICAgICAgICAgIGk5MTVfZ2VtX3JlbGVhc2VfbW1hcChvYmopOwo+Cj4gICAg ICAgICAgaWYgKEk5MTVfQk9fSVNfQUNUSVZFKGNsb25lKSkKPiAgICAgICAgICAgICAgICAgIGNs b25lLT5hY3RpdmVfcmVmZXJlbmNlID0gdHJ1ZTsKPiAgICAgICAgICBlbHNlCj4gICAgICAgICAg ICAgICAgICBkcm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZSgmY2xvbmUtPmJhc2UpOwo+Cj4gICAg ICAgICAgcmV0dXJuIGNsb25lOwo+IH0KPgo+IEl0IGRvZXMgaGF2ZSB0aGUgcHJlc3VtcHRpb24g dGhhdCB3ZSBoYXZlIGVpdGhlciBhbiBhY3RpdmUgcmVmZXJlbmNlIG9yIGEKPiBwaW5uZWQgcmVm ZXJlbmNlLgoKSSBnZXQgdGhlIGdlbmVyYWwgaWRlYSBidXQgdGhlIGJhc2UgaXMgdG9vIGZhciBm cm9tIHRoZSBjdXJyZW50IGNvZGUgdG8gCnByb3Blcmx5IGV2YWx1YXRlLiBCdXQgaW4gcHJpbmNp cGxlIGl0IHNvdW5kcyBwcm9taXNpbmcuCgpSZWdhcmRzLAoKVHZydGtvCgoKCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcg bGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK