From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751850AbbJLQoc (ORCPT ); Mon, 12 Oct 2015 12:44:32 -0400 Received: from mail-lb0-f170.google.com ([209.85.217.170]:34593 "EHLO mail-lb0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbbJLQoa (ORCPT ); Mon, 12 Oct 2015 12:44:30 -0400 Subject: Re: [PATCH] usb: musb: core: add common method of getting vbus status To: Roman Alyautdin , balbi@ti.com References: <1444658365-433-1-git-send-email-ralyautdin@dev.rtsoft.ru> <1444659272-599-1-git-send-email-ralyautdin@dev.rtsoft.ru> Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <561BE36B.2000908@cogentembedded.com> Date: Mon, 12 Oct 2015 19:44:27 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <1444659272-599-1-git-send-email-ralyautdin@dev.rtsoft.ru> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 10/12/2015 05:14 PM, Roman Alyautdin wrote: > Fix musb_platform_get_vbus_status return value in case of platform > implementation is not defined, bringing expected behaviour of > musb_platform_get wrapper. Add musb_vbus_show default method to determine > VBUS status in case platform method is not defined. > > Signed-off-by: Roman Alyautdin > --- > drivers/usb/musb/musb_core.c | 13 ++++++++++--- > drivers/usb/musb/musb_core.h | 2 +- > 2 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c > index 4a518ff..3551540 100644 > --- a/drivers/usb/musb/musb_core.c > +++ b/drivers/usb/musb/musb_core.c > @@ -1771,13 +1771,20 @@ musb_vbus_show(struct device *dev, struct device_attribute *attr, char *buf) > unsigned long flags; > unsigned long val; > int vbus; > + u8 devctl; I'd add the variable to the block it's used in but this way is OK too. [...] MBR, Sergei