From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Reset dpll_hw_state when selecting a new pll on hsw
Date: Tue, 13 Oct 2015 16:00:37 +0200 [thread overview]
Message-ID: <561D0E85.2020809@linux.intel.com> (raw)
In-Reply-To: <20151013135830.GF26718@phenom.ffwll.local>
Op 13-10-15 om 15:58 schreef Daniel Vetter:
> On Tue, Oct 13, 2015 at 03:43:28PM +0200, Maarten Lankhorst wrote:
>> Op 13-10-15 om 15:35 schreef Daniel Vetter:
>>> On Tue, Oct 13, 2015 at 03:18:16PM +0200, Maarten Lankhorst wrote:
>>>> Op 23-09-15 om 17:34 schreef Gabriel Feceoru:
>>>>> Using 2 connectors (DVI and VGA) will cause wrpll to be set for
>>>>> INTEL_OUTPUT_HDMI but never reset if switching to INTEL_OUTPUT_VGA
>>>>>
>>>>> Supresses errors like these:
>>>>> [drm:intel_pipe_config_compare [i915]] *ERROR* mismatch in dpll_hw_state.wrpll
>>>>>
>>>> Looks like a good idea to always zero it.
>>> Except that we still have a bunch of cases where we recompute clock state
>>> but only partially. Can we just move them all up into a common place
>>> please? That would also catch cases where we simply forget to fill this
>>> out at all.
>>>
>>> One case I noticed is edp in skl_ddi_pll_select, but there's probably
>>> more.
>>>
>> Something like below, with all the memsets for dpll_hw_state removed?
> I think this will blow up since we recompute clock state only when
> needs_modeset is true. So needs a bit more intelligence in deciding when
> to clear it I think.
Oops you're right. Maybe intel_modeset_clear_plls because that's where all the clock state belongs?
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-10-13 14:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 15:34 [PATCH] drm/i915: Reset dpll_hw_state when selecting a new pll on hsw Gabriel Feceoru
2015-10-13 13:18 ` Maarten Lankhorst
2015-10-13 13:35 ` Daniel Vetter
2015-10-13 13:43 ` Daniel Vetter
2015-10-13 13:43 ` Maarten Lankhorst
2015-10-13 13:58 ` Daniel Vetter
2015-10-13 14:00 ` Maarten Lankhorst [this message]
2015-10-13 14:08 ` Daniel Vetter
2015-10-14 8:21 ` Ander Conselvan De Oliveira
2015-10-14 12:44 ` Daniel Vetter
2015-10-14 13:58 ` Ander Conselvan De Oliveira
2015-10-14 15:03 ` Daniel Vetter
2015-11-10 12:53 ` Jani Nikula
2015-11-11 9:25 ` Ander Conselvan De Oliveira
2015-11-11 14:21 ` Jani Nikula
2015-11-11 16:41 ` [PATCH] drm/i915: Clear DDI pll selection in intel_crtc_compute_config() Ander Conselvan de Oliveira
2015-11-11 18:27 ` [PATCH] drm/i915: Reset dpll_hw_state when selecting a new pll on hsw Gabriel Feceoru
2015-11-12 8:28 ` Lankhorst, Maarten
2015-11-12 18:35 ` Gabriel Feceoru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561D0E85.2020809@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.