From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752126AbbJNETg (ORCPT ); Wed, 14 Oct 2015 00:19:36 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:43613 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbbJNETd (ORCPT ); Wed, 14 Oct 2015 00:19:33 -0400 X-Auth-Info: VFjwc69FauApg6saqphN3FO+8mJU1t1JzYRwJo7bdGw= Subject: Re: [PATCH] rtc: pcf8563: disable CLKOUT To: Alexandre Belloni References: <1444712938-22865-1-git-send-email-hs@denx.de> <20151013201703.GA3421@piout.net> Cc: linux-kernel@vger.kernel.org, Georg.Soffel@bosch-si.com, rtc-linux@googlegroups.com, Alessandro Zummo , devicetree@vger.kernel.org Reply-To: hs@denx.de From: Heiko Schocher Message-ID: <561DD7D1.5040102@denx.de> Date: Wed, 14 Oct 2015 06:19:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20151013201703.GA3421@piout.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Alexandre, Am 13.10.2015 um 22:17 schrieb Alexandre Belloni: > Hi, > > On 13/10/2015 at 07:08:58 +0200, Heiko Schocher wrote : >> Disable the CLKOUT of the RTC after power-up. >> After power-up/reset of the RTC, CLKOUT is enabled by default, >> with CLKOUT enabled the RTC chip has 2-3 times higher power >> consumption. If you do not need CLKOUT, you can disable the >> CLKOUT with setting "disable-clkout" property. >> > > I think you can simply unconditionally disable clkout. My preferred way > of doing what you suggest is probably to register a clock in the CCF. If > the clock is not used, it will be automatically disabled. > It will also provide a generic way of setting the clkout frequency (some > RTC are able to output 32kHZ, 1kHz and 1Hz). Does disabling it ot break some boards? I take a look into CCF, good idea. bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-out.m-online.net (mail-out.m-online.net. [2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id bh7si829058wib.1.2015.10.13.21.19.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 13 Oct 2015 21:19:32 -0700 (PDT) Subject: [rtc-linux] Re: [PATCH] rtc: pcf8563: disable CLKOUT To: Alexandre Belloni References: <1444712938-22865-1-git-send-email-hs@denx.de> <20151013201703.GA3421@piout.net> Cc: linux-kernel@vger.kernel.org, Georg.Soffel@bosch-si.com, rtc-linux@googlegroups.com, Alessandro Zummo , devicetree@vger.kernel.org Reply-To: rtc-linux@googlegroups.com From: Heiko Schocher Message-ID: <561DD7D1.5040102@denx.de> Date: Wed, 14 Oct 2015 06:19:29 +0200 MIME-Version: 1.0 In-Reply-To: <20151013201703.GA3421@piout.net> Content-Type: text/plain; charset=UTF-8; format=flowed List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hello Alexandre, Am 13.10.2015 um 22:17 schrieb Alexandre Belloni: > Hi, > > On 13/10/2015 at 07:08:58 +0200, Heiko Schocher wrote : >> Disable the CLKOUT of the RTC after power-up. >> After power-up/reset of the RTC, CLKOUT is enabled by default, >> with CLKOUT enabled the RTC chip has 2-3 times higher power >> consumption. If you do not need CLKOUT, you can disable the >> CLKOUT with setting "disable-clkout" property. >> > > I think you can simply unconditionally disable clkout. My preferred way > of doing what you suggest is probably to register a clock in the CCF. If > the clock is not used, it will be automatically disabled. > It will also provide a generic way of setting the clkout frequency (some > RTC are able to output 32kHZ, 1kHz and 1Hz). Does disabling it ot break some boards? I take a look into CCF, good idea. bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Schocher Subject: Re: [PATCH] rtc: pcf8563: disable CLKOUT Date: Wed, 14 Oct 2015 06:19:29 +0200 Message-ID: <561DD7D1.5040102@denx.de> References: <1444712938-22865-1-git-send-email-hs@denx.de> <20151013201703.GA3421@piout.net> Reply-To: hs-ynQEQJNshbs@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20151013201703.GA3421-m++hUPXGwpdeoWH0uzbU5w@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alexandre Belloni Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Georg.Soffel-k21M0aUVSxZWk0Htik3J/w@public.gmane.org, rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Alessandro Zummo , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hello Alexandre, Am 13.10.2015 um 22:17 schrieb Alexandre Belloni: > Hi, > > On 13/10/2015 at 07:08:58 +0200, Heiko Schocher wrote : >> Disable the CLKOUT of the RTC after power-up. >> After power-up/reset of the RTC, CLKOUT is enabled by default, >> with CLKOUT enabled the RTC chip has 2-3 times higher power >> consumption. If you do not need CLKOUT, you can disable the >> CLKOUT with setting "disable-clkout" property. >> > > I think you can simply unconditionally disable clkout. My preferred way > of doing what you suggest is probably to register a clock in the CCF. If > the clock is not used, it will be automatically disabled. > It will also provide a generic way of setting the clkout frequency (some > RTC are able to output 32kHZ, 1kHz and 1Hz). Does disabling it ot break some boards? I take a look into CCF, good idea. bye, Heiko -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html