From: Or Gerlitz <ogerlitz@mellanox.com>
To: Majd Dibbiny <majd@mellanox.com>
Cc: <netdev@vger.kernel.org>, Eli Cohen <eli@mellanox.com>,
Amir Vadai <amirv@mellanox.com>
Subject: Re: [PATCH net-next 2/4] net/mlx5_core: Add pci error handlers to mlx5_core driver
Date: Wed, 14 Oct 2015 07:34:30 +0300 [thread overview]
Message-ID: <561DDB56.3020908@mellanox.com> (raw)
In-Reply-To: <201510140139.d9CDDacp%fengguang.wu@intel.com>
On 10/13/2015 8:04 PM, kbuild test robot wrote:
> Hi Majd,
>
> [auto build test WARNING on net-next/master -- if it's inappropriate base, please suggest rules for selecting the more suitable base]
>
> url: https://github.com/0day-ci/linux/commits/Or-Gerlitz/net-mlx5_core-Fix-internal-error-detection-conditions/20151013-234855
> reproduce:
> # apt-get install sparse
> make ARCH=x86_64 allmodconfig
> make C=1 CF=-D__CHECK_ENDIAN__
>
>
> sparse warnings: (new ones prefixed by >>)
Hi Majd,
Please address and push fix to Gerrit, IM me when this is ready.
Or.
>
>>> drivers/net/ethernet/mellanox/mlx5/core/cmd.c:1383:36: sparse: incorrect type in assignment (different base types)
> drivers/net/ethernet/mellanox/mlx5/core/cmd.c:1383:36: expected restricted __be32 [usertype] <noident>
> drivers/net/ethernet/mellanox/mlx5/core/cmd.c:1383:36: got unsigned int [unsigned] [addressable] [usertype] drv_synd
>
> vim +1383 drivers/net/ethernet/mellanox/mlx5/core/cmd.c
>
> 1367 }
> 1368
> 1369 static int cmd_exec(struct mlx5_core_dev *dev, void *in, int in_size, void *out,
> 1370 int out_size, mlx5_cmd_cbk_t callback, void *context)
> 1371 {
> 1372 struct mlx5_cmd_msg *inb;
> 1373 struct mlx5_cmd_msg *outb;
> 1374 int pages_queue;
> 1375 gfp_t gfp;
> 1376 int err;
> 1377 u8 status = 0;
> 1378 u32 drv_synd;
> 1379
> 1380 if (pci_channel_offline(dev->pdev) ||
> 1381 dev->state == MLX5_DEVICE_STATE_INTERNAL_ERROR) {
> 1382 err = mlx5_internal_err_ret_value(dev, opcode_from_in(in), &drv_synd, &status);
>> 1383 *get_synd_ptr(out) = drv_synd;
> 1384 *get_status_ptr(out) = status;
> 1385 return err;
> 1386 }
> 1387
>
next prev parent reply other threads:[~2015-10-14 4:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 15:44 [PATCH net-next 0/4] Mellanox driver update, Oct 13 2015 Or Gerlitz
2015-10-13 15:44 ` [PATCH net-next 1/4] net/mlx5_core: Fix internal error detection conditions Or Gerlitz
2015-10-14 2:46 ` David Miller
2015-10-14 14:47 ` Or Gerlitz
2015-10-13 15:44 ` [PATCH net-next 2/4] net/mlx5_core: Add pci error handlers to mlx5_core driver Or Gerlitz
2015-10-13 17:04 ` kbuild test robot
2015-10-14 4:34 ` Or Gerlitz [this message]
2015-10-13 15:44 ` [PATCH net-next 3/4] net/mlx5_core: Wait for FW readiness on startup Or Gerlitz
2015-10-13 15:44 ` [PATCH net-next 4/4] net/mlx4_core: Replace VF zero mac with random mac in mlx4_core Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561DDB56.3020908@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=amirv@mellanox.com \
--cc=eli@mellanox.com \
--cc=majd@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.