From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZmE0i-0006me-A8 for mharc-grub-devel@gnu.org; Wed, 14 Oct 2015 00:49:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48945) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmE06-0006le-0x for grub-devel@gnu.org; Wed, 14 Oct 2015 00:49:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmE02-0006vK-R4 for grub-devel@gnu.org; Wed, 14 Oct 2015 00:49:17 -0400 Received: from mail-lb0-x22c.google.com ([2a00:1450:4010:c04::22c]:32917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmE02-0006vG-Jw for grub-devel@gnu.org; Wed, 14 Oct 2015 00:49:14 -0400 Received: by lbbpp2 with SMTP id pp2so8605907lbb.0 for ; Tue, 13 Oct 2015 21:49:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=BcCOftrFO7pItiR7Amjjs8NnGUhYvvdDSFSgztLawcs=; b=vFV7/pAWUPvw2ObDzsN8swe9n/YHkRXug5JCk8kMQdO9PFzPNGO7LpooJUEfHjForA WHwikrQpHJhoi1ByotjEJPgHsYbTQutPa0ZxF5dh9pAzx3S+06u5jt3Z5f2CJt43fqVA 3E7vWUD3BPuGfQaMLQXRGoBSWGQGMZQSQ0EsNt5GzGH4lpddtd8ca9aDh2zUh1egeKz8 y/ZdTvOjffQoRjQLfSA+JR/7ZNNes8CQPLGw34JPbAAAMrC1ID6s7AhiU7dDVaGvevAS AABaE3X1wBFBULMPYeCVtVUtab6Mx7DwX/JvEboieCKINvq0ILxKOsPBMh36K9BqGUjL t/ZQ== X-Received: by 10.112.17.105 with SMTP id n9mr480738lbd.78.1444798153723; Tue, 13 Oct 2015 21:49:13 -0700 (PDT) Received: from [192.168.1.43] (ppp91-76-142-206.pppoe.mtu-net.ru. [91.76.142.206]) by smtp.gmail.com with ESMTPSA id g140sm1029221lfg.29.2015.10.13.21.49.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Oct 2015 21:49:12 -0700 (PDT) Subject: Re: [PATCH v2] Ensure that MIPS target code is compiled for the O32 ABI. To: grub-devel@gnu.org References: <1440009323-8667-1-git-send-email-mhw@netris.org> <55D6A36D.205@gmail.com> <876147ryhy.fsf@netris.org> <55D99791.4080104@gmail.com> <87a8thuqmo.fsf_-_@netris.org> <55EF16C0.6010703@gmail.com> <55F5186E.5040306@gmail.com> <56182E44.8010306@gmail.com> <56185BA0.6030006@gmail.com> From: Andrei Borzenkov Message-ID: <561DDEC7.2070703@gmail.com> Date: Wed, 14 Oct 2015 07:49:11 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <56185BA0.6030006@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::22c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2015 04:49:19 -0000 10.10.2015 03:28, Vladimir 'φ-coder/phcoder' Serbinenko пишет: > On 09.10.2015 23:14, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >> On 13.09.2015 08:32, Andrei Borzenkov wrote: >>> 08.09.2015 20:11, Vladimir 'φ-coder/phcoder' Serbinenko пишет: >>>> On 23.08.2015 23:50, Mark H Weaver wrote: >>>>> Include -mabi=32 in CFLAGS_PLATFORM and CCASFLAGS_PLATFORM to compile >>>>> code for the O32 ABI when targetting MIPS, since the MIPS assembly code >>>>> in GRUB assumes this. >>>> Could you be more precise where we assume this? Why not fix the assembly >>>> instead? >>> >>> If I understand it correctly, this is not only about assembly - ABIs >>> differ in sizes of types as well, >> Only in obscure types long double and uint128_t. We use neither. > Correction: I was comparing o32 to n32. We still need to ensure that > either o32 or n32 is used. It's easier to just ensure that o32 is used, > so that we have less variability in the code but can be relaxed later if > need be. I see that you committed my suggested patch but I find comments (and commit message) a bit misleading. While grub main code is fixed, the configure asm test not, and that was the first thing that failed. >> f) int grub_setjmp (grub_jmp_buf env) // grub_jmp_buf is an array, so >> pointer >> g) int grub_longjmp (grub_jmp_buf env, int val) > Correction: setjmp/longjmp are not adapted to n32 but we don't use them > anyway. Probably it's time to delete the dead code after double checking > that extras don't use it either. > > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >