From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751677AbbJNFD7 (ORCPT ); Wed, 14 Oct 2015 01:03:59 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:33100 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbbJNFD5 (ORCPT ); Wed, 14 Oct 2015 01:03:57 -0400 Subject: Re: [PATCH v3 3/7] arm64: ftrace: fix a stack tracer's output under function graph tracer To: Jungseok Lee References: <1444298504-10392-1-git-send-email-takahiro.akashi@linaro.org> <1444298504-10392-4-git-send-email-takahiro.akashi@linaro.org> Cc: catalin.marinas@arm.com, will.deacon@arm.com, rostedt@goodmis.org, olof@lixom.net, broonie@kernel.org, david.griego@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org From: AKASHI Takahiro Message-ID: <561DE236.7010703@linaro.org> Date: Wed, 14 Oct 2015 14:03:50 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/2015 12:24 AM, Jungseok Lee wrote: > On Oct 8, 2015, at 7:01 PM, AKASHI Takahiro wrote: > > Hi Akashi, > >> Function graph tracer modifies a return address (LR) in a stack frame >> to hook a function return. This will result in many useless entries >> (return_to_handler) showing up in a stack tracer's output. >> >> This patch replaces such entries with originals values preserved in >> current->ret_stack[]. >> >> Signed-off-by: AKASHI Takahiro > > The following diff should be folded into this patch, not [7/7] one, to > address build breakage. Thanks. I fixed all the build errors reported by kbuild test robot. -Takahiro AKASHI > ----8<---- > diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c > index 407991b..7126d4d 100644 > --- a/arch/arm64/kernel/stacktrace.c > +++ b/arch/arm64/kernel/stacktrace.c > @@ -17,6 +17,7 @@ > */ > #include > #include > +#include > #include > #include > ----8<---- > > Best Regards > Jungseok Lee > From mboxrd@z Thu Jan 1 00:00:00 1970 From: takahiro.akashi@linaro.org (AKASHI Takahiro) Date: Wed, 14 Oct 2015 14:03:50 +0900 Subject: [PATCH v3 3/7] arm64: ftrace: fix a stack tracer's output under function graph tracer In-Reply-To: References: <1444298504-10392-1-git-send-email-takahiro.akashi@linaro.org> <1444298504-10392-4-git-send-email-takahiro.akashi@linaro.org> Message-ID: <561DE236.7010703@linaro.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/14/2015 12:24 AM, Jungseok Lee wrote: > On Oct 8, 2015, at 7:01 PM, AKASHI Takahiro wrote: > > Hi Akashi, > >> Function graph tracer modifies a return address (LR) in a stack frame >> to hook a function return. This will result in many useless entries >> (return_to_handler) showing up in a stack tracer's output. >> >> This patch replaces such entries with originals values preserved in >> current->ret_stack[]. >> >> Signed-off-by: AKASHI Takahiro > > The following diff should be folded into this patch, not [7/7] one, to > address build breakage. Thanks. I fixed all the build errors reported by kbuild test robot. -Takahiro AKASHI > ----8<---- > diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c > index 407991b..7126d4d 100644 > --- a/arch/arm64/kernel/stacktrace.c > +++ b/arch/arm64/kernel/stacktrace.c > @@ -17,6 +17,7 @@ > */ > #include > #include > +#include > #include > #include > ----8<---- > > Best Regards > Jungseok Lee >