From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752688AbbJNISi (ORCPT ); Wed, 14 Oct 2015 04:18:38 -0400 Received: from lists.s-osg.org ([54.187.51.154]:52572 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752535AbbJNISb (ORCPT ); Wed, 14 Oct 2015 04:18:31 -0400 Subject: Re: [PATCH v5 0/17] Add Analogix Core Display Port Driver To: Yakir Yang , Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Heiko Stuebner , Mark Yao , Thierry Reding , joe@perches.com, Krzysztof Kozlowski , Rob Herring References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1442906428-2609-1-git-send-email-ykk@rock-chips.com> <5614BADD.1070307@rock-chips.com> <5614DBE2.6080102@osg.samsung.com> <5614DFBC.8060105@rock-chips.com> <5614E553.6060108@osg.samsung.com> <5614FC6B.4080702@rock-chips.com> <56150128.2070309@osg.samsung.com> <5615BB93.9020008@rock-chips.com> <56192135.2080608@rock-chips.com> <561CCD09.6020801@osg.samsung.com> <561D0C10.4060002@rock-chips.com> Cc: David Airlie , Russell King , djkurtz@chromium.org, dianders@chromium.org, Sean Paul , Kukjin Kim , Kumar Gala , emil.l.velikov@gmail.com, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , ajaynumb@gmail.com, robherring2@gmail.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Javier Martinez Canillas Message-ID: <561E0FC2.1070603@osg.samsung.com> Date: Wed, 14 Oct 2015 10:18:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <561D0C10.4060002@rock-chips.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Yakir, On 10/13/2015 03:50 PM, Yakir Yang wrote: > On 10/13/2015 05:21 PM, Javier Martinez Canillas wrote: > [snip] >>> And it's better to enable pstore function on mainline kernel, so we can analysis the last log when >>> the mainline kernel crashed. After enable PSTORE_RAM in .config, we still need add ramoops node >> Interesting, I knew about pstore but I never used it with the Exynos Chromebooks. >> >>> into file, like: >>> --- a/arch/arm/boot/dts/exynos5250.dtsi >>> +++ b/arch/arm/boot/dts/exynos5250.dtsi >>> @@ -750,6 +750,15 @@ >>> iommu = <&sysmmu_gsc3>; >>> }; >>> >>> + ramoops: ramoops { >>> + compatible = "ramoops"; >>> + name = "ramoops"; >>> + reg = <0x41f00000 0x100000>; >>> + record-size = <0x20000>; >>> + dump-oops; >>> + status = "okay"; >>> + }; >>> + >> Are you using mainline? There isn't a "ramoops" compatible string documented >> in the upstream DT bindings, platform_match() would match by driver name as >> a fallback but I don't see code in fs/pstore/ram.c that parses the properties >> in your device node. I wonder how this works for you or did I missunderstand? > > Aha, I lost some things that I back port the pstore/ram.c from chrome > v3.14 tree which driver would parsed the "ramoops" compatible. > Ah, that explains it then. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH v5 0/17] Add Analogix Core Display Port Driver Date: Wed, 14 Oct 2015 10:18:10 +0200 Message-ID: <561E0FC2.1070603@osg.samsung.com> References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1442906428-2609-1-git-send-email-ykk@rock-chips.com> <5614BADD.1070307@rock-chips.com> <5614DBE2.6080102@osg.samsung.com> <5614DFBC.8060105@rock-chips.com> <5614E553.6060108@osg.samsung.com> <5614FC6B.4080702@rock-chips.com> <56150128.2070309@osg.samsung.com> <5615BB93.9020008@rock-chips.com> <56192135.2080608@rock-chips.com> <561CCD09.6020801@osg.samsung.com> <561D0C10.4060002@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <561D0C10.4060002-TNX95d0MmH7DzftRWevZcw@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Yakir Yang , Inki Dae , Andrzej Hajda , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Jingoo Han , Heiko Stuebner , Mark Yao , Thierry Reding , joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org, Krzysztof Kozlowski , Rob Herring Cc: David Airlie , Russell King , djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, dianders-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org, Sean Paul , Kukjin Kim , Kumar Gala , emil.l.velikov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , Pawel Moll , ajaynumb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, robherring2-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, Andy Yan , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: devicetree@vger.kernel.org Hello Yakir, On 10/13/2015 03:50 PM, Yakir Yang wrote: > On 10/13/2015 05:21 PM, Javier Martinez Canillas wrote: > [snip] >>> And it's better to enable pstore function on mainline kernel, so we can analysis the last log when >>> the mainline kernel crashed. After enable PSTORE_RAM in .config, we still need add ramoops node >> Interesting, I knew about pstore but I never used it with the Exynos Chromebooks. >> >>> into file, like: >>> --- a/arch/arm/boot/dts/exynos5250.dtsi >>> +++ b/arch/arm/boot/dts/exynos5250.dtsi >>> @@ -750,6 +750,15 @@ >>> iommu = <&sysmmu_gsc3>; >>> }; >>> >>> + ramoops: ramoops { >>> + compatible = "ramoops"; >>> + name = "ramoops"; >>> + reg = <0x41f00000 0x100000>; >>> + record-size = <0x20000>; >>> + dump-oops; >>> + status = "okay"; >>> + }; >>> + >> Are you using mainline? There isn't a "ramoops" compatible string documented >> in the upstream DT bindings, platform_match() would match by driver name as >> a fallback but I don't see code in fs/pstore/ram.c that parses the properties >> in your device node. I wonder how this works for you or did I missunderstand? > > Aha, I lost some things that I back port the pstore/ram.c from chrome > v3.14 tree which driver would parsed the "ramoops" compatible. > Ah, that explains it then. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier@osg.samsung.com (Javier Martinez Canillas) Date: Wed, 14 Oct 2015 10:18:10 +0200 Subject: [PATCH v5 0/17] Add Analogix Core Display Port Driver In-Reply-To: <561D0C10.4060002@rock-chips.com> References: <1441086371-24838-1-git-send-email-ykk@rock-chips.com> <1442906428-2609-1-git-send-email-ykk@rock-chips.com> <5614BADD.1070307@rock-chips.com> <5614DBE2.6080102@osg.samsung.com> <5614DFBC.8060105@rock-chips.com> <5614E553.6060108@osg.samsung.com> <5614FC6B.4080702@rock-chips.com> <56150128.2070309@osg.samsung.com> <5615BB93.9020008@rock-chips.com> <56192135.2080608@rock-chips.com> <561CCD09.6020801@osg.samsung.com> <561D0C10.4060002@rock-chips.com> Message-ID: <561E0FC2.1070603@osg.samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Yakir, On 10/13/2015 03:50 PM, Yakir Yang wrote: > On 10/13/2015 05:21 PM, Javier Martinez Canillas wrote: > [snip] >>> And it's better to enable pstore function on mainline kernel, so we can analysis the last log when >>> the mainline kernel crashed. After enable PSTORE_RAM in .config, we still need add ramoops node >> Interesting, I knew about pstore but I never used it with the Exynos Chromebooks. >> >>> into file, like: >>> --- a/arch/arm/boot/dts/exynos5250.dtsi >>> +++ b/arch/arm/boot/dts/exynos5250.dtsi >>> @@ -750,6 +750,15 @@ >>> iommu = <&sysmmu_gsc3>; >>> }; >>> >>> + ramoops: ramoops { >>> + compatible = "ramoops"; >>> + name = "ramoops"; >>> + reg = <0x41f00000 0x100000>; >>> + record-size = <0x20000>; >>> + dump-oops; >>> + status = "okay"; >>> + }; >>> + >> Are you using mainline? There isn't a "ramoops" compatible string documented >> in the upstream DT bindings, platform_match() would match by driver name as >> a fallback but I don't see code in fs/pstore/ram.c that parses the properties >> in your device node. I wonder how this works for you or did I missunderstand? > > Aha, I lost some things that I back port the pstore/ram.c from chrome > v3.14 tree which driver would parsed the "ramoops" compatible. > Ah, that explains it then. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America