From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932112AbbJNLic (ORCPT ); Wed, 14 Oct 2015 07:38:32 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:50431 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752008AbbJNLia (ORCPT ); Wed, 14 Oct 2015 07:38:30 -0400 Subject: Re: [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts To: Roger Quadros References: <1444801956-17817-1-git-send-email-vigneshr@ti.com> <561E165B.3000907@ti.com> <561E1C89.9080508@ti.com> <561E36BB.7000309@ti.com> CC: Tony Lindgren , Dmitry Torokhov , Benoit Cousson , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , , , , , "Gerlach, Dave" From: Vignesh R Message-ID: <561E3E84.2000308@ti.com> Date: Wed, 14 Oct 2015 17:07:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <561E36BB.7000309@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/14/2015 04:34 PM, Roger Quadros wrote: > Vignesh, > > On 14/10/15 12:12, Vignesh R wrote: >> >> >> On 10/14/2015 02:16 PM, Roger Quadros wrote: >> >>> >>> On 14/10/15 08:52, Vignesh R wrote: >>>> On am437x-gp-evm, pixcir_i2c_ts can wakeup the system from lower power >>>> state via pinctrl and IO daisy chain using generic wakeirq framework. >>>> With commit 3fffd1283927 ("i2c: allow specifying separate wakeup >>>> interrupt in device tree") i2c core allows optional wakeirq to be >>>> specified via device tree. Add wakeup irq entry to enable pixcir_i2c_ts >>>> to wake the system from low power state. >>>> >>>> Signed-off-by: Vignesh R >>>> --- >>>> arch/arm/boot/dts/am437x-gp-evm.dts | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts >>>> index 22038f21f228..69e93af7df0d 100644 >>>> --- a/arch/arm/boot/dts/am437x-gp-evm.dts >>>> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts >>>> @@ -581,8 +581,13 @@ >>>> >>>> attb-gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>; >>>> >>>> + interrupts-extended = <&gpio3 22 GPIO_ACTIVE_HIGH>, >>>> + <&am43xx_pinmux 0x264>; >>> >>> How does this work? >>> >>> interrupts-extended property must have >>> 1) interrupt parent >>> 2) interrupt number >>> 3) interrupt flags >>> >>> Your change doesn't seem to comply with those requirements. >> >> AFAIU, interrupts-extended has two parts: interrupt parent phandle and >> interrupt specifier. >> The number of cells in interrupt specifier is determined by >> interrupt-cells property of interrupt parent node. > > Got it. > >> In above case, gpio3 has interrupt-cells = 2 hence interrupt specifier >> has interrupt number and interrupt flag field. > > But is GPIO_ACTIVE_HIGH an interrupt flag? Oops.. I will change it to IRQ_TYPE_NONE as represented in interrupts property. > >> But in case am43xx_pinmux node, interrupt-cells is 1 hence has no >> interrupt flag field. >> > Understood, thanks. Might be worth adding a comment as to what 0x264 means though. > Will add a one line comment indicating its the offset of gpio3_22 padconf register from am43xx_pinmux base. > cheers, > -roger > -- Regards Vignesh From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vignesh R Subject: Re: [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts Date: Wed, 14 Oct 2015 17:07:40 +0530 Message-ID: <561E3E84.2000308@ti.com> References: <1444801956-17817-1-git-send-email-vigneshr@ti.com> <561E165B.3000907@ti.com> <561E1C89.9080508@ti.com> <561E36BB.7000309@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <561E36BB.7000309-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Roger Quadros Cc: Tony Lindgren , Dmitry Torokhov , Benoit Cousson , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "Gerlach, Dave" List-Id: devicetree@vger.kernel.org On 10/14/2015 04:34 PM, Roger Quadros wrote: > Vignesh, > > On 14/10/15 12:12, Vignesh R wrote: >> >> >> On 10/14/2015 02:16 PM, Roger Quadros wrote: >> >>> >>> On 14/10/15 08:52, Vignesh R wrote: >>>> On am437x-gp-evm, pixcir_i2c_ts can wakeup the system from lower power >>>> state via pinctrl and IO daisy chain using generic wakeirq framework. >>>> With commit 3fffd1283927 ("i2c: allow specifying separate wakeup >>>> interrupt in device tree") i2c core allows optional wakeirq to be >>>> specified via device tree. Add wakeup irq entry to enable pixcir_i2c_ts >>>> to wake the system from low power state. >>>> >>>> Signed-off-by: Vignesh R >>>> --- >>>> arch/arm/boot/dts/am437x-gp-evm.dts | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts >>>> index 22038f21f228..69e93af7df0d 100644 >>>> --- a/arch/arm/boot/dts/am437x-gp-evm.dts >>>> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts >>>> @@ -581,8 +581,13 @@ >>>> >>>> attb-gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>; >>>> >>>> + interrupts-extended = <&gpio3 22 GPIO_ACTIVE_HIGH>, >>>> + <&am43xx_pinmux 0x264>; >>> >>> How does this work? >>> >>> interrupts-extended property must have >>> 1) interrupt parent >>> 2) interrupt number >>> 3) interrupt flags >>> >>> Your change doesn't seem to comply with those requirements. >> >> AFAIU, interrupts-extended has two parts: interrupt parent phandle and >> interrupt specifier. >> The number of cells in interrupt specifier is determined by >> interrupt-cells property of interrupt parent node. > > Got it. > >> In above case, gpio3 has interrupt-cells = 2 hence interrupt specifier >> has interrupt number and interrupt flag field. > > But is GPIO_ACTIVE_HIGH an interrupt flag? Oops.. I will change it to IRQ_TYPE_NONE as represented in interrupts property. > >> But in case am43xx_pinmux node, interrupt-cells is 1 hence has no >> interrupt flag field. >> > Understood, thanks. Might be worth adding a comment as to what 0x264 means though. > Will add a one line comment indicating its the offset of gpio3_22 padconf register from am43xx_pinmux base. > cheers, > -roger > -- Regards Vignesh -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: vigneshr@ti.com (Vignesh R) Date: Wed, 14 Oct 2015 17:07:40 +0530 Subject: [PATCH] ARM: dts: am437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_ts In-Reply-To: <561E36BB.7000309@ti.com> References: <1444801956-17817-1-git-send-email-vigneshr@ti.com> <561E165B.3000907@ti.com> <561E1C89.9080508@ti.com> <561E36BB.7000309@ti.com> Message-ID: <561E3E84.2000308@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10/14/2015 04:34 PM, Roger Quadros wrote: > Vignesh, > > On 14/10/15 12:12, Vignesh R wrote: >> >> >> On 10/14/2015 02:16 PM, Roger Quadros wrote: >> >>> >>> On 14/10/15 08:52, Vignesh R wrote: >>>> On am437x-gp-evm, pixcir_i2c_ts can wakeup the system from lower power >>>> state via pinctrl and IO daisy chain using generic wakeirq framework. >>>> With commit 3fffd1283927 ("i2c: allow specifying separate wakeup >>>> interrupt in device tree") i2c core allows optional wakeirq to be >>>> specified via device tree. Add wakeup irq entry to enable pixcir_i2c_ts >>>> to wake the system from low power state. >>>> >>>> Signed-off-by: Vignesh R >>>> --- >>>> arch/arm/boot/dts/am437x-gp-evm.dts | 5 +++++ >>>> 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/am437x-gp-evm.dts b/arch/arm/boot/dts/am437x-gp-evm.dts >>>> index 22038f21f228..69e93af7df0d 100644 >>>> --- a/arch/arm/boot/dts/am437x-gp-evm.dts >>>> +++ b/arch/arm/boot/dts/am437x-gp-evm.dts >>>> @@ -581,8 +581,13 @@ >>>> >>>> attb-gpio = <&gpio3 22 GPIO_ACTIVE_HIGH>; >>>> >>>> + interrupts-extended = <&gpio3 22 GPIO_ACTIVE_HIGH>, >>>> + <&am43xx_pinmux 0x264>; >>> >>> How does this work? >>> >>> interrupts-extended property must have >>> 1) interrupt parent >>> 2) interrupt number >>> 3) interrupt flags >>> >>> Your change doesn't seem to comply with those requirements. >> >> AFAIU, interrupts-extended has two parts: interrupt parent phandle and >> interrupt specifier. >> The number of cells in interrupt specifier is determined by >> interrupt-cells property of interrupt parent node. > > Got it. > >> In above case, gpio3 has interrupt-cells = 2 hence interrupt specifier >> has interrupt number and interrupt flag field. > > But is GPIO_ACTIVE_HIGH an interrupt flag? Oops.. I will change it to IRQ_TYPE_NONE as represented in interrupts property. > >> But in case am43xx_pinmux node, interrupt-cells is 1 hence has no >> interrupt flag field. >> > Understood, thanks. Might be worth adding a comment as to what 0x264 means though. > Will add a one line comment indicating its the offset of gpio3_22 padconf register from am43xx_pinmux base. > cheers, > -roger > -- Regards Vignesh