From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmLd1-0001WP-Jr for qemu-devel@nongnu.org; Wed, 14 Oct 2015 08:58:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmLcx-0004Vk-0X for qemu-devel@nongnu.org; Wed, 14 Oct 2015 08:57:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmLcw-0004Ve-RY for qemu-devel@nongnu.org; Wed, 14 Oct 2015 08:57:54 -0400 References: <1444710158-8723-1-git-send-email-eblake@redhat.com> <1444710158-8723-9-git-send-email-eblake@redhat.com> <87y4f59azz.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <561E514C.9030404@redhat.com> Date: Wed, 14 Oct 2015 06:57:48 -0600 MIME-Version: 1.0 In-Reply-To: <87y4f59azz.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oxj8IJRLnF8tumCbuEaF4X10fmbPHf2gC" Subject: Re: [Qemu-devel] [PATCH v8 08/18] qapi: Lazy creation of array types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --oxj8IJRLnF8tumCbuEaF4X10fmbPHf2gC Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/14/2015 01:15 AM, Markus Armbruster wrote: > Eric Blake writes: >=20 >> Commit ac88219a had several TODO markers about whether we needed >> to automatically create the corresponding array type alongside >> any other type. It turns out that most of the time, we don't! >> >> As part of lazy creation of array types, this patch now assigns >> an 'info' to array types at their point of first instantiation, >> rather than leaving it None. >=20 > I'm afraid this flips the value of .is_implicit() to False. Currently > harmless, but let's keep it correct anyway. >=20 > The obvious fix is to define the trivial override method: >=20 > def is_implicit(self): > return True >=20 > But I'd rather do *all* the "give implicit types info" work in "qapi: > Track location that created an implicit type", i.e. move the plumbing o= f > info there, add the override method there, drop the "As part of" > paragraph from the commit message here. I append what's left of this > patch then. I like it, because the patch that actually changes > generated code (this one) becomes really simple, and the lengthened > patch remains mere info-plumbing that doesn't affect the generated code= =2E Makes sense, so I agree with how you've redone the current state of qapi-next. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --oxj8IJRLnF8tumCbuEaF4X10fmbPHf2gC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWHlFMAAoJEKeha0olJ0Nqby8H+wRpe9xf0AajghmDPDDGPZC3 YVtWt9ovavjo/XmvAxJHj9xcJ7wctpm9RbP5DrdQ4K5djH5mmIBce20WtLkkIifj oSdrD7+8dKNz/Npkd3ZHRL5ene73OX0CkGj/MWRgska1Y3+NgSajDyUjO2L1Oodv FPcsD6YV2tyFwmBOS/5JufeS4lDj13xH89TggPQFH/OmqBGn6bXXD804K/6Ialdx QU7bnzr4+ua1sVymV5OKZJOlkA188k0wnnp0ANkn3I/1n3aZOcQ1cfm0fr/pRizf 7aiMlzFd0gLMrj/IUPr/LXDwC5ZYOW2BfSrvRTnjlpDYXbCLDI+fYMOJIKehuUI= =gOQA -----END PGP SIGNATURE----- --oxj8IJRLnF8tumCbuEaF4X10fmbPHf2gC--