From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmLeQ-0002CS-GI for qemu-devel@nongnu.org; Wed, 14 Oct 2015 08:59:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmLeM-0004eF-As for qemu-devel@nongnu.org; Wed, 14 Oct 2015 08:59:26 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49400) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmLeM-0004e8-4F for qemu-devel@nongnu.org; Wed, 14 Oct 2015 08:59:22 -0400 References: <1444710158-8723-1-git-send-email-eblake@redhat.com> <1444710158-8723-16-git-send-email-eblake@redhat.com> <87zizm6c67.fsf@blackfin.pond.sub.org> <561D24CA.7030804@redhat.com> <87mvvmvghf.fsf@blackfin.pond.sub.org> <561D42C3.1050207@redhat.com> <87wpuqmxex.fsf@blackfin.pond.sub.org> <87io697vmm.fsf@blackfin.pond.sub.org> From: Eric Blake Message-ID: <561E51A9.9060307@redhat.com> Date: Wed, 14 Oct 2015 06:59:21 -0600 MIME-Version: 1.0 In-Reply-To: <87io697vmm.fsf@blackfin.pond.sub.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="h4hCJ0xq3nSSFD5mGHsVNN9UUkeFmosGq" Subject: Re: [Qemu-devel] [PATCH v8 15/18] qapi: Move duplicate member checks to schema check() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: qemu-devel@nongnu.org, Michael Roth This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --h4hCJ0xq3nSSFD5mGHsVNN9UUkeFmosGq Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/14/2015 01:32 AM, Markus Armbruster wrote: >> Done & pushed to http://repo.or.cz/qemu/armbru.git branch qapi-next. >=20 > Redone & pushed. >=20 > Summary of tweaks: > * PATCH 01-06.5: unchanged > * PATCH 07: your fixup to drop is_implicit() squashed in > * PATCH 08: array info plumbing moved to PATCH 12 > * PATCH 09: trivially rebased > * PATCH 12: revert your fixup, so we get the move we want, adjust commi= t > message accordingly, supply missing QAPISchemaArrayType.is_implicit()= You may also want to squash this into 12: diff --git a/scripts/qapi.py b/scripts/qapi.py index fd95864..1e01714 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -792,10 +792,9 @@ class QAPISchemaEntity(object): self.name =3D name # For explicitly defined entities, info points to the (explicit)= # definition. For builtins (and their arrays), info is None. - # For other arrays, info points to an explicit place that uses - # the array (there may be more than one such place). For other - # implicitly defined entities, it points to the place that - # triggered the implicit definition. + # For implicitly defined entities, info points to a place that + # triggered the implicit definition (there may be more than one + # such place). self.info =3D info def c_name(self): --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --h4hCJ0xq3nSSFD5mGHsVNN9UUkeFmosGq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWHlGpAAoJEKeha0olJ0NqMIMIAJQvwW5tzz3BgNyrrYJ7lEbR CbjVjdkv25qxXqtqrDRqzMyinuqc1wOJFCn15MHMEyt0GR8r2kXgCfCqIyMJb90q xj+W2mj5hSq9nod2Gzl7ZE1m2fS2rpCuCjqTdb9XQVBY5qSbUb2x/MPgZWLlGUZj 4NeK1aP2UpOYf3n8oJeAEHSIeB2TC/xBdsFrAR0s5cHNBboi2LZ3EvzgchKnEZsI EBE8Q8jbA3nHb0l97L7vgUJl+UeR+0NuMH2p2ELn27SK1qR4lLRoO2zobcxQLWKJ iwKY+yt3bCQbLinfInYRuA3Ba3xbD9WB6RDZrp6skFbWdaRCNeP/CUNv+oa0rF4= =xMpC -----END PGP SIGNATURE----- --h4hCJ0xq3nSSFD5mGHsVNN9UUkeFmosGq--