From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Zmqd9-0007AP-HT for mharc-grub-devel@gnu.org; Thu, 15 Oct 2015 18:04:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36095) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmQJP-0001gr-Uq for grub-devel@gnu.org; Wed, 14 Oct 2015 13:58:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZmQJK-0005iS-Tj for grub-devel@gnu.org; Wed, 14 Oct 2015 13:58:03 -0400 Received: from mail-lf0-x233.google.com ([2a00:1450:4010:c07::233]:35357) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZmQJK-0005i8-LJ for grub-devel@gnu.org; Wed, 14 Oct 2015 13:57:58 -0400 Received: by lffy185 with SMTP id y185so16435551lff.2 for ; Wed, 14 Oct 2015 10:57:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=KfgNgNERNSkOxMCS08R3NLR64MftjWu/f1wErWW+D0E=; b=DTI1K/8cSUEXritjVF+yhc0+AXIukxvCNN5IrnUDwavMq3wljdcVZZbPLkdtMRbE5r FS3LyWi625LoeAs3TMV4R7JnIEVjaOfzDTmhE2kuif8Ja3kHowf+oR1Db9NIXHcsoSUn C3fEImQfAqPZCFtPDQ0kOjTjq0wnUs+zVGffQeRKnoJYTUItkClxLOHbh3m+WTkHr4kM YEHA+OUw3WjSeA6JV2lXtF5CqLXbyRdTfdKDE8NY5AwM3bPY4EftH8EozmPt8qY8gCvM GzaWBS2HzK8PWO2Wt8lVUovh49WQBxri29ADa8B+NUPmr1lxc2dqgYeQYWWwpJGM8j7C 6F7Q== X-Received: by 10.25.146.193 with SMTP id u184mr1538897lfd.50.1444845477217; Wed, 14 Oct 2015 10:57:57 -0700 (PDT) Received: from [192.168.1.43] (ppp91-76-142-206.pppoe.mtu-net.ru. [91.76.142.206]) by smtp.gmail.com with ESMTPSA id i9sm1502425lfb.18.2015.10.14.10.57.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Oct 2015 10:57:56 -0700 (PDT) Subject: Re: [PATCH v2] Ensure that MIPS target code is compiled for the O32 ABI. To: grub-devel@gnu.org References: <1440009323-8667-1-git-send-email-mhw@netris.org> <55D6A36D.205@gmail.com> <876147ryhy.fsf@netris.org> <55D99791.4080104@gmail.com> <87a8thuqmo.fsf_-_@netris.org> <55EF16C0.6010703@gmail.com> <55F5186E.5040306@gmail.com> <56182E44.8010306@gmail.com> <56185BA0.6030006@gmail.com> <561DDEC7.2070703@gmail.com> From: Andrei Borzenkov Message-ID: <561E97A3.5060102@gmail.com> Date: Wed, 14 Oct 2015 20:57:55 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c07::233 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2015 17:58:05 -0000 14.10.2015 15:16, Vladimir 'phcoder' Serbinenko пишет: > Le 14 oct. 2015 6:50 AM, "Andrei Borzenkov" a écrit : >> >> 10.10.2015 03:28, Vladimir 'φ-coder/phcoder' Serbinenko пишет: >> >>> On 09.10.2015 23:14, Vladimir 'φ-coder/phcoder' Serbinenko wrote: >>>> >>>> On 13.09.2015 08:32, Andrei Borzenkov wrote: >>>>> >>>>> 08.09.2015 20:11, Vladimir 'φ-coder/phcoder' Serbinenko пишет: >>>>>> >>>>>> On 23.08.2015 23:50, Mark H Weaver wrote: >>>>>>> >>>>>>> Include -mabi=32 in CFLAGS_PLATFORM and CCASFLAGS_PLATFORM to compile >>>>>>> code for the O32 ABI when targetting MIPS, since the MIPS assembly > code >>>>>>> in GRUB assumes this. >>>>>> >>>>>> Could you be more precise where we assume this? Why not fix the > assembly >>>>>> instead? >>>>> >>>>> >>>>> If I understand it correctly, this is not only about assembly - ABIs >>>>> differ in sizes of types as well, >>>> >>>> Only in obscure types long double and uint128_t. We use neither. >>> >>> Correction: I was comparing o32 to n32. We still need to ensure that >>> either o32 or n32 is used. It's easier to just ensure that o32 is used, >>> so that we have less variability in the code but can be relaxed later if >>> need be. >> >> >> I see that you committed my suggested patch but I find comments (and > commit message) a bit misleading. While grub main code is fixed, the > configure asm test not, and that was the first thing that failed. >> > Can you please elaborate on how am test fails? The only failure I have seen > was due to usage of $t4 and I replaced it with $t0 Sorry, missed patch for asm-tests/mips.S >>>> f) int grub_setjmp (grub_jmp_buf env) // grub_jmp_buf is an array, so >>>> pointer >>>> g) int grub_longjmp (grub_jmp_buf env, int val) >>> >>> Correction: setjmp/longjmp are not adapted to n32 but we don't use them >>> anyway. Probably it's time to delete the dead code after double checking >>> that extras don't use it either. >>> >>> >>> >>> >>> _______________________________________________ >>> Grub-devel mailing list >>> Grub-devel@gnu.org >>> https://lists.gnu.org/mailman/listinfo/grub-devel >>> >> >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel > > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel >