From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tetsuya Mukawa <mukawa@igel.co.jp>
Subject: Re: [PATCH v5 4/9] null: virtual dynamic rss
	configuration
Date: Thu, 15 Oct 2015 16:46:16 +0900
Message-ID: <561F59C8.1070105@igel.co.jp>
References: <1436981189-3320-1-git-send-email-tomaszx.kulasek@intel.com>
 <1443621905-7872-1-git-send-email-tomaszx.kulasek@intel.com>
 <1443621905-7872-5-git-send-email-tomaszx.kulasek@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-2022-jp
Content-Transfer-Encoding: 7bit
To: Tomasz Kulasek <tomaszx.kulasek@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-pa0-f50.google.com (mail-pa0-f50.google.com
 [209.85.220.50]) by dpdk.org (Postfix) with ESMTP id 902978E90
 for <dev@dpdk.org>; Thu, 15 Oct 2015 09:46:20 +0200 (CEST)
Received: by payp3 with SMTP id p3so32147460pay.1
 for <dev@dpdk.org>; Thu, 15 Oct 2015 00:46:19 -0700 (PDT)
In-Reply-To: <1443621905-7872-5-git-send-email-tomaszx.kulasek@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 2015/09/30 23:05, Tomasz Kulasek wrote:
> This implementation allows to set and read RSS configuration for null
> device, and is used to validate right values propagation over the slaves,
> in test units for dynamic RSS configuration for bonding.
>
> v5 changes:
>  - replaced memcpy with rte_memcpy
>
> Signed-off-by: Tomasz Kulasek <tomaszx.kulasek@intel.com>
> ---
>  drivers/net/null/rte_eth_null.c |  116 +++++++++++++++++++++++++++++++++++++++
>  1 file changed, 116 insertions(+)
>
> diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c
> index bf81b1b..b01f647 100644
> --- a/drivers/net/null/rte_eth_null.c
> +++ b/drivers/net/null/rte_eth_null.c
> @@ -37,6 +37,8 @@
>  #include <rte_memcpy.h>
>  #include <rte_dev.h>
>  #include <rte_kvargs.h>
> +#include <rte_eth_null.h>
> +#include <rte_spinlock.h>
>  
>


Hi Tomasz,

We don't have "rte_eth_null.h" at this point.
(The header file will be added next patch)
Probably, we also need "rte_pmd_null_version.map" to compile correctly.
(To make sure, please compile DPDK with "CONFIG_RTE_BUILD_SHARED_LIB=y"
option.)

Also, it seems 'rte_eth_null.h' should be included like below.
#include "rte_eth_null.h"
Without it, we cannot compile.

Thanks,
Tetsuya