From mboxrd@z Thu Jan  1 00:00:00 1970
From: Hemant Agrawal <hemant.agrawal@nxp.com>
Subject: Re: [PATCH 18/32] net/dpaa2: introducing dpaa2 pmd driver
Date: Wed, 7 Dec 2016 15:25:25 +0530
Message-ID: <561c4838-4d8b-cdb4-f1eb-83b4092df5ab@nxp.com>
References: <1480875447-23680-1-git-send-email-hemant.agrawal@nxp.com>
 <1480875447-23680-19-git-send-email-hemant.agrawal@nxp.com>
 <2023a9a6-f342-8986-7ded-3703b3623a70@intel.com> <2956951.cEfl6HOu1U@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <bruce.richardson@intel.com>, <shreyansh.jain@nxp.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>, Ferruh Yigit
 <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-BY2-obe.outbound.protection.outlook.com
 (mail-by2nam03on0088.outbound.protection.outlook.com [104.47.42.88])
 by dpdk.org (Postfix) with ESMTP id D6F5B2BA8
 for <dev@dpdk.org>; Wed,  7 Dec 2016 10:55:32 +0100 (CET)
In-Reply-To: <2956951.cEfl6HOu1U@xps13>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 12/7/2016 2:38 AM, Thomas Monjalon wrote:
> 2016-12-06 19:49, Ferruh Yigit:
>> On 12/4/2016 6:17 PM, Hemant Agrawal wrote:
>>> +	if (rte_eal_process_type() == RTE_PROC_PRIMARY) {
>>> +		eth_dev->data->dev_private = rte_zmalloc(
>>> +						"ethdev private structure",
>>> +						eth_drv->dev_private_size,
>>> +						RTE_CACHE_LINE_SIZE);
>>> +		if (eth_dev->data->dev_private == NULL)
>>> +			rte_panic("Cannot allocate memzone for private port"
>>> +				  " data\n");
>>
>> Should this error kill all app, or return an error for this PMD that is
>> probed.
>
> It cannot be a question :)
> rte_panic() inside libs or drivers is forbidden (and existing ones must
> be removed).
>
I will change it to return an error.