From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42602) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZotuR-0003Eb-U3 for qemu-devel@nongnu.org; Wed, 21 Oct 2015 09:58:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZotuO-0003kc-O3 for qemu-devel@nongnu.org; Wed, 21 Oct 2015 09:58:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34077) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZotuO-0003kX-J8 for qemu-devel@nongnu.org; Wed, 21 Oct 2015 09:58:28 -0400 References: <1445434451-3439-1-git-send-email-prasanna.kalever@redhat.com> From: Eric Blake Message-ID: <56279A02.8060604@redhat.com> Date: Wed, 21 Oct 2015 07:58:26 -0600 MIME-Version: 1.0 In-Reply-To: <1445434451-3439-1-git-send-email-prasanna.kalever@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Rts0G6dkJlcRBTG220csQG39qeiFmexbw" Subject: Re: [Qemu-devel] [PATCH v2 1/3] block/gluster: rename [server, volname, image] -> [host, volume, path] List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Prasanna Kumar Kalever , qemu-devel@nongnu.org Cc: kwolf@redhat.com, pkrempa@redhat.com, stefanha@gmail.com, deepakcs@redhat.com, bharata@linux.vnet.ibm.com, rtalur@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Rts0G6dkJlcRBTG220csQG39qeiFmexbw Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10/21/2015 07:34 AM, Prasanna Kumar Kalever wrote: Missing a 0/3 cover letter; you may want to do: git config format.coverLetter auto so that you don't forget it next time. > it will be quite messy to have colliding names for variables, so to mai= ntain > better readability and make it consistent with other existing code as w= ell as > the input keys/options which will be introduced by next couple of patch= es, this > patch renames the following variables > 'server' -> 'host' > 'image' -> 'path' > 'volname' -> 'volume' >=20 > Signed-off-by: Prasanna Kumar Kalever > --- > block/gluster.c | 54 +++++++++++++++++++++++++++----------------------= ----- > 1 file changed, 27 insertions(+), 27 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Rts0G6dkJlcRBTG220csQG39qeiFmexbw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWJ5oCAAoJEKeha0olJ0NqKlUH/0SwaJpc6RmsGM/tNkRVEaYH JqXMSjANbk8klksWEAIElu88hNbnixTggJW1D72JsR8WMLN35XXLbWwCPe6k5QJ0 W32IgWO1zCyhTpwWMhj5RXHZlklPeCT+3iJ6nATx15r2Vr3SLZerdVSm37SMMJN9 b1TKyXONWXfuUweg/4gdveak1MifRH1p0diHhaIx2mqF+Ixk9izVYei2Y+A9eoDB dHOSfqH8+YC96VKN28+NF1SBN1/m9/Wt3QJkQzJFtm08Gl9jrgTYGnerIdWQzbOL 8tYKaVgwggb9vO8Lq0uc747c6SzGxpv7k4nU4cRuWDT3/YjGrvK2Sik9fWmmYeo= =99+L -----END PGP SIGNATURE----- --Rts0G6dkJlcRBTG220csQG39qeiFmexbw--