From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH v2 7/8] drm/i915: Grab execlist spinlock to avoid post-reset concurrency issues. Date: Fri, 23 Oct 2015 09:42:27 +0100 Message-ID: <5629F2F3.2000308@linux.intel.com> References: <1444329100-19189-8-git-send-email-tomas.elf@intel.com> <1445268752-19155-1-git-send-email-tomas.elf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 232B56E07D for ; Fri, 23 Oct 2015 01:42:29 -0700 (PDT) In-Reply-To: <1445268752-19155-1-git-send-email-tomas.elf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tomas Elf , Intel-GFX@Lists.FreeDesktop.Org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE5LzEwLzE1IDE2OjMyLCBUb21hcyBFbGYgd3JvdGU6Cj4gR3JhYiBleGVjbGlzdCBsb2Nr IHdoZW4gY2xlYW5pbmcgdXAgZXhlY2xpc3QgcXVldWVzIGFmdGVyIEdQVSByZXNldCB0byBhdm9p ZAo+IGNvbmN1cnJlbmN5IHByb2JsZW1zIGJldHdlZW4gdGhlIGNvbnRleHQgZXZlbnQgaW50ZXJy dXB0IGhhbmRsZXIgYW5kIHRoZSByZXNldAo+IHBhdGggaW1tZWRpYXRlbHkgZm9sbG93aW5nIGEg R1BVIHJlc2V0Lgo+Cj4gKiB2MiAoQ2hyaXMgV2lsc29uKToKPiBEbyBleGVjbGlzdCBjaGVjayBh bmQgdXNlIHNpbXBsZXIgZm9ybSBvZiBzcGlubG9jayBmdW5jdGlvbnMuCj4KPiBTaWduZWQtb2Zm LWJ5OiBUb21hcyBFbGYgPHRvbWFzLmVsZkBpbnRlbC5jb20+Cj4gLS0tCj4gICBkcml2ZXJzL2dw dS9kcm0vaTkxNS9pOTE1X2dlbS5jIHwgMjMgKysrKysrKysrKysrKystLS0tLS0tLS0KPiAgIDEg ZmlsZSBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCA5IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pOTE1X2dlbS5jCj4gaW5kZXggZTU3MDYxYS4uMmM3YTBiNyAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW0uYwo+IEBAIC0yNzUzLDE4ICsyNzUzLDIzIEBAIHN0YXRpYyB2b2lkIGk5MTVf Z2VtX3Jlc2V0X3JpbmdfY2xlYW51cChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYs Cj4gICAJICogYXJlIHRoZSBvbmVzIHRoYXQga2VlcCB0aGUgY29udGV4dCBhbmQgcmluZ2J1ZmZl ciBiYWNraW5nIG9iamVjdHMKPiAgIAkgKiBwaW5uZWQgaW4gcGxhY2UuCj4gICAJICovCj4gLQl3 aGlsZSAoIWxpc3RfZW1wdHkoJnJpbmctPmV4ZWNsaXN0X3F1ZXVlKSkgewo+IC0JCXN0cnVjdCBk cm1faTkxNV9nZW1fcmVxdWVzdCAqc3VibWl0X3JlcTsKPgo+IC0JCXN1Ym1pdF9yZXEgPSBsaXN0 X2ZpcnN0X2VudHJ5KCZyaW5nLT5leGVjbGlzdF9xdWV1ZSwKPiAtCQkJCXN0cnVjdCBkcm1faTkx NV9nZW1fcmVxdWVzdCwKPiAtCQkJCWV4ZWNsaXN0X2xpbmspOwo+IC0JCWxpc3RfZGVsKCZzdWJt aXRfcmVxLT5leGVjbGlzdF9saW5rKTsKPiArCWlmIChpOTE1LmVuYWJsZV9leGVjbGlzdHMpIHsK PiArCQlzcGluX2xvY2tfaXJxKCZyaW5nLT5leGVjbGlzdF9sb2NrKTsKPiArCQl3aGlsZSAoIWxp c3RfZW1wdHkoJnJpbmctPmV4ZWNsaXN0X3F1ZXVlKSkgewo+ICsJCQlzdHJ1Y3QgZHJtX2k5MTVf Z2VtX3JlcXVlc3QgKnN1Ym1pdF9yZXE7Cj4KPiAtCQlpZiAoc3VibWl0X3JlcS0+Y3R4ICE9IHJp bmctPmRlZmF1bHRfY29udGV4dCkKPiAtCQkJaW50ZWxfbHJfY29udGV4dF91bnBpbihzdWJtaXRf cmVxKTsKPiArCQkJc3VibWl0X3JlcSA9IGxpc3RfZmlyc3RfZW50cnkoJnJpbmctPmV4ZWNsaXN0 X3F1ZXVlLAo+ICsJCQkJCXN0cnVjdCBkcm1faTkxNV9nZW1fcmVxdWVzdCwKPiArCQkJCQlleGVj bGlzdF9saW5rKTsKPiArCQkJbGlzdF9kZWwoJnN1Ym1pdF9yZXEtPmV4ZWNsaXN0X2xpbmspOwo+ Cj4gLQkJaTkxNV9nZW1fcmVxdWVzdF91bnJlZmVyZW5jZShzdWJtaXRfcmVxKTsKPiArCQkJaWYg KHN1Ym1pdF9yZXEtPmN0eCAhPSByaW5nLT5kZWZhdWx0X2NvbnRleHQpCj4gKwkJCQlpbnRlbF9s cl9jb250ZXh0X3VucGluKHN1Ym1pdF9yZXEpOwo+ICsKPiArCQkJaTkxNV9nZW1fcmVxdWVzdF91 bnJlZmVyZW5jZShzdWJtaXRfcmVxKTsKPiArCQl9Cj4gKwkJc3Bpbl91bmxvY2tfaXJxKCZyaW5n LT5leGVjbGlzdF9sb2NrKTsKCkNhbid0IHRoaXMsIGluIHRoZW9yeSBhdCBsZWFzdCwgZW5kIHVw IGNhbGxpbmcgCmRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlIGluIGEgY291cGxlIG9mIGNvZGUg cGF0aHMsIHdoaWNoIGNhbiBzbGVlcCwgCndoaWxlIGhvbGRpbmcgYSBzcGlubG9jaz8KCklmIHRo aXMgY2Fubm90IGhhcHBlbiBpbiBwcmFjdGljZSBmb3Igc29tZSByZWFzb24gaXQgd291bGQgcHJv YmFibHkgYmUgCmdvb2QgdG8gcHV0IGEgY29tbWVudCBleHBsYWluaW5nIGl0LgoKT3IgSSBhbSBt aXNzaW5nIHNvbWV0aGluZz8KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK