From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Gordon Subject: Re: [PATCH v2 7/8] drm/i915: Grab execlist spinlock to avoid post-reset concurrency issues. Date: Fri, 23 Oct 2015 13:49:57 +0100 Message-ID: <562A2CF5.5010100@intel.com> References: <1444329100-19189-8-git-send-email-tomas.elf@intel.com> <1445268752-19155-1-git-send-email-tomas.elf@intel.com> <5629F2F3.2000308@linux.intel.com> <20151023085951.GL16848@phenom.ffwll.local> <562A13D7.9030609@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id BBEB46E1D5 for ; Fri, 23 Oct 2015 05:50:00 -0700 (PDT) In-Reply-To: <562A13D7.9030609@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Tomas Elf , Daniel Vetter , Tvrtko Ursulin Cc: "Intel-GFX@Lists.FreeDesktop.Org" List-Id: intel-gfx@lists.freedesktop.org T24gMjMvMTAvMTUgMTI6MDIsIFRvbWFzIEVsZiB3cm90ZToKPiBPbiAyMy8xMC8yMDE1IDA5OjU5 LCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+PiBPbiBGcmksIE9jdCAyMywgMjAxNSBhdCAwOTo0Mjoy N0FNICswMTAwLCBUdnJ0a28gVXJzdWxpbiB3cm90ZToKPj4+Cj4+PiBPbiAxOS8xMC8xNSAxNjoz MiwgVG9tYXMgRWxmIHdyb3RlOgo+Pj4+IEdyYWIgZXhlY2xpc3QgbG9jayB3aGVuIGNsZWFuaW5n IHVwIGV4ZWNsaXN0IHF1ZXVlcyBhZnRlciBHUFUgcmVzZXQKPj4+PiB0byBhdm9pZAo+Pj4+IGNv bmN1cnJlbmN5IHByb2JsZW1zIGJldHdlZW4gdGhlIGNvbnRleHQgZXZlbnQgaW50ZXJydXB0IGhh bmRsZXIgYW5kCj4+Pj4gdGhlIHJlc2V0Cj4+Pj4gcGF0aCBpbW1lZGlhdGVseSBmb2xsb3dpbmcg YSBHUFUgcmVzZXQuCj4+Pj4KPj4+PiAqIHYyIChDaHJpcyBXaWxzb24pOgo+Pj4+IERvIGV4ZWNs aXN0IGNoZWNrIGFuZCB1c2Ugc2ltcGxlciBmb3JtIG9mIHNwaW5sb2NrIGZ1bmN0aW9ucy4KPj4+ Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IFRvbWFzIEVsZiA8dG9tYXMuZWxmQGludGVsLmNvbT4KPj4+ PiAtLS0KPj4+PiAgIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2VtLmMgfCAyMyArKysrKysr KysrKysrKy0tLS0tLS0tLQo+Pj4+ICAgMSBmaWxlIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyks IDkgZGVsZXRpb25zKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaTkxNV9nZW0uYwo+Pj4+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9nZW0uYwo+Pj4+ IGluZGV4IGU1NzA2MWEuLjJjN2EwYjcgMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9nZW0uYwo+Pj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZ2Vt LmMKPj4+PiBAQCAtMjc1MywxOCArMjc1MywyMyBAQCBzdGF0aWMgdm9pZAo+Pj4+IGk5MTVfZ2Vt X3Jlc2V0X3JpbmdfY2xlYW51cChzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYsCj4+ Pj4gICAgICAgICogYXJlIHRoZSBvbmVzIHRoYXQga2VlcCB0aGUgY29udGV4dCBhbmQgcmluZ2J1 ZmZlciBiYWNraW5nCj4+Pj4gb2JqZWN0cwo+Pj4+ICAgICAgICAqIHBpbm5lZCBpbiBwbGFjZS4K Pj4+PiAgICAgICAgKi8KPj4+PiAtICAgIHdoaWxlICghbGlzdF9lbXB0eSgmcmluZy0+ZXhlY2xp c3RfcXVldWUpKSB7Cj4+Pj4gLSAgICAgICAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0ICpz dWJtaXRfcmVxOwo+Pj4+Cj4+Pj4gLSAgICAgICAgc3VibWl0X3JlcSA9IGxpc3RfZmlyc3RfZW50 cnkoJnJpbmctPmV4ZWNsaXN0X3F1ZXVlLAo+Pj4+IC0gICAgICAgICAgICAgICAgc3RydWN0IGRy bV9pOTE1X2dlbV9yZXF1ZXN0LAo+Pj4+IC0gICAgICAgICAgICAgICAgZXhlY2xpc3RfbGluayk7 Cj4+Pj4gLSAgICAgICAgbGlzdF9kZWwoJnN1Ym1pdF9yZXEtPmV4ZWNsaXN0X2xpbmspOwo+Pj4+ ICsgICAgaWYgKGk5MTUuZW5hYmxlX2V4ZWNsaXN0cykgewo+Pj4+ICsgICAgICAgIHNwaW5fbG9j a19pcnEoJnJpbmctPmV4ZWNsaXN0X2xvY2spOwo+Pj4+ICsgICAgICAgIHdoaWxlICghbGlzdF9l bXB0eSgmcmluZy0+ZXhlY2xpc3RfcXVldWUpKSB7Cj4+Pj4gKyAgICAgICAgICAgIHN0cnVjdCBk cm1faTkxNV9nZW1fcmVxdWVzdCAqc3VibWl0X3JlcTsKPj4+Pgo+Pj4+IC0gICAgICAgIGlmIChz dWJtaXRfcmVxLT5jdHggIT0gcmluZy0+ZGVmYXVsdF9jb250ZXh0KQo+Pj4+IC0gICAgICAgICAg ICBpbnRlbF9scl9jb250ZXh0X3VucGluKHN1Ym1pdF9yZXEpOwo+Pj4+ICsgICAgICAgICAgICBz dWJtaXRfcmVxID0gbGlzdF9maXJzdF9lbnRyeSgmcmluZy0+ZXhlY2xpc3RfcXVldWUsCj4+Pj4g KyAgICAgICAgICAgICAgICAgICAgc3RydWN0IGRybV9pOTE1X2dlbV9yZXF1ZXN0LAo+Pj4+ICsg ICAgICAgICAgICAgICAgICAgIGV4ZWNsaXN0X2xpbmspOwo+Pj4+ICsgICAgICAgICAgICBsaXN0 X2RlbCgmc3VibWl0X3JlcS0+ZXhlY2xpc3RfbGluayk7Cj4+Pj4KPj4+PiAtICAgICAgICBpOTE1 X2dlbV9yZXF1ZXN0X3VucmVmZXJlbmNlKHN1Ym1pdF9yZXEpOwo+Pj4+ICsgICAgICAgICAgICBp ZiAoc3VibWl0X3JlcS0+Y3R4ICE9IHJpbmctPmRlZmF1bHRfY29udGV4dCkKPj4+PiArICAgICAg ICAgICAgICAgIGludGVsX2xyX2NvbnRleHRfdW5waW4oc3VibWl0X3JlcSk7Cj4+Pj4gKwo+Pj4+ ICsgICAgICAgICAgICBpOTE1X2dlbV9yZXF1ZXN0X3VucmVmZXJlbmNlKHN1Ym1pdF9yZXEpOwo+ Pj4+ICsgICAgICAgIH0KPj4+PiArICAgICAgICBzcGluX3VubG9ja19pcnEoJnJpbmctPmV4ZWNs aXN0X2xvY2spOwo+Pj4KPj4+IENhbid0IHRoaXMsIGluIHRoZW9yeSBhdCBsZWFzdCwgZW5kIHVw IGNhbGxpbmcKPj4+IGRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlIGluCj4+PiBhIGNvdXBsZSBv ZiBjb2RlIHBhdGhzLCB3aGljaCBjYW4gc2xlZXAsIHdoaWxlIGhvbGRpbmcgYSBzcGlubG9jaz8K Pj4+Cj4+PiBJZiB0aGlzIGNhbm5vdCBoYXBwZW4gaW4gcHJhY3RpY2UgZm9yIHNvbWUgcmVhc29u IGl0IHdvdWxkIHByb2JhYmx5Cj4+PiBiZSBnb29kCj4+PiB0byBwdXQgYSBjb21tZW50IGV4cGxh aW5pbmcgaXQuCj4+Pgo+Pj4gT3IgSSBhbSBtaXNzaW5nIHNvbWV0aGluZz8KPj4KPj4gSXQgY2Fu IGluZGVlZCBJIHRoaW5rLiBUdnJ0a28sIHNpbmNlIEknbSBvZmYgdG8gS1MgbmV4dCB3ZWVrIGFu ZCB5b3UgaGF2ZQo+PiBwdXNoIGFjY2VzcywgY2FuIHlvdSBwbHMgcHVzaCB0aGUgcmV2ZXJ0IGlm IHRoaXMgY2hlY2tzIG91dD8KPgo+IEkndmUgZGlzY3Vzc2VkIGl0IHdpdGggVHZydGtvIGFuZCBv bmUgc29sdXRpb24gdGhhdCBzZWVtcyByZWFzb25hYmxlIGlzCj4gdG8gaG9sZCB0aGUgZXhlY2xp c3QgbG9jayB3aGlsZSB0cmF2ZXJzaW5nIHRoZSBleGVjbGlzdCBxdWV1ZSBhbmQgbW92aW5nCj4g dGhlIGVsZW1lbnRzIG92ZXIgdG8gYSB0ZW1wb3JhcnkgbGlzdC4gQWZ0ZXIgdGhhdCB3ZSBjYW4g ZHJvcCB0aGUKPiBleGVjbGlzdCBsb2NrLCB0cmF2ZXJzZSB0aGUgdGVtcG9yYXJ5IGxpc3QgYW5k IHVucmVmZXJlbmNlIHRoZSBlbGVtZW50cwo+IHdoaWxlIG5vdCBob2xkaW5nIGxvY2suIFRoYXQg d2F5IHdlIGNhbiBnZXQgcmlkIG9mIHRoZSBlbGVtZW50IGluIGEKPiBzeW5jaHJvbml6ZWQgZmFz aGlvbiBhbmQgYWxzbyB1bnJlZmVyZW5jZSB3aXRob3V0IGhvbGRpbmcgdGhlIGxvY2suIEkKPiBi ZWxpZXZlIHRoaXMgcGF0dGVybiBpcyB1c2VkIGVsc2V3aGVyZSAoc3VjaCBhcyBkdXJpbmcgcmVx dWVzdCByZXRpcmVtZW50KQo+Cj4gRG9lcyB0aGF0IHNvdW5kIGxpa2UgYSBwbGFuIG9yIGRvZXMg YW55b25lIGhhdmUgYSBwcm9ibGVtIHdpdGggdGhhdAo+IHNvbHV0aW9uPwo+Cj4gVGhhbmtzLAo+ IFRvbWFzCgpJIHRoaW5rIHRoZSBvcmlnaW5hbCBpcyBzYWZlLCBiZWNhdXNlIHRoZSBleGVjbGlz dCBxdWV1ZSAvc2hvdWxkbid0LyBiZSAKdGhlIGxhc3QgcmVmZXJlbmNlLiBCdXQgdGhhdCBjb3Vs ZCBjaGFuZ2UsIGFuZCBpbiBhbnkgY2FzZSBpbiBhIHBvc3NpYmx5IApicm9rZW4gc3RhdGUgc3Vj aCBhcyBtYXkgaGF2ZSBjYXVzZWQgdGhlIGhhbmcgd2UgcHJvYmFibHkgc2hvdWxkbid0IHJlbHkg Cm9uIGl0LiBTbyBJIHRoaW5rIHRoZSBzdGFnZWQtZGVxdWV1ZS1hbmQtcmVsZWFzZSBpcyBhIGJl dHRlciBzb2x1dGlvbiA6KQoKLkRhdmUuCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2ludGVsLWdmeAo=