All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@wwwdotorg.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/8] dm: pci: Avoid a driver model build error with CONFIG_CMD_PCI_ENUM
Date: Fri, 23 Oct 2015 11:30:04 -0600	[thread overview]
Message-ID: <562A6E9C.6050008@wwwdotorg.org> (raw)
In-Reply-To: <CAPnjgZ3x=pYcp72=Ae1O5Lc1Mupv80zot6U_9z-ob4isbQ5E_w@mail.gmail.com>

On 10/23/2015 09:47 AM, Simon Glass wrote:
> Hi Stephen,
>
> On 21 October 2015 at 14:16, Stephen Warren <swarren@wwwdotorg.org> wrote:
>> On 10/17/2015 11:49 AM, Simon Glass wrote:
>>>
>>> This is not supported with driver model, so print a message instead of
>>> generating a build error. Rescanning PCI is not yet implemented.
>>
>>
>>> diff --git a/common/cmd_pci.c b/common/cmd_pci.c
>>
>>
>>> @@ -457,7 +457,11 @@ static int do_pci(cmd_tbl_t *cmdtp, int flag, int
>>> argc, char * const argv[])
>>>                  return pci_cfg_display(bdf, addr, size, value);
>>>    #ifdef CONFIG_CMD_PCI_ENUM
>>>          case 'e':
>>> +# ifdef CONFIG_DM_PCI
>>> +               printf("This command is not yet supported with driver
>>> model\n");
>>> +# else
>>>                  pci_init();
>>> +# endif
>>
>>
>> That feature is enabled on most/all Tegra boards with PCI support. Hopefully
>> nobody will miss it; I guess I haven't used it so I don't object to this
>> change.
>>
>> However, wouldn't it be better to remove CONFIG_CMD_PCI_ENUM from the config
>> header rather than leaving the command enabled yet non-functional? Or are
>> you planning on implementing this path in the near future?
>
> I was looking for feedback on why anyone would use this option. It's
> not clear to me what it is for.

I assume it's to support hot-pluggable PCI connectors? Or perhaps it's 
just useful during debug of PCI drivers?

> We can implement it for driver model if it is needed.

I'd be happy disabling it in the configs myself. Thierry, you enabled 
the option when you first implemented the Tegra PCIe controller driver. 
Do you have a preference?

  reply	other threads:[~2015-10-23 17:30 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-17 17:49 [U-Boot] [PATCH 0/8] dm: pci: tegra: Convert Tegra PCI to driver model Simon Glass
2015-10-17 17:49 ` [U-Boot] [PATCH 1/8] dm: tegra: pci: Move CONFIG_PCI_TEGRA to Kconfig Simon Glass
2015-10-21 20:13   ` Stephen Warren
2015-10-23 15:45     ` Simon Glass
2015-10-17 17:49 ` [U-Boot] [PATCH 2/8] dm: pci: Avoid a driver model build error with CONFIG_CMD_PCI_ENUM Simon Glass
2015-10-21 20:16   ` Stephen Warren
2015-10-23 15:47     ` Simon Glass
2015-10-23 17:30       ` Stephen Warren [this message]
2015-11-09 14:33         ` Thierry Reding
2015-10-17 17:50 ` [U-Boot] [PATCH 3/8] RFC: dm: pci: Set up the SDRAM mapping correctly Simon Glass
2015-10-21 20:19   ` Stephen Warren
2015-10-17 17:50 ` [U-Boot] [PATCH 4/8] dm: pci: Support decoding ranges with duplicate entries Simon Glass
2015-10-21 20:25   ` Stephen Warren
2015-10-23 15:50     ` Simon Glass
2015-10-17 17:50 ` [U-Boot] [PATCH 5/8] dm: pci: Add functions to emulate 8- and 16-bit access Simon Glass
2015-10-21 20:29   ` Stephen Warren
2015-10-17 17:50 ` [U-Boot] [PATCH 6/8] dm: pci: Add a function to get the controller for a bus Simon Glass
2015-10-25  3:11   ` Bin Meng
2015-10-17 17:50 ` [U-Boot] [PATCH 7/8] dm: pci: Add a function to find the regions for a PCI bus Simon Glass
2015-10-21 20:31   ` Stephen Warren
2015-10-17 17:50 ` [U-Boot] [PATCH 8/8] dm: tegra: pci: Convert tegra boards to driver model for PCI Simon Glass
2015-10-21 20:46   ` Stephen Warren
2015-11-12 16:06     ` Simon Glass

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=562A6E9C.6050008@wwwdotorg.org \
    --to=swarren@wwwdotorg.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.